Contributors

• 36
• 37
• 38
• 39
• 40

• Tax and account mapping depending of the product/category

  Hi all I have created a discussion on github here (maybe easier to discuss and to keep an history)

  https://github.com/OCA/account-fiscal-rule/discussions/298

  
  

  I copy/paste the description of the discussion

  
  

  Issue
  

  When selling in Europe (or only in France but with some special dom-tom case), you need to apply local tax when reaching a certain amount. And sometime you need to map the tax (and also the account) depending of the product.

  For example you sell products A and B with the tax 20% in France
  But you need to sell it with a tax 13% for product A and 16% for product B in some fiscal position.

  Right now it's impossible to do it

  
  

  
  

  Solution
  

  I would like to introduce a new module account_fiscal_product_rule

  That will have the following data models

  
  class AccountFiscalPositionProductRule():
  
      name = fields.Char()
      fiscal_position_id = fields.Many2one("account.fiscal.position")
      product_tmpl_ids = fields.Many2many("product.template")
      category_ids = fields.Many2many("product.category")
      account_income_id = fields.Many2one("account.account")
      account_expense_id = fields.Many2one("account.account")
      seller_tax_ids = fields.Many2Many("account.tax")
      supplier_tax_ids = fields.Many2Many("account.tax")
  
  
  class ProductCategory():
  
      fiscal_position_product_rule_ids = fields.Many2many("account.fiscal.position.product.rule")
  
  
  class ProductTemplate():
  
      fiscal_position_product_rule_ids = fields.Many2many("account.fiscal.position.product.rule")
  
  
  

  Then we can inherit the mapping logic (tax and account) to apply first this "specific rule" and if not rule match apply native rules

  Describe alternatives you've considered

  I had thinking about adding product_ids and category_ids on "account.fiscal.position.account" and "account.fiscal.position.tax". But the UI not really good for end user (too much configuration), and code will be not so easy to inherit.

  
  

  
  

  Thanks for your feedback (please put it in github)
  

  ---

  by Sébastien Beau - 09:45 - 11 Jul 2022

  6 replies 6 replies

  • RE: Tax and account mapping depending of the product/category

    Hi,

     

    Can this not been tackled with fiscal position ? In Belgium we have 4 TVA regimes when building product are installed : 21 % ( normal ), TVA compensated ( for companies ), 6 % ( private customers with houses older than 10 years ) and 12 % ( social housing ). So we create 4 fiscal positions and choose the right one on sales order. You could use a same approach. I guess the TVA rates are at least for groups of products. Because when you have 200.000 products ( and that’s not that much ) it become unmaintainable when you have to apply a different TVA to every product…

     

    With kind regards,

     

    Van Hirtum Johan

     

    Van: Sebastien Beau [mailto:notifications@odoo-community.org]
    Verzonden: maandag 11 juli 2022 23:02
    Aan: Contributors
    Onderwerp: Re: Tax and account mapping depending of the product/category

     

    Hi Thorsten

     

    We already think about it, but the issue is that we do not have only one case, so at the end I fear that we end with something like

    20% (standard rate france / special foreign tax 16% / other location foreign tax 18%)

    With a big list of taxe that match all the possible combinations

     

    Thanks for your feedback

     

     

    Le lun. 11 juil. 2022 à 11:02, Thorsten Vocks <notifications@odoo-community.org> a écrit :

    Hi,

     

    as ugly workaround: 

     

    Wouldn't it be possible to duplicate the standard tax as you mentioned "20% (standard rate france)" 

    to "20% (standard rate france / special foreign tax 16%)" and ...

     

    a.) assign this duplicated standard tax to the product (product "B" in your example)

    b.) add this tax in the fiscal position on the tax mapping tab (20% -> 16% ) after the regular tax mapping of the fiscal position (20% -> 13%).

     

     

    Best regards

     

    Thorsten Vocks
    
    openBIG.org
    Dipl. Kaufmann (FH)
    Porscheweg 4-6
    49661 Cloppenburg
    
    Phone: +49 4471 8409000
    Fax: +49 4471 84090009
    Mail: thorsten.vocks@openbig.org

    Web: http://www.openbig.org

     

                  

     

     

    Am Mo., 11. Juli 2022 um 10:42 Uhr schrieb Sebastien Beau <notifications@odoo-community.org>:

    Thanks Pedro for your feedback, but it's not the same issue.

     

    This great module helps to easily configure the tax mapping (it generates all the fiscal position and tax mapping and save us a lot of time).

     

    Here the case is more complexe sometime depending on the product you can not map a normal tax to a normal tax but sometime for legal reasons the tax in the dest country is a Reduce one or a Super Reduced Tax.

     

    We need to handle this case

     

     

     

    Le lun. 11 juil. 2022 à 09:56, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> a écrit :

    Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    ---

    by johan - 02:20 - 12 Jul 2022

  • Re: Tax and account mapping depending of the product/category

    Hi Thorsten

    
    

    We already think about it, but the issue is that we do not have only one case, so at the end I fear that we end with something like

    20% (standard rate france / special foreign tax 16% / other location foreign tax 18%)

    With a big list of taxe that match all the possible combinations
    

    
    

    Thanks for your feedback
    

    
    

    
    

    Le lun. 11 juil. 2022 à 11:02, Thorsten Vocks <notifications@odoo-community.org> a écrit :
    

    Hi,

    
    

    as ugly workaround: 

    
    

    Wouldn't it be possible to duplicate the standard tax as you mentioned "20% (standard rate france)" 

    to "20% (standard rate france / special foreign tax 16%)" and ...

    
    

    a.) assign this duplicated standard tax to the product (product "B" in your example)

    b.) add this tax in the fiscal position on the tax mapping tab (20% -> 16% ) after the regular tax mapping of the fiscal position (20% -> 13%).

    
    

    
    

    Best regards

     

    Thorsten Vocks
    
    openBIG.org
    Dipl. Kaufmann (FH)
    Porscheweg 4-6
    49661 Cloppenburg
    
    Phone: +49 4471 8409000
    Fax: +49 4471 84090009
    Mail: thorsten.vocks@openbig.org

    Web: http://www.openbig.org
    

    
    

                  

    
    

    
    

    Am Mo., 11. Juli 2022 um 10:42 Uhr schrieb Sebastien Beau <notifications@odoo-community.org>:
    

    Thanks Pedro for your feedback, but it's not the same issue.

    
    

    This great module helps to easily configure the tax mapping (it generates all the fiscal position and tax mapping and save us a lot of time).

    
    

    Here the case is more complexe sometime depending on the product you can not map a normal tax to a normal tax but sometime for legal reasons the tax in the dest country is a Reduce one or a Super Reduced Tax.

    
    

    We need to handle this case
    

    
    

    
    

    
    

    Le lun. 11 juil. 2022 à 09:56, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> a écrit :
    

    Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Sébastien Beau - 11:01 - 11 Jul 2022

  • Re: Tax and account mapping depending of the product/category

    Hi,

    
    

    as ugly workaround: 

    
    

    Wouldn't it be possible to duplicate the standard tax as you mentioned "20% (standard rate france)" 

    to "20% (standard rate france / special foreign tax 16%)" and ...

    
    

    a.) assign this duplicated standard tax to the product (product "B" in your example)

    b.) add this tax in the fiscal position on the tax mapping tab (20% -> 16% ) after the regular tax mapping of the fiscal position (20% -> 13%).

    
    

    
    

    Best regards

     

    Thorsten Vocks
    
    openBIG.org
    Dipl. Kaufmann (FH)
    Porscheweg 4-6
    49661 Cloppenburg
    
    Phone: +49 4471 8409000
    Fax: +49 4471 84090009
    Mail: thorsten.vocks@openbig.org

    Web: http://www.openbig.org
    

    
    

                  

    
    

    
    

    Am Mo., 11. Juli 2022 um 10:42 Uhr schrieb Sebastien Beau <notifications@odoo-community.org>:
    

    Thanks Pedro for your feedback, but it's not the same issue.

    
    

    This great module helps to easily configure the tax mapping (it generates all the fiscal position and tax mapping and save us a lot of time).

    
    

    Here the case is more complexe sometime depending on the product you can not map a normal tax to a normal tax but sometime for legal reasons the tax in the dest country is a Reduce one or a Super Reduced Tax.

    
    

    We need to handle this case
    

    
    

    
    

    
    

    Le lun. 11 juil. 2022 à 09:56, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> a écrit :
    

    Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Thorsten Vocks - 11:01 - 11 Jul 2022

  • Re: Tax and account mapping depending of the product/category

    Thanks Pedro for your feedback, but it's not the same issue.

    
    

    This great module helps to easily configure the tax mapping (it generates all the fiscal position and tax mapping and save us a lot of time).

    
    

    Here the case is more complexe sometime depending on the product you can not map a normal tax to a normal tax but sometime for legal reasons the tax in the dest country is a Reduce one or a Super Reduced Tax.

    
    

    We need to handle this case
    

    
    

    
    

    
    

    Le lun. 11 juil. 2022 à 09:56, Pedro M. Baeza (Tecnativa) <notifications@odoo-community.org> a écrit :
    

    Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Sébastien Beau - 10:40 - 11 Jul 2022

  • Re: Tax and account mapping depending of the product/category

    Not quite Pedro, OSS afaik is mapping based on the country of the actual 
    delivery (plus some edge cases).
    
    Best Frederik
    
    Am 11.07.22 um 09:56 schrieb Pedro M. Baeza (Tecnativa):
    
    > Isn't this OSS? https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss [1]
    
    > _______________________________________________
    
    > Mailing-List: https://odoo-community.org/groups/contributors-15 [2]
    
    > Post to: mailto:contributors@odoo-community.org
    
    > Unsubscribe: https://odoo-community.org/groups?unsubscribe [3]
    
    >
    
    >
    
    >
    
    > [1] https://github.com/OCA/account-fiscal-rule/tree/14.0/l10n_eu_oss
    
    > [2] https://odoo-community.org/groups/contributors-15
    
    > [3] https://odoo-community.org/groups?unsubscribe
    
    >
    
    -- 
    Dr.-Ing. Frederik Kramer
    Geschäftsführer
    
    initOS GmbH
    Innungsstraße 7
    21244 Buchholz i.d.N.
    
    Phone:  +49 4181 13503-12
    Fax:    +49 4181 13503-10
    Mobil:  +49 179 3901819
    
    Email: frederik.kramer@initos.com
    Web:   www.initos.com
    
    Geschäftsführung:
    Dr.-Ing. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke
    
    Sitz der Gesellschaft: Buchholz i.d.N.
    Amtsgericht Tostedt, HRB 205226
    Steuer-Nr: 15/200/53247
    USt-IdNr.: DE815580155
    
    

    ---

    by Frederik Kramer - 10:40 - 11 Jul 2022

  1 more replies

• Review tags

  Hi, 

  
  

  regarding the mass mailing happening here: https://github.com/OCA/timesheet/pull/473 I don't know if there's some way to avoid that from happening (but being not very github savvy I don't even know what's the purpose of the oca-contributors team).

  
  

  On the other hand, I've seen many devs requesting reviews but not knowing who to ask; could it be an idea to create a team to be used for requesting reviews? Signup would be voluntary, of course, and those requests could be easily filtered in the inbox. What do you think?

  
  

  Thanks, 

  
  --
  

  
  

  Francesco Foresti

  Sicurpharma Srl

  
  

  ---

  by Francesco Foresti - 03:36 - 8 Jul 2022

• OpenUpgrade Survey - closes Wednesday 6th July - you still have time to have your say..

  Hello OCA Contributors,

  
  

  I hope you are all doing well. 

  
  

  Just a quick reminder that our OpenUpgrade survey closes after Wednesday 6th July. Make sure you have your say.

  
  

  To find out more details in case you missed it, please check out the blog.

  
  

  Also, the planning is underway for OCA Days, please register now if you haven't so we know what sort of numbers to plan for.

  
  

  We are taking talk proposals - if you have a presentation, tutorial, workshop, discussion topic to lead, module update etc, we would love to hear from you - just fill in this form.
  
  As always, thanks for your input - this helps the community stay connected and dynamic.

  
  

  Take care,

  Rebecca

  
  

  --
  

  Rebecca Gellatly

  General Secretary

  Odoo Community Association

  ---

  by Rebecca Gellatly - 02:06 - 6 Jul 2022

  1 replies 1 replies

  • Re: OpenUpgrade Survey - closes Wednesday 6th July - you still have time to have your say..

    Answered!

    
    

    El mar, 5 jul 2022 a la(s) 21:07, Rebecca Gellatly (notifications@odoo-community.org) escribió:
    

    Hello OCA Contributors,

    
    

    I hope you are all doing well. 

    
    

    Just a quick reminder that our OpenUpgrade survey closes after Wednesday 6th July. Make sure you have your say.

    
    

    To find out more details in case you missed it, please check out the blog.

    
    

    Also, the planning is underway for OCA Days, please register now if you haven't so we know what sort of numbers to plan for.

    
    

    We are taking talk proposals - if you have a presentation, tutorial, workshop, discussion topic to lead, module update etc, we would love to hear from you - just fill in this form.
    
    As always, thanks for your input - this helps the community stay connected and dynamic.

    
    

    Take care,

    Rebecca

    
    

    --
    

    Rebecca Gellatly

    General Secretary

    Odoo Community Association

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Gonzalo Ruzafa. - 02:30 - 6 Jul 2022

• test mail

  Somebody gets this message?
  

  ---

  by Jairo Llopis - 05:30 - 1 Jul 2022

  20 replies 20 replies

  • Re: test mail

    +1
    

    
    

    On Sat, Jul 2, 2022 at 9:17 PM Antonio M. Vigliotti (gmail) <notifications@odoo-community.org> wrote:
    

    Yes
    
    

    Antonio M. Vigliotti

    
    Mobile (+39) 342.8740910
    

    
    
    

    Il 01/07/22 18:22, Francesco Apruzzese ha scritto:
    

    Il giorno ven 1 lug 2022 alle ore 18:17 Marco Beri <notifications@odoo-community.org> ha scritto:
    

    PLEASE STOP TO ANSWER "YES"!

    
    

    Ok Marco!

     

    
    

    He got It.
    

    
    

    Thank you.

    
    

    
    

    On Fri, 1 Jul 2022, 18:11 Hannaske, Reiner (Intero Technologies), <notifications@odoo-community.org> wrote:
    

    Yes

    
    

    Reiner Hannaske Account Manager

    Tel.: +49 3831 44557-41 Mobil: +49 170 9216129 E-Mail: r.hannaske@intero-technolgies.de Website: www.intero-technologies.de

    Intero Technologies GmbH Heinrich-Heine-Ring 76 18435 Stralsund

    Weitere Standorte der Intero Technologies GmbH

    Bessemerstraße 82 12103 Berlin

    Heidenkampsweg 58 20097 Hamburg

    Kleiststraße 23 65187 Wiesbaden

    Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

    Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

    
    

    ---

    Von: "Jairo Llopis" <notifications@odoo-community.org>
    An: "Contributors" <contributors@odoo-community.org>
    Gesendet: Freitag, 1. Juli 2022 17:30:30
    Betreff: test mail
    

    
    

    Somebody gets this message?
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    

    Francesco Apruzzese

    
    

    Profilo professionale: http://it.linkedin.com/in/francescoapruzzese
    
    Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
    This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.
    
    Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Simone Rubino - 09:16 - 4 Jul 2022

  • Re: test mail

    Yes
    
    

    Antonio M. Vigliotti

    
    Mobile (+39) 342.8740910
    

    
    
    

    Il 01/07/22 18:22, Francesco Apruzzese ha scritto:
    

    Il giorno ven 1 lug 2022 alle ore 18:17 Marco Beri <notifications@odoo-community.org> ha scritto:
    

    PLEASE STOP TO ANSWER "YES"!

    
    

    Ok Marco!

     

    
    

    He got It.
    

    
    

    Thank you.

    
    

    
    

    On Fri, 1 Jul 2022, 18:11 Hannaske, Reiner (Intero Technologies), <notifications@odoo-community.org> wrote:
    

    Yes

    
    

    Reiner Hannaske Account Manager

    Tel.: +49 3831 44557-41 Mobil: +49 170 9216129 E-Mail: r.hannaske@intero-technolgies.de Website: www.intero-technologies.de

    Intero Technologies GmbH Heinrich-Heine-Ring 76 18435 Stralsund

    Weitere Standorte der Intero Technologies GmbH

    Bessemerstraße 82 12103 Berlin

    Heidenkampsweg 58 20097 Hamburg

    Kleiststraße 23 65187 Wiesbaden

    Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

    Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

    
    

    ---

    Von: "Jairo Llopis" <notifications@odoo-community.org>
    An: "Contributors" <contributors@odoo-community.org>
    Gesendet: Freitag, 1. Juli 2022 17:30:30
    Betreff: test mail
    

    
    

    Somebody gets this message?
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    

    Francesco Apruzzese

    
    

    Profilo professionale: http://it.linkedin.com/in/francescoapruzzese
    
    Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
    This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.
    
    Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    ---

    by Antonio M. Vigliotti - 09:15 - 2 Jul 2022

    3 attachments 3 attachments

    AntonioMariaVigliotti_html_2a3b0efbc5e4661a.png

    AntonioMariaVigliotti_html_51f470c428b0fa9b.png

    AntonioMariaVigliotti_html_60baa43d7331dc71.png

  • Re: test mail

    Il giorno ven 1 lug 2022 alle ore 18:17 Marco Beri <notifications@odoo-community.org> ha scritto:
    

    PLEASE STOP TO ANSWER "YES"!

    
    

    Ok Marco!

     

    
    

    He got It.
    

    
    

    Thank you.

    
    

    
    

    On Fri, 1 Jul 2022, 18:11 Hannaske, Reiner (Intero Technologies), <notifications@odoo-community.org> wrote:
    

    Yes

    
    

    Reiner Hannaske Account Manager

    Tel.: +49 3831 44557-41 Mobil: +49 170 9216129 E-Mail: r.hannaske@intero-technolgies.de Website: www.intero-technologies.de

    Intero Technologies GmbH Heinrich-Heine-Ring 76 18435 Stralsund

    Weitere Standorte der Intero Technologies GmbH

    Bessemerstraße 82 12103 Berlin

    Heidenkampsweg 58 20097 Hamburg

    Kleiststraße 23 65187 Wiesbaden

    Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

    Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

    
    

    ---

    Von: "Jairo Llopis" <notifications@odoo-community.org>
    An: "Contributors" <contributors@odoo-community.org>
    Gesendet: Freitag, 1. Juli 2022 17:30:30
    Betreff: test mail
    

    
    

    Somebody gets this message?
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    

    Francesco Apruzzese

    
    

    Profilo professionale: http://it.linkedin.com/in/francescoapruzzese
    
    Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
    This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.
    
    Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.
    

    ---

    by Francesco Apruzzese - 06:20 - 1 Jul 2022

  • Re: test mail

    PLEASE STOP TO ANSWER "YES"!

    
    

    He got It.
    

    
    

    Thank you.

    
    

    
    

    On Fri, 1 Jul 2022, 18:11 Hannaske, Reiner (Intero Technologies), <notifications@odoo-community.org> wrote:
    

    Yes

    
    

    Reiner Hannaske Account Manager

    Tel.: +49 3831 44557-41 Mobil: +49 170 9216129 E-Mail: r.hannaske@intero-technolgies.de Website: www.intero-technologies.de

    Intero Technologies GmbH Heinrich-Heine-Ring 76 18435 Stralsund

    Weitere Standorte der Intero Technologies GmbH

    Bessemerstraße 82 12103 Berlin

    Heidenkampsweg 58 20097 Hamburg

    Kleiststraße 23 65187 Wiesbaden

    Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

    Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

    
    

    ---

    Von: "Jairo Llopis" <notifications@odoo-community.org>
    An: "Contributors" <contributors@odoo-community.org>
    Gesendet: Freitag, 1. Juli 2022 17:30:30
    Betreff: test mail
    

    
    

    Somebody gets this message?
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Marco Beri - 06:15 - 1 Jul 2022

  • Re: test mail

    Yes

    
    

    Reiner Hannaske Account Manager

    Tel.: +49 3831 44557-41 Mobil: +49 170 9216129 E-Mail: r.hannaske@intero-technolgies.de Website: www.intero-technologies.de

    Intero Technologies GmbH Heinrich-Heine-Ring 76 18435 Stralsund

    Weitere Standorte der Intero Technologies GmbH

    Bessemerstraße 82 12103 Berlin

    Heidenkampsweg 58 20097 Hamburg

    Kleiststraße 23 65187 Wiesbaden

    Geschäftsführer: Frank Löffler, Lars Lifson USt-Id: DE 251251697, AG Stralsund HRB 7076

    Alle Informationen zum Datenschutz gem. Art. 13 finden Sie hier. Auf Wunsch senden wir Ihnen diese Informationen gerne auch per PDF oder in gedruckter Form zu.

    
    

    ---

    Von: "Jairo Llopis" <notifications@odoo-community.org>
    An: "Contributors" <contributors@odoo-community.org>
    Gesendet: Freitag, 1. Juli 2022 17:30:30
    Betreff: test mail
    

    
    

    Somebody gets this message?
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    ---

    by R. Hannaske - 06:11 - 1 Jul 2022

  15 more replies

• Tip: Always call `clean_action` when returning an `ir.actions.act_window`

  Hi,

  
  

  Simple tip after losing my afternoon on this:

  If you add a python `action_open_view_xxx` code that returns an `ir.actions.act_window` dict, you should always use the built-in `clean_action` that will convert any `tree` to `list`, otherwise the list view will be missing from the web client.

  Note that this fix is always done internally by the webclient.

  
  

  from odoo.addons.web.controllers.main import clean_action

  
  

  class ProjectProject(models.Model):

      _inherit = 'project.project'

  
  

      def action_open_all_tasks(self, view_domain=False, view_type=False):

          act = clean_action(self.env.ref("project.action_view_task").read()[0])         return act

  
  

  
  

  --
  Yann PAPOUIN, Ingénieur R&D | DEC

  ---

  by Yann Papouin - 04:55 - 30 Jun 2022

• New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

  Currently, we are using pylint-odoo project as pre-commit hooks for other kind of files

  
  

  Now, we are using pre-commit for new projects.

  
  

  So we can remove all the checks unrelated with python from pylint-odoo

  e.g. eslint (javascript lints), XML checks, PO (translations) checks and so on

  
  

  Then they could be replaced in the pre-commit configuration file with the id of the related check

  
  

  e.g. eslint see https://github.com/pre-commit/mirrors-eslint

  
  

  There are other custom checks in pylint-odoo as unnecessary-utf8-coding-comment

  But it is duplicated with the following hook id fix-encoding-pragma from:

   - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/fix_encoding_pragma.py

  
  

  It even has the option to auto-fix it

  
  

  Similar case for pylint-odoo check incoherent-interpreter-exec-perm:
  

   - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_executables_have_shebangs.py

  
  

  Similar case for pylint-odoo check wrong-tabs-instead-of-spaces

   - https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/remove_tabs.py
  

  
  

  They are duplicated from pylint-odoo and they are better since they have the option to auto-fix if you want.

  
  

  But there are other kinds of custom checks in pylint-odoo unrelated with python files that could be good to create a new pre-commit-hook custom for Odoo modules

  
  

  In order to check XMLs, PO, CSS, CSV, and so on in the context of Odoo modules.

  
  

  Currently, pylint-odoo is overloaded trying to do checks for non-python code since the core is not supporting check non-python files

  And pylint-odoo doesn't have the auto-fix option

  
  

  e.g. for XML files: 

   - dangerous-filter-wo-user

   - duplicate-xml-record-id

   - deprecated-openerp-xml-node
   - create-user-wo-reset-password
   - duplicate-xml-fields
   - redundant-modulename-xml
   - deprecated-data-xml-node
  

  
  

  e.g. for CSV files:

   - duplicate-id-csv

  
  

  e.g. for PO files (Maybe, If we look for if exists hooks related to PO files they could be already developed from another hook project, so use it instead):

   - duplicate-po-message-definition

   - po-msgstr-variables
  

  
  

  So, IMHO in OCA we need to create a new project to push all these custom pre-commit hooks and add documentation of the useful projects replacing pylint-odoo checks.

  
  

  The name proposal is oca/odoo-pre-commit-hooks similar to main hooks repository:

   - https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks

  
  

  And we can (or not) enable the option to auto fix (we can even push checks without auto fix)

  
  

  Check the following discussion about creating custom repository to detect and autofix:

   - https://github.com/OCA/pylint-odoo/issues/375

  
  

  Check the following discussion about deprecating duplicated checks if pre-commit supports:

   - https://github.com/OCA/pylint-odoo/issues/267
  

  
  

  Check the following plan to create a freeze branch in pylint-odoo with the current behavior in pro to create a new version with new focus and clean code, delete old unused checks, deprecate py2 and so on:

   - https://github.com/OCA/pylint-odoo/issues/381

  
  

  If you agree, Could you help us to create the repository in OCA, please?

  
  

  --
  

  Moisés López Calderón

  Mobile: (+521) 477-752-22-30

  Twitter: @moylop260

  hangout: moylop260@vauxoo.com
  http://www.vauxoo.com - Odoo Gold Partner

  Twitter: @vauxoo

  ---

  by Moisés López Calderón - 10:11 - 27 Jun 2022

  8 replies 8 replies

  • Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

    Hi Moises,

    
    

    I just created the repo: https://github.com/OCA/odoo-pre-commit-hooks/

    
    

    Best regards,

    
    

    -sbi
    

    
    

    On Mon, Jun 27, 2022 at 10:12 PM Moises Lopez <moylop260@vauxoo.com> wrote:
    

    Currently, we are using pylint-odoo project as pre-commit hooks for other kind of files

    
    

    Now, we are using pre-commit for new projects.

    
    

    So we can remove all the checks unrelated with python from pylint-odoo

    e.g. eslint (javascript lints), XML checks, PO (translations) checks and so on

    
    

    Then they could be replaced in the pre-commit configuration file with the id of the related check

    
    

    e.g. eslint see https://github.com/pre-commit/mirrors-eslint

    
    

    There are other custom checks in pylint-odoo as unnecessary-utf8-coding-comment

    But it is duplicated with the following hook id fix-encoding-pragma from:

     - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/fix_encoding_pragma.py

    
    

    It even has the option to auto-fix it

    
    

    Similar case for pylint-odoo check incoherent-interpreter-exec-perm:
    

     - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_executables_have_shebangs.py

    
    

    Similar case for pylint-odoo check wrong-tabs-instead-of-spaces

     - https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/remove_tabs.py
    

    
    

    They are duplicated from pylint-odoo and they are better since they have the option to auto-fix if you want.

    
    

    But there are other kinds of custom checks in pylint-odoo unrelated with python files that could be good to create a new pre-commit-hook custom for Odoo modules

    
    

    In order to check XMLs, PO, CSS, CSV, and so on in the context of Odoo modules.

    
    

    Currently, pylint-odoo is overloaded trying to do checks for non-python code since the core is not supporting check non-python files

    And pylint-odoo doesn't have the auto-fix option

    
    

    e.g. for XML files: 

     - dangerous-filter-wo-user

     - duplicate-xml-record-id

     - deprecated-openerp-xml-node
     - create-user-wo-reset-password
     - duplicate-xml-fields
     - redundant-modulename-xml
     - deprecated-data-xml-node
    

    
    

    e.g. for CSV files:

     - duplicate-id-csv

    
    

    e.g. for PO files (Maybe, If we look for if exists hooks related to PO files they could be already developed from another hook project, so use it instead):

     - duplicate-po-message-definition

     - po-msgstr-variables
    

    
    

    So, IMHO in OCA we need to create a new project to push all these custom pre-commit hooks and add documentation of the useful projects replacing pylint-odoo checks.

    
    

    The name proposal is oca/odoo-pre-commit-hooks similar to main hooks repository:

     - https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks

    
    

    And we can (or not) enable the option to auto fix (we can even push checks without auto fix)

    
    

    Check the following discussion about creating custom repository to detect and autofix:

     - https://github.com/OCA/pylint-odoo/issues/375

    
    

    Check the following discussion about deprecating duplicated checks if pre-commit supports:

     - https://github.com/OCA/pylint-odoo/issues/267
    

    
    

    Check the following plan to create a freeze branch in pylint-odoo with the current behavior in pro to create a new version with new focus and clean code, delete old unused checks, deprecate py2 and so on:

     - https://github.com/OCA/pylint-odoo/issues/381

    
    

    If you agree, Could you help us to create the repository in OCA, please?

    
    

    --
    

    Moisés López Calderón

    Mobile: (+521) 477-752-22-30

    Twitter: @moylop260

    hangout: moylop260@vauxoo.com
    http://www.vauxoo.com - Odoo Gold Partner

    Twitter: @vauxoo

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Stéphane Bidoul - 11:15 - 29 Jun 2022

  • Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

    Hi Moises,

    
    

    Sounds great to make pylint-odoo simpler!

    
    

    I take the opportunity to mention the semgrep (https://semgrep.dev) project that I recently discovered and may be a simple solution to implement some checks.
    

    
    

    I'll create the new repo soon.

    
    

    > Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?

    
    

    Once the new checkers/fixers are ready in the new repo(s), they will need to be referenced in the .pre-commit-config.yaml template in the addons repo template.
    

    
    

    Best regards,

    
    

    -sbi
    

    
    

    On Tue, Jun 28, 2022 at 9:52 AM Daniel Reis <dreis@opensourceintegrators.com> wrote:
    

    Thank you for taking care of this Moises.

    
    

    Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?
    
    

    --dr 

    
    

    No dia 28/06/2022, às 07:46, Mignon, Laurent <laurent.mignon@acsone.eu> escreveu:
    
    

    

    Good Idea!

    
    

    Regards.

    
    

    On Tue, Jun 28, 2022 at 8:17 AM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
    

    Yes, I agree.

    
    

    Regards.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Stéphane Bidoul - 12:41 - 28 Jun 2022

  • Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

    I have done a big progress in this subject recently, and it's open sourced. Get it here: https://gitlab.com/moduon/devsecops/precommix

    
    

    It's based on Nix, so you will never get another random failure. It's a definitive solution for problems such as:

    • https://github.com/OCA/oca-addons-repo-template/issues/133
    • https://github.com/OCA/oca-addons-repo-template/pull/143

    Your pre-commit configurations will keep working forever.

    
    

    Just go ahead and wire precommix with oca-addons-repo-template.

    
    

    Apart from that, I agree on removing the non-python stuff from pylint-odoo.

    ---

    by Jairo Llopis - 11:16 - 28 Jun 2022

  • Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

    Great ! +1

    
    

    On Mon, Jun 27, 2022 at 10:12 PM Moises Lopez <moylop260@vauxoo.com> wrote:
    

    Currently, we are using pylint-odoo project as pre-commit hooks for other kind of files

    
    

    Now, we are using pre-commit for new projects.

    
    

    So we can remove all the checks unrelated with python from pylint-odoo

    e.g. eslint (javascript lints), XML checks, PO (translations) checks and so on

    
    

    Then they could be replaced in the pre-commit configuration file with the id of the related check

    
    

    e.g. eslint see https://github.com/pre-commit/mirrors-eslint

    
    

    There are other custom checks in pylint-odoo as unnecessary-utf8-coding-comment

    But it is duplicated with the following hook id fix-encoding-pragma from:

     - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/fix_encoding_pragma.py

    
    

    It even has the option to auto-fix it

    
    

    Similar case for pylint-odoo check incoherent-interpreter-exec-perm:
    

     - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_executables_have_shebangs.py

    
    

    Similar case for pylint-odoo check wrong-tabs-instead-of-spaces

     - https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/remove_tabs.py
    

    
    

    They are duplicated from pylint-odoo and they are better since they have the option to auto-fix if you want.

    
    

    But there are other kinds of custom checks in pylint-odoo unrelated with python files that could be good to create a new pre-commit-hook custom for Odoo modules

    
    

    In order to check XMLs, PO, CSS, CSV, and so on in the context of Odoo modules.

    
    

    Currently, pylint-odoo is overloaded trying to do checks for non-python code since the core is not supporting check non-python files

    And pylint-odoo doesn't have the auto-fix option

    
    

    e.g. for XML files: 

     - dangerous-filter-wo-user

     - duplicate-xml-record-id

     - deprecated-openerp-xml-node
     - create-user-wo-reset-password
     - duplicate-xml-fields
     - redundant-modulename-xml
     - deprecated-data-xml-node
    

    
    

    e.g. for CSV files:

     - duplicate-id-csv

    
    

    e.g. for PO files (Maybe, If we look for if exists hooks related to PO files they could be already developed from another hook project, so use it instead):

     - duplicate-po-message-definition

     - po-msgstr-variables
    

    
    

    So, IMHO in OCA we need to create a new project to push all these custom pre-commit hooks and add documentation of the useful projects replacing pylint-odoo checks.

    
    

    The name proposal is oca/odoo-pre-commit-hooks similar to main hooks repository:

     - https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks

    
    

    And we can (or not) enable the option to auto fix (we can even push checks without auto fix)

    
    

    Check the following discussion about creating custom repository to detect and autofix:

     - https://github.com/OCA/pylint-odoo/issues/375

    
    

    Check the following discussion about deprecating duplicated checks if pre-commit supports:

     - https://github.com/OCA/pylint-odoo/issues/267
    

    
    

    Check the following plan to create a freeze branch in pylint-odoo with the current behavior in pro to create a new version with new focus and clean code, delete old unused checks, deprecate py2 and so on:

     - https://github.com/OCA/pylint-odoo/issues/381

    
    

    If you agree, Could you help us to create the repository in OCA, please?

    
    

    --
    

    Moisés López Calderón

    Mobile: (+521) 477-752-22-30

    Twitter: @moylop260

    hangout: moylop260@vauxoo.com
    http://www.vauxoo.com - Odoo Gold Partner

    Twitter: @vauxoo

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    ---

    by Denis Roussel - 10:51 - 28 Jun 2022

  • Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

    Thank you for taking care of this Moises.

    
    

    Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?
    
    

    --dr 

    
    

    No dia 28/06/2022, às 07:46, Mignon, Laurent <laurent.mignon@acsone.eu> escreveu:
    
    

    

    Good Idea!

    
    

    Regards.

    
    

    On Tue, Jun 28, 2022 at 8:17 AM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
    

    Yes, I agree.

    
    

    Regards.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Daniel Reis - 09:51 - 28 Jun 2022

  3 more replies

• Re: l10n-estonia status and proposing myself as PSC

  What next steps do I need to take?
  

  ---

  by "Alexey Pelykh" <alexey.pelykh@corphub.eu> - 09:25 - 23 Jun 2022

• Translations done by a webservice

  Hi all,

  
  

  Do you know any Odoo open source module that is able to translate user generated content (product descriptions for example) in an integrated way?

  
  

  Thanks in advance.
  

  ---

  by Pedro M. Baeza - 11:11 - 22 Jun 2022

  2 replies 2 replies

  • Re: Translations done by a webservice

    On 22/06/2022 11:12, Pedro M. Baeza (Tecnativa) wrote:
    
    > Hi all,
    
    > 
    
    > Do you know any Odoo open source module that is able to translate user 
    
    > generated content (product descriptions for example) in an integrated way?
    
    > 
    
    Hi,
    
    I don't know a ready to use odoo addon for this but what about 
    argos-translate ?
    
    You can use it directly in your code as a python module,
    
    Use it offline, set up your own server, use a public server using api, ...
    
    Depending if you want use it offline from addon code(pure python, 
    privacy, silent machine translation), or from the frontend (js using api 
    (private or public), end user live double check)
    
    For example it seems very fast and easy to just add an automated action 
    to update translations with this tool.
    
    https://github.com/argosopentech/argos-translate
    
    You can try it online here :
    
    https://libretranslate.com
    
    https://github.com/LibreTranslate/LibreTranslate
    
    
    -- 
    Simon Maillard
    simon@ogesta.fr
    
    Parce que sinon ça rend la discussion incompréhensible.
     > Pourquoi ça ?
     >> Je préfère répondre en dessous.
     >>> Que faites-vous à la place ?
     >>>> Non.
     >>>>> Vous n'aimez pas répondre au-dessus ?
    

    ---

    by simon - 02:56 - 22 Jun 2022

  • Re: Translations done by a webservice

    Hi Pedro and community,

    
    

    We looked for different possibilities with already existing Odoo modules. Finally, our last tests were oriented towards services like https://weglot.com

    
    

    Have a nice day !
    

    Bruno Joliveau - Président NUMIGI SOLUTIONS INC. bruno.joliveau@numigi.com (514) 317-7944 Longueuil, Québec, Canada http://www.numigi.com/

    
    

    
    

    Le mer. 22 juin 2022 à 05:12, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> a écrit :
    

    Hi all,

    
    

    Do you know any Odoo open source module that is able to translate user generated content (product descriptions for example) in an integrated way?

    
    

    Thanks in advance.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Bruno Joliveau - 02:25 - 22 Jun 2022

• Split of contract/agreement

  Hi all,

  
  

  Before merging the first agreement module to v15, and after some discussions I've had about overloaded repositories, I want to create a new one for those related.

  
  

  The PR for agreement is here, where I've already suggested it: https://github.com/OCA/contract/pull/795

  
  

  Thanks for your feedback on this
  

  
  

  --
  

  
  Denis Roussel
  Software Engineer
  T    : +32 2 888 31 49
  M : +32 472 22 00 57

  
  

  
  

  Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
  

  Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

  Zone industrielle 22 | L-8287 Kehlen | Luxembourg
  

  ---

  by Denis Roussel - 08:41 - 20 Jun 2022

  5 replies 5 replies

  • Re: Split of contract/agreement

    Done https://github.com/OCA/agreement

    
    

    On Tue, Jun 21, 2022 at 6:42 AM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    +1

    
    

    On Mon, Jun 20, 2022 at 9:47 PM Bruno Joliveau <bruno.joliveau@numigi.com> wrote:
    

    +1
    

    Bruno Joliveau - Président NUMIGI SOLUTIONS INC. bruno.joliveau@numigi.com (514) 317-7944 Longueuil, Québec, Canada http://www.numigi.com/

    
    

    
    

    Le lun. 20 juin 2022 à 02:42, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Hi all,

    
    

    Before merging the first agreement module to v15, and after some discussions I've had about overloaded repositories, I want to create a new one for those related.

    
    

    The PR for agreement is here, where I've already suggested it: https://github.com/OCA/contract/pull/795

    
    

    Thanks for your feedback on this
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    ---

    by Simone Orsi - 11:15 - 21 Jun 2022

  • Re: Split of contract/agreement

    +1

    
    

    On Mon, Jun 20, 2022 at 9:47 PM Bruno Joliveau <bruno.joliveau@numigi.com> wrote:
    

    +1
    

    Bruno Joliveau - Président NUMIGI SOLUTIONS INC. bruno.joliveau@numigi.com (514) 317-7944 Longueuil, Québec, Canada http://www.numigi.com/

    
    

    
    

    Le lun. 20 juin 2022 à 02:42, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Hi all,

    
    

    Before merging the first agreement module to v15, and after some discussions I've had about overloaded repositories, I want to create a new one for those related.

    
    

    The PR for agreement is here, where I've already suggested it: https://github.com/OCA/contract/pull/795

    
    

    Thanks for your feedback on this
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Kitti Upariphutthiphong - 06:41 - 21 Jun 2022

  • Re: Split of contract/agreement

    +1
    

    Bruno Joliveau - Président NUMIGI SOLUTIONS INC. bruno.joliveau@numigi.com (514) 317-7944 Longueuil, Québec, Canada http://www.numigi.com/

    
    

    
    

    Le lun. 20 juin 2022 à 02:42, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Hi all,

    
    

    Before merging the first agreement module to v15, and after some discussions I've had about overloaded repositories, I want to create a new one for those related.

    
    

    The PR for agreement is here, where I've already suggested it: https://github.com/OCA/contract/pull/795

    
    

    Thanks for your feedback on this
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Bruno Joliveau - 04:46 - 20 Jun 2022

  • Re: Split of contract/agreement

    + 1

    
    

    Marcel Savegnago
    

    Escodoo

    
    

    
    

    Em seg., 20 de jun. de 2022 às 03:53, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> escreveu:
    

    OK for me.

    
    

    Regards.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Marcel Savegnago - 04:36 - 20 Jun 2022

  • Re: Split of contract/agreement

    OK for me.

    
    

    Regards.
    

    ---

    by Pedro M. Baeza - 08:51 - 20 Jun 2022

• Module loading priority and inheritance

  Hi,

  
  

  I just installed the auth_totp module to add MFA support to our odoo 12.0 instance and its behaviour is totally broken after a server restart when the auth_ldap module is also installed.

  
  

  Because _check_credentials logic is just made to accept at least one Valid authentication and not globally refuse any authentication, the current implementation of the auth_totp will always fail if a module validate _check_credentials after that the MfaLoginNeeded exception is raised.
  

  
  

  To me it's more a framework issue and the manifest should allow a new priority value to sort modules without inter-dependencies (because actually, it seems to use an alphabetic sorting based on module name).
  

  But without this, how do you handle such situations ?

  
  

  --
  Yann PAPOUIN, Ingénieur R&D | DEC

  
  

  ---

  by Yann Papouin - 03:31 - 15 Jun 2022

  5 replies 5 replies

  • Re: Module loading priority and inheritance

    Richard, I understand your concern about the priority number, but having it in our toolbox could still be extremely useful.

    
    

    As a first step, I made a PR that implements both:
    

    https://github.com/odoo/odoo/pull/93928

    
    

    Contrary to my original proposal, I don't alter the SQL query, the sorting is done in python like the dependency loading by using the manifest attributes (not stored in the DB)
    

    
    

    
    

    ---

    by Yann Papouin - 03:21 - 17 Jun 2022

  • Re: Module loading priority and inheritance

    Yann,

    
    

    Yes, we too have occasionally encountered such issues.  Bridging modules are sometimes required to ensure correct execution, but then, that is still for modules all within our control.

    
    

    We often find the issue worst when using a third-party app, where there is a complete method overwrite (and maybe justifiably so).

    
    

    https://www.odoo.com/it_IT/forum/assistenza-1/modules-order-of-dependencies-159563
    

    
    

    Under your proposal, though, one would need to know about the modules causing the issue - which generally, I guess, is feasable.

    
    

    I do wonder, though, if implementing a "soft_depends" as opposed to a loading priority, is better.

    
    

    If randomly, in a manifest, there is a loading priority, then you sort of need to know and set all the other loading priorities, even in the third party modules, which may have their own issues.

    
    

    A soft depends, at least, it is clear that "this module has a conflict with that module which is now resolved by this dependency", as a priority number just gets lost (like sequences on views when you have many modules extending views)

    
    

    I would love to see something in this area...

    
    

    Richard

    
    

    
    

     

     

    Kind Regards          Richard deMeester  Senior Development Analyst  www.willdooit.com  richard.demeester@willdooit.com          T: (03) 9135 1900 | M: 0403 76 76 76 | A: Bld 10/435 Williamstown Road, Port Melbourne, 3207

    MAKING GROWTH THROUGH TECHNOLOGY EASY    Notice: This email and any files transmitted with it are confidential and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, you may not disclose or use the information in this email in any way. If you have received this email in error please notify the sender. Although reasonable precautions have been taken to ensure no viruses are present in this email, no responsibility is accepted by WilldooIT Pty Ltd or its related entities for any loss or damage arising from the use of this email or attachments. Any views expressed in this email or file attachments are those of the individual sender only, unless expressly stated to be those of WilldooIT Pty Ltd  ABN 85 006 073 052 or any of its related entities.

     

    
    

    ---

    From: Yann Papouin <ypa@decgroupe.com>
    Sent: Friday, 17 June 2022 7:02 PM
    To: Contributors <contributors@odoo-community.org>
    Subject: Re: Module loading priority and inheritance

     

    After investigation, the sequence field is only used for the kanban view to display applications in a specific order.

    
    

    Module list is fetched from database in odoo/odoo/modules/loading.py::load_marked_modules with this query

    
    

    cr.execute("SELECT name from ir_module_module WHERE state IN %s" ,(tuple(states),))

    
    

    So, the module loading order actually depends on 4 params:

    1. PostgreSQL database collation
    2. Module name
    3. Datetime of the creation of the ir_module_module row (since no ORDER BY is defined in the query)
    4. The dependencies

    That's a terrible loading implementation as the parameter 3 is based on an internal postgreSQL data, it also depends on the list order of your addons_path and also depends on when odoo/addons/base/models/ir_module.py::update_list is called.

    
    

    Example for this last assertion:

    • On the development database:
      
    • You add the module account_extra, that depends on account and override method update_something, in your main addons path
    • update_list()
      
    • Two weeks later, you add the module account_best , that also depends on account and also override the method update_something, in your main addons path
    • update_list()
      
    • Module account_extra will be loaded before account_best

    • Three weeks later, on the production database:
    • You add modules account_extra and account_best in your main addons path
    • update_list()
    • Module account_best will be loaded before account_extra

    And there I'm not talking about other cases like:

    • Multiple addons_path
    • Manual module deletion from odoo module list followed by a module list update
    • Manual module installation from UI whereas the server is already started with loaded modules

    
    

    So, I agree that most cases would be solved by the depends attribute but a fix could still be:

    • Add a loading_priority manifest key:
    • default value is 0 if not set, could be positive (load before) or negative (load after)
    • add an ORDER BY loading_priority, name in all SQL query of the loading.py
      
    • Add a soft_depends manifest key:
    • a list of modules that we depends on, only if they exists and are installed

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by "Richard deMeester" <richard.demeester@willdooit.com> - 02:46 - 17 Jun 2022

    5 attachments 5 attachments

    Outlook-5xqrm2jz.png

    Outlook-A picture .png

    Outlook-xsjdn3kg.png

    Outlook-xwsfd0mz.png

    Outlook-A close up.png

  • Re: Module loading priority and inheritance

    Thanks for the investigation. Your proposals seems good, but not sure if Odoo will add such mechanisms in the framework. You can try.

    
    

    Regards.
    

    ---

    by Pedro M. Baeza - 12:26 - 17 Jun 2022

  • Re: Module loading priority and inheritance

    After investigation, the sequence field is only used for the kanban view to display applications in a specific order.

    
    

    Module list is fetched from database in odoo/odoo/modules/loading.py::load_marked_modules with this query

    
    

    cr.execute("SELECT name from ir_module_module WHERE state IN %s" ,(tuple(states),))

    
    

    So, the module loading order actually depends on 4 params:

    1. PostgreSQL database collation
    2. Module name
    3. Datetime of the creation of the ir_module_module row (since no ORDER BY is defined in the query)
    4. The dependencies

    That's a terrible loading implementation as the parameter 3 is based on an internal postgreSQL data, it also depends on the list order of your addons_path and also depends on when odoo/addons/base/models/ir_module.py::update_list is called.

    
    

    Example for this last assertion:

    • On the development database:
      
    • You add the module account_extra, that depends on account and override method update_something, in your main addons path
    • update_list()
      
    • Two weeks later, you add the module account_best , that also depends on account and also override the method update_something, in your main addons path
    • update_list()
      
    • Module account_extra will be loaded before account_best

    • Three weeks later, on the production database:
    • You add modules account_extra and account_best in your main addons path
    • update_list()
    • Module account_best will be loaded before account_extra

    And there I'm not talking about other cases like:

    • Multiple addons_path
    • Manual module deletion from odoo module list followed by a module list update
    • Manual module installation from UI whereas the server is already started with loaded modules

    
    

    So, I agree that most cases would be solved by the depends attribute but a fix could still be:

    • Add a loading_priority manifest key:
    • default value is 0 if not set, could be positive (load before) or negative (load after)
    • add an ORDER BY loading_priority, name in all SQL query of the loading.py
      
    • Add a soft_depends manifest key:
    • a list of modules that we depends on, only if they exists and are installed

    
    

    ---

    by Yann Papouin - 11:00 - 17 Jun 2022

  • Re: Module loading priority and inheritance

    AFAIK, there's a `sequence` manifest key for such loading order.

    
    

    Regards.
    

    ---

    by Pedro M. Baeza - 05:26 - 15 Jun 2022

• Generic rest_api modules

  Hi all
  
  With Acsone, Camptocamp and Forgeflow, we are working on several generic rest_api modules on top of odoo/oca modules that can be used in whatever application you need (e-commerce, event, portal, ....)
  
  We were thinking first to put this modules in every related oca repo, but it's will make hard for us to maintain it (module will be everywhere)
  
  So we would like to have a centralized repository to put all this "api" modules so it will be easier
  - to have a quick overview for developper of the list of existing generic endpoint
  

  - to maintain, by having the api maintainer working on only one repo

  
  

  So are you ok with having a "rest-api" repo ?

  
  

  In the long term if this repo starts to be too big, we may split it by domain (sale-rest-api, manufacturing-rest-api...)

  
  

  Thanks
  

  ---

  by Sébastien Beau - 12:41 - 15 Jun 2022

  13 replies 13 replies

  • Re: Generic rest_api modules

    Thanks all for sharing, all are clear and useful. 

    
    

    🙏

    
    

    On Thu, Jul 7, 2022, 16:22 Naran M <notifications@odoo-community.org> wrote:
    

    Hi Kitti,

    
    

    I found the "openapi" module works quite well for a generic use case. https://apps.odoo.com/apps/modules/14.0/openapi/

    
    

    -Naran

    
    

    On Thu, Jul 7, 2022 at 5:16 PM Kitti Upariphutthiphong <notifications@odoo-community.org> wrote:
    

    Dear community,
    

    
    

    I did use the OCA base_rest, it all works fine. Except we need to create new modules for new models needed, and the collective maintenance can be high.
    

    
    

    I have found this module pretty generic to use https://github.com/yezyilomo/odoo-rest-api. (I found this the only non-paid module so far).

    
    

    Just curious why OCA don't do something more generic like the above link (which does not seem to be difficult to do either). What is the pros and cons?
    

    
    

    
    

    On Thu, Jun 16, 2022 at 9:57 PM Raphaël Valyi <rvalyi@akretion.com> wrote:
    

    Hello contributors,

    
    

    I have no opinion about Sebastien's proposal. But I take advantage of the thread to mention at Akretion we created this Stock 3 PL REST API module (3rd party logistics)

    https://github.com/akretion/stock-logistics-workflow/tree/12.0-add-stock-3pl-api/stock_3pl_api

    It can fit for 3rd party logistics when you need something simpler than Shopfloor.

    
    

    The project got stalled with the pandemic and I'm still a bit over-busy to take care of pushing it to the OCA, but at least you know it exists now. I was planning to submit it to stock-logistics-workflow but eventually I'll push it to this new repo if you think it fits better.

    
    

    Help for this stock_3pl_api (review and tests) would be very welcome...

    
    

    On Thu, Jun 16, 2022 at 7:52 AM Benoît Guillot <benoit.guillot@akretion.com> wrote:
    

    +1
    

    
    

    Le jeu. 16 juin 2022 à 08:22, Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> a écrit :
    

    I'm good with the proposal Sébastien 

    
    

    Le mer. 15 juin 2022 à 14:07, Simone Orsi <simahawk@gmail.com> a écrit :
    

    +1
    

    
    

    On Wed, Jun 15, 2022 at 1:27 PM Mignon, Laurent <laurent.mignon@acsone.eu> wrote:
    

    I would prefer to keep the 'base' modules into their own repository. The maintainers are not the same and it's easier to maintain and manage addons within a small repo than a larger one.

    
    

    +1 for the new rest-api repo.
    

    
    

    On Wed, Jun 15, 2022 at 12:46 PM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
    

    Why not renaming current OCA/rest-framework to that more generic one and host there both framework and the modules that use it? Remember that the maintenance burden increases on each new repository added to OCA.

    
    

    Regards.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    
    --
    

    Benoît Guillot
    Mail: benoit.guillot@akretion.com
    

    Mobile : +33 6 66 50 39 90

    Jabber/Gtalk : benoit.guillot@akretion.com.br

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Raphaël Valyi

    Founder and consultant

    http://twitter.com/rvalyi

    www.akretion.com

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Kitti Upariphutthiphong - 01:46 - 9 Jul 2022

  • Re: Generic rest_api modules

    Hi Kitti,

    
    

    I found the "openapi" module works quite well for a generic use case. https://apps.odoo.com/apps/modules/14.0/openapi/

    
    

    -Naran

    
    

    On Thu, Jul 7, 2022 at 5:16 PM Kitti Upariphutthiphong <notifications@odoo-community.org> wrote:
    

    Dear community,
    

    
    

    I did use the OCA base_rest, it all works fine. Except we need to create new modules for new models needed, and the collective maintenance can be high.
    

    
    

    I have found this module pretty generic to use https://github.com/yezyilomo/odoo-rest-api. (I found this the only non-paid module so far).

    
    

    Just curious why OCA don't do something more generic like the above link (which does not seem to be difficult to do either). What is the pros and cons?
    

    
    

    
    

    On Thu, Jun 16, 2022 at 9:57 PM Raphaël Valyi <rvalyi@akretion.com> wrote:
    

    Hello contributors,

    
    

    I have no opinion about Sebastien's proposal. But I take advantage of the thread to mention at Akretion we created this Stock 3 PL REST API module (3rd party logistics)

    https://github.com/akretion/stock-logistics-workflow/tree/12.0-add-stock-3pl-api/stock_3pl_api

    It can fit for 3rd party logistics when you need something simpler than Shopfloor.

    
    

    The project got stalled with the pandemic and I'm still a bit over-busy to take care of pushing it to the OCA, but at least you know it exists now. I was planning to submit it to stock-logistics-workflow but eventually I'll push it to this new repo if you think it fits better.

    
    

    Help for this stock_3pl_api (review and tests) would be very welcome...

    
    

    On Thu, Jun 16, 2022 at 7:52 AM Benoît Guillot <benoit.guillot@akretion.com> wrote:
    

    +1
    

    
    

    Le jeu. 16 juin 2022 à 08:22, Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> a écrit :
    

    I'm good with the proposal Sébastien 

    
    

    Le mer. 15 juin 2022 à 14:07, Simone Orsi <simahawk@gmail.com> a écrit :
    

    +1
    

    
    

    On Wed, Jun 15, 2022 at 1:27 PM Mignon, Laurent <laurent.mignon@acsone.eu> wrote:
    

    I would prefer to keep the 'base' modules into their own repository. The maintainers are not the same and it's easier to maintain and manage addons within a small repo than a larger one.

    
    

    +1 for the new rest-api repo.
    

    
    

    On Wed, Jun 15, 2022 at 12:46 PM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
    

    Why not renaming current OCA/rest-framework to that more generic one and host there both framework and the modules that use it? Remember that the maintenance burden increases on each new repository added to OCA.

    
    

    Regards.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    
    --
    

    Benoît Guillot
    Mail: benoit.guillot@akretion.com
    

    Mobile : +33 6 66 50 39 90

    Jabber/Gtalk : benoit.guillot@akretion.com.br

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Raphaël Valyi

    Founder and consultant

    http://twitter.com/rvalyi

    www.akretion.com

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Naran Moturi - 11:21 - 7 Jul 2022

  • Re: Generic rest_api modules

    I've also seen a third implementation, by MuK, which allows you to basically build your REST API on the fly through the UI. So it's generic, but also customizable by consultants.
    

    It would be really nice to have this in OCA as well, but it would be some work.

    Same goes for the "connector" framework by the way - it would be great if a consultant can just build his importer, exporter, mapper, instead of requiring the programmer.

    On 7/7/22 09:57, Joël Grand-Guillaume wrote:
    

    Hi Kitty,

    
    

    
    

    Very good remark ! The generic one you propose is a great one. I like approaches such as this one.

    
    

    Now I think this serves a different purpose I guess. A generic one allows you to access basically everything you can according to your access right and always in the same way. The other approach allows you to define what is accessible or not over REST. It also allows you to write what method with which syntax you want to have. This is clearly needed in advance interface with transactional behavior (not only data fetching).

    
    

    In the end, we'd like to have both probably ;)

    
    

    
    

    
    

    
    

    On Thu, Jul 7, 2022 at 9:16 AM Kitti Upariphutthiphong <notifications@odoo-community.org> wrote:
    

    Dear community,
    

    
    

    I did use the OCA base_rest, it all works fine. Except we need to create new modules for new models needed, and the collective maintenance can be high.
    

    
    

    I have found this module pretty generic to use https://github.com/yezyilomo/odoo-rest-api. (I found this the only non-paid module so far).

    
    

    Just curious why OCA don't do something more generic like the above link (which does not seem to be difficult to do either). What is the pros and cons?
    

    
    

    
    

    On Thu, Jun 16, 2022 at 9:57 PM Raphaël Valyi <rvalyi@akretion.com> wrote:
    

    Hello contributors,

    
    

    I have no opinion about Sebastien's proposal. But I take advantage of the thread to mention at Akretion we created this Stock 3 PL REST API module (3rd party logistics)

    https://github.com/akretion/stock-logistics-workflow/tree/12.0-add-stock-3pl-api/stock_3pl_api

    It can fit for 3rd party logistics when you need something simpler than Shopfloor.

    
    

    The project got stalled with the pandemic and I'm still a bit over-busy to take care of pushing it to the OCA, but at least you know it exists now. I was planning to submit it to stock-logistics-workflow but eventually I'll push it to this new repo if you think it fits better.

    
    

    Help for this stock_3pl_api (review and tests) would be very welcome...

    
    

    On Thu, Jun 16, 2022 at 7:52 AM Benoît Guillot <benoit.guillot@akretion.com> wrote:
    

    +1
    

    
    

    Le jeu. 16 juin 2022 à 08:22, Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> a écrit :
    

    I'm good with the proposal Sébastien 

    
    

    Le mer. 15 juin 2022 à 14:07, Simone Orsi <simahawk@gmail.com> a écrit :
    

    +1
    

    
    

    On Wed, Jun 15, 2022 at 1:27 PM Mignon, Laurent <laurent.mignon@acsone.eu> wrote:
    

    I would prefer to keep the 'base' modules into their own repository. The maintainers are not the same and it's easier to maintain and manage addons within a small repo than a larger one.

    
    

    +1 for the new rest-api repo.
    

    
    

    On Wed, Jun 15, 2022 at 12:46 PM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
    

    Why not renaming current OCA/rest-framework to that more generic one and host there both framework and the modules that use it? Remember that the maintenance burden increases on each new repository added to OCA.

    
    

    Regards.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    
    --
    

    Benoît Guillot
    Mail: benoit.guillot@akretion.com
    

    Mobile : +33 6 66 50 39 90

    Jabber/Gtalk : benoit.guillot@akretion.com.br

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Raphaël Valyi

    Founder and consultant

    http://twitter.com/rvalyi

    www.akretion.com

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Joël Grand-Guillaume

    Department Head
    

    Business Solutions

    
    

    

    New address from 1st September 2022

    
    

    Camptocamp SA

    Route de la Chaux 4

    1030 Bussigny

    Suisse

    
    

    Discover more about our new base camp office!

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Tom Blauwendraat - 10:56 - 7 Jul 2022

  • Re: Generic rest_api modules

    Hi Kitty,

    
    

    
    

    Very good remark ! The generic one you propose is a great one. I like approaches such as this one.

    
    

    Now I think this serves a different purpose I guess. A generic one allows you to access basically everything you can according to your access right and always in the same way. The other approach allows you to define what is accessible or not over REST. It also allows you to write what method with which syntax you want to have. This is clearly needed in advance interface with transactional behavior (not only data fetching).

    
    

    In the end, we'd like to have both probably ;)

    
    

    
    

    
    

    
    

    On Thu, Jul 7, 2022 at 9:16 AM Kitti Upariphutthiphong <notifications@odoo-community.org> wrote:
    

    Dear community,
    

    
    

    I did use the OCA base_rest, it all works fine. Except we need to create new modules for new models needed, and the collective maintenance can be high.
    

    
    

    I have found this module pretty generic to use https://github.com/yezyilomo/odoo-rest-api. (I found this the only non-paid module so far).

    
    

    Just curious why OCA don't do something more generic like the above link (which does not seem to be difficult to do either). What is the pros and cons?
    

    
    

    
    

    On Thu, Jun 16, 2022 at 9:57 PM Raphaël Valyi <rvalyi@akretion.com> wrote:
    

    Hello contributors,

    
    

    I have no opinion about Sebastien's proposal. But I take advantage of the thread to mention at Akretion we created this Stock 3 PL REST API module (3rd party logistics)

    https://github.com/akretion/stock-logistics-workflow/tree/12.0-add-stock-3pl-api/stock_3pl_api

    It can fit for 3rd party logistics when you need something simpler than Shopfloor.

    
    

    The project got stalled with the pandemic and I'm still a bit over-busy to take care of pushing it to the OCA, but at least you know it exists now. I was planning to submit it to stock-logistics-workflow but eventually I'll push it to this new repo if you think it fits better.

    
    

    Help for this stock_3pl_api (review and tests) would be very welcome...

    
    

    On Thu, Jun 16, 2022 at 7:52 AM Benoît Guillot <benoit.guillot@akretion.com> wrote:
    

    +1
    

    
    

    Le jeu. 16 juin 2022 à 08:22, Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> a écrit :
    

    I'm good with the proposal Sébastien 

    
    

    Le mer. 15 juin 2022 à 14:07, Simone Orsi <simahawk@gmail.com> a écrit :
    

    +1
    

    
    

    On Wed, Jun 15, 2022 at 1:27 PM Mignon, Laurent <laurent.mignon@acsone.eu> wrote:
    

    I would prefer to keep the 'base' modules into their own repository. The maintainers are not the same and it's easier to maintain and manage addons within a small repo than a larger one.

    
    

    +1 for the new rest-api repo.
    

    
    

    On Wed, Jun 15, 2022 at 12:46 PM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
    

    Why not renaming current OCA/rest-framework to that more generic one and host there both framework and the modules that use it? Remember that the maintenance burden increases on each new repository added to OCA.

    
    

    Regards.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    
    --
    

    Benoît Guillot
    Mail: benoit.guillot@akretion.com
    

    Mobile : +33 6 66 50 39 90

    Jabber/Gtalk : benoit.guillot@akretion.com.br

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Raphaël Valyi

    Founder and consultant

    http://twitter.com/rvalyi

    www.akretion.com

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Joël Grand-Guillaume

    Department Head
    

    Business Solutions

    
    

    

    New address from 1st September 2022

    
    

    Camptocamp SA

    Route de la Chaux 4

    1030 Bussigny

    Suisse

    
    

    Discover more about our new base camp office!

    
    

    ---

    by Joël Grand Guillaume - 09:56 - 7 Jul 2022

  • Re: Generic rest_api modules

    Dear community,
    

    
    

    I did use the OCA base_rest, it all works fine. Except we need to create new modules for new models needed, and the collective maintenance can be high.
    

    
    

    I have found this module pretty generic to use https://github.com/yezyilomo/odoo-rest-api. (I found this the only non-paid module so far).

    
    

    Just curious why OCA don't do something more generic like the above link (which does not seem to be difficult to do either). What is the pros and cons?
    

    
    

    
    

    On Thu, Jun 16, 2022 at 9:57 PM Raphaël Valyi <rvalyi@akretion.com> wrote:
    

    Hello contributors,

    
    

    I have no opinion about Sebastien's proposal. But I take advantage of the thread to mention at Akretion we created this Stock 3 PL REST API module (3rd party logistics)

    https://github.com/akretion/stock-logistics-workflow/tree/12.0-add-stock-3pl-api/stock_3pl_api

    It can fit for 3rd party logistics when you need something simpler than Shopfloor.

    
    

    The project got stalled with the pandemic and I'm still a bit over-busy to take care of pushing it to the OCA, but at least you know it exists now. I was planning to submit it to stock-logistics-workflow but eventually I'll push it to this new repo if you think it fits better.

    
    

    Help for this stock_3pl_api (review and tests) would be very welcome...

    
    

    On Thu, Jun 16, 2022 at 7:52 AM Benoît Guillot <benoit.guillot@akretion.com> wrote:
    

    +1
    

    
    

    Le jeu. 16 juin 2022 à 08:22, Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> a écrit :
    

    I'm good with the proposal Sébastien 

    
    

    Le mer. 15 juin 2022 à 14:07, Simone Orsi <simahawk@gmail.com> a écrit :
    

    +1
    

    
    

    On Wed, Jun 15, 2022 at 1:27 PM Mignon, Laurent <laurent.mignon@acsone.eu> wrote:
    

    I would prefer to keep the 'base' modules into their own repository. The maintainers are not the same and it's easier to maintain and manage addons within a small repo than a larger one.

    
    

    +1 for the new rest-api repo.
    

    
    

    On Wed, Jun 15, 2022 at 12:46 PM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
    

    Why not renaming current OCA/rest-framework to that more generic one and host there both framework and the modules that use it? Remember that the maintenance burden increases on each new repository added to OCA.

    
    

    Regards.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    
    --
    

    Benoît Guillot
    Mail: benoit.guillot@akretion.com
    

    Mobile : +33 6 66 50 39 90

    Jabber/Gtalk : benoit.guillot@akretion.com.br

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Raphaël Valyi

    Founder and consultant

    http://twitter.com/rvalyi

    www.akretion.com

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Kitti Upariphutthiphong - 09:16 - 7 Jul 2022

  8 more replies

• New repos proposal

  Hi all,

  
  

  I'd like to propose 2 new repos:

  
  

  1. web-api : collect modules to expose or deal with web api (eg: custom management for routes and endpoints, generic tools to handle calls to ext api, etc).

  
  

  2. pwa-builder : collect modules that allow to create and manage standalone PWA apps. As many of you know I split the core of the shopfloor wms app some time ago and this core now allows you to create - potentially - any kind of PWA app w/ its backend (based on rest services) and frontend tools (VueJS based). This core is now in OCA/wms but that's not really the right place. The name is not adequate too (shopfloor_base) so I think I'm going to rename it to pwa_core or pwa_builder or something similar.

  
  

  I'd say each of them should have its own PSC but maybe having one is fine too.

  
  

  Looking fwd to your feedback.

  
  

  Bests,

  
  

  --
  

  Simone Orsi

  
  

  Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

  ---

  by Simone Orsi - 09:21 - 14 Jun 2022

  14 replies 14 replies

  • Re: New repos proposal

    Hi Simone,
    
    Alright, you've convinced me and it seems others as well! Let's just go 
    with "web-api" and "pwa-builder" then and do our best on the README's to 
    make clear how they differ from "connector" and "rest-framework". It's 
    good enough and frankly I am super interested in the code so I hope 
    you'll be able to push it soon!
    
    -Tom
    
    
    

    ---

    by Tom Blauwendraat - 05:50 - 21 Jun 2022

  • Re: New repos proposal

    +1

    
    

    
    

    
    

    Le mar. 21 juin 2022 à 11:37, Simone Orsi <simahawk@gmail.com> a écrit :
    

    Hi,

    
    

    On Thu, Jun 16, 2022 at 11:37 AM Tom Blauwendraat <tom@sunflowerweb.nl> wrote:
    

    To make these scope statements more concrete:
    

    1. web-api : collect modules to expose or deal with web api (eg: custom management for routes and endpoints, generic tools to handle calls to ext api, etc).

    This description as a scope statement IMO should be better, it should be crystal clear why this is not part of "OCA/rest-framework". As it stands now, this text does not teach or convince me why it should be separate. Could we come up with a better text?
    

    
    

    It's not about REST, it's about any kind of WEB related API that you might want to expose or call.

    Examples:

    * inbound - an endpoint to accept a file upload or to create a record

    * outbound - configuration of an external web service to call + reusable tools or api to make this happen

    
    

    In any case, the text I wrote in my first email was not intended to be the readme of the repo, was just to have an idea ;)

    2. pwa-builder : collect modules that allow to create and manage standalone PWA apps. As many of you know I split the core of the shopfloor wms app some time ago and this core now allows you to create - potentially - any kind of PWA app w/ its backend (based on rest services) and frontend tools (VueJS based). This core is now in OCA/wms but that's not really the right place. The name is not adequate too (shopfloor_base) so I think I'm going to rename it to pwa_core or pwa_builder or something similar.

    For this the reason to separate is much more clear. OCA/wms is definitely the wrong place, as you want to be able to use this framework for "any app".
    

    Three questions though:

    1. Why "builder" ? Does this actually build apps for you, or is it just a framework. A builder sounds to me as a tool that allows you to generate an app from building blocks. If a framework, "pwa", "pwa-core", "pwa-engine" or "pwa-framework" sounds more appropriate to me.
    

    
    

    To be honest I don't care that much about this name, I'm open for suggestions ;) "builder" sounded in line with "mis-builder" and generic enough to not require another repo for additional modules. I mean, if we call it pwa-core (which I like more) then I won't put any other module there which is not for the "core" and then we'll need a new one like pwa-contribs (or any similar name). I don't dislike this option. 

    Hence, if everybody prefers `-framework` or another option, I can change its name. No problem.

     

    2. Is this limited to be used as a PWA, or can it also just be used as a replacement for the Odoo web portal? In my view, a "PWA" is something that has a service worker and can be "installed" to your system. Otherwise something like "web-app-engine" would be more appropriate (analogous to reporting-engine: housing an alternative OCA reporting engine)
    

    Potentially you can build any kind of PWA on top of it. Up to you. The backend is separated from the front, see below. 

    Keeping PWA in the name sounds a bit more in line with what you'll end up with: an installable app. If you use it also as a website is up to you but you don't need it for creating a website only.

    
    

    3. Considering that it's based on VueJS, wouldn't a better name be "web-app-vuejs" or "pwa-vuejs", in order to separate it from efforts by any future OCA member companies who prefer Angular or React as their tool of choice, and want to open source their alternative engine?

    No, it's not for VueJS only. There's a backend part and a frontend part. Today the front is based on VueJS but if you want to rewrite the front w/ ReactJS, you could.

    The backend part - as far as possible - is conceived to provide configuration, routes and specific endpoints to retrieve core info for the app.

    
    

    Hope is more clear now :)

    
    

    Bests

    
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    
    --
    

    Raphaël Reverdy
    

    Mobile +33 6 38 02 03 93
    

    Fixe +33 4 82 53 84 60

    ---

    by Raphaël Reverdy - 04:41 - 21 Jun 2022

  • Re: New repos proposal

    Hi,

    
    

    On Thu, Jun 16, 2022 at 11:37 AM Tom Blauwendraat <tom@sunflowerweb.nl> wrote:
    

    To make these scope statements more concrete:
    

    1. web-api : collect modules to expose or deal with web api (eg: custom management for routes and endpoints, generic tools to handle calls to ext api, etc).

    This description as a scope statement IMO should be better, it should be crystal clear why this is not part of "OCA/rest-framework". As it stands now, this text does not teach or convince me why it should be separate. Could we come up with a better text?
    

    
    

    It's not about REST, it's about any kind of WEB related API that you might want to expose or call.

    Examples:

    * inbound - an endpoint to accept a file upload or to create a record

    * outbound - configuration of an external web service to call + reusable tools or api to make this happen

    
    

    In any case, the text I wrote in my first email was not intended to be the readme of the repo, was just to have an idea ;)

    2. pwa-builder : collect modules that allow to create and manage standalone PWA apps. As many of you know I split the core of the shopfloor wms app some time ago and this core now allows you to create - potentially - any kind of PWA app w/ its backend (based on rest services) and frontend tools (VueJS based). This core is now in OCA/wms but that's not really the right place. The name is not adequate too (shopfloor_base) so I think I'm going to rename it to pwa_core or pwa_builder or something similar.

    For this the reason to separate is much more clear. OCA/wms is definitely the wrong place, as you want to be able to use this framework for "any app".
    

    Three questions though:

    1. Why "builder" ? Does this actually build apps for you, or is it just a framework. A builder sounds to me as a tool that allows you to generate an app from building blocks. If a framework, "pwa", "pwa-core", "pwa-engine" or "pwa-framework" sounds more appropriate to me.
    

    
    

    To be honest I don't care that much about this name, I'm open for suggestions ;) "builder" sounded in line with "mis-builder" and generic enough to not require another repo for additional modules. I mean, if we call it pwa-core (which I like more) then I won't put any other module there which is not for the "core" and then we'll need a new one like pwa-contribs (or any similar name). I don't dislike this option. 

    Hence, if everybody prefers `-framework` or another option, I can change its name. No problem.

     

    2. Is this limited to be used as a PWA, or can it also just be used as a replacement for the Odoo web portal? In my view, a "PWA" is something that has a service worker and can be "installed" to your system. Otherwise something like "web-app-engine" would be more appropriate (analogous to reporting-engine: housing an alternative OCA reporting engine)
    

    Potentially you can build any kind of PWA on top of it. Up to you. The backend is separated from the front, see below. 

    Keeping PWA in the name sounds a bit more in line with what you'll end up with: an installable app. If you use it also as a website is up to you but you don't need it for creating a website only.

    
    

    3. Considering that it's based on VueJS, wouldn't a better name be "web-app-vuejs" or "pwa-vuejs", in order to separate it from efforts by any future OCA member companies who prefer Angular or React as their tool of choice, and want to open source their alternative engine?

    No, it's not for VueJS only. There's a backend part and a frontend part. Today the front is based on VueJS but if you want to rewrite the front w/ ReactJS, you could.

    The backend part - as far as possible - is conceived to provide configuration, routes and specific endpoints to retrieve core info for the app.

    
    

    Hope is more clear now :)

    
    

    Bests

    
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    ---

    by Simone Orsi - 11:36 - 21 Jun 2022

  • Re: New repos proposal

    
    

    
    

    On 6/16/22 10:22, Daniel Reis wrote:
    

    Adding multiple repos makes it harder for contributors to know where to submit a new module.

    
    

    Can we make sure there are clear scope statements in the READMEs, and that these also link to the closely related ropes, helping contributors know about them.

    Agree with this totally.
    

    To make these scope statements more concrete:
    

    1. web-api : collect modules to expose or deal with web api (eg: custom management for routes and endpoints, generic tools to handle calls to ext api, etc).

    This description as a scope statement IMO should be better, it should be crystal clear why this is not part of "OCA/rest-framework". As it stands now, this text does not teach or convince me why it should be separate. Could we come up with a better text?
    

    
    

    2. pwa-builder : collect modules that allow to create and manage standalone PWA apps. As many of you know I split the core of the shopfloor wms app some time ago and this core now allows you to create - potentially - any kind of PWA app w/ its backend (based on rest services) and frontend tools (VueJS based). This core is now in OCA/wms but that's not really the right place. The name is not adequate too (shopfloor_base) so I think I'm going to rename it to pwa_core or pwa_builder or something similar.

    For this the reason to separate is much more clear. OCA/wms is definitely the wrong place, as you want to be able to use this framework for "any app".
    

    Three questions though:

    1. Why "builder" ? Does this actually build apps for you, or is it just a framework. A builder sounds to me as a tool that allows you to generate an app from building blocks. If a framework, "pwa", "pwa-core", "pwa-engine" or "pwa-framework" sounds more appropriate to me.
    

    2. Is this limited to be used as a PWA, or can it also just be used as a replacement for the Odoo web portal? In my view, a "PWA" is something that has a service worker and can be "installed" to your system. Otherwise something like "web-app-engine" would be more appropriate (analogous to reporting-engine: housing an alternative OCA reporting engine)
    

    3. Considering that it's based on VueJS, wouldn't a better name be "web-app-vuejs" or "pwa-vuejs", in order to separate it from efforts by any future OCA member companies who prefer Angular or React as their tool of choice, and want to open source their alternative engine?

    
    

    
    

    ---

    by Tom Blauwendraat - 11:35 - 16 Jun 2022

  • Re: New repos proposal

    I have a concern here:

    
    

    Adding multiple repos makes it harder for contributors to know where to submit a new module.

    
    

    Can we make sure there are clear scope statements in the READMEs, and that these also link to the closely related ropes, helping contributors know about them.

    
    

    Does this make sense?
    
    

    --dr 

    
    

    No dia 14/06/2022, às 10:52, Antonio M. Vigliotti (gmail) <antoniomaria.vigliotti@gmail.com> escreveu:
    
    

    

    1.  web-api: may be useful if full documentation will be available; most of api and/or rest could not be used without documentation
    
    2. pwa-builder: great idea! pwa applications are very very interesting and the give a lot of value to Odoo. Good! Good! Good!
     
    
    

    Antonio M. Vigliotti

    
    Mobile (+39) 342.8740910
    

    
    
    

    Il 14/06/22 09:22, Simone Orsi ha scritto:
    

    Hi all,

    
    

    I'd like to propose 2 new repos:

    
    

    1. web-api : collect modules to expose or deal with web api (eg: custom management for routes and endpoints, generic tools to handle calls to ext api, etc).

    
    

    2. pwa-builder : collect modules that allow to create and manage standalone PWA apps. As many of you know I split the core of the shopfloor wms app some time ago and this core now allows you to create - potentially - any kind of PWA app w/ its backend (based on rest services) and frontend tools (VueJS based). This core is now in OCA/wms but that's not really the right place. The name is not adequate too (shopfloor_base) so I think I'm going to rename it to pwa_core or pwa_builder or something similar.

    
    

    I'd say each of them should have its own PSC but maybe having one is fine too.

    
    

    Looking fwd to your feedback.

    
    

    Bests,

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Daniel Reis - 10:20 - 16 Jun 2022

  9 more replies

• l10n-estonia status and proposing myself as PSC

  Dear all,
  
  It seems that PSC for l10n-estonia is inactive entirely as it's been quite over a year since I've requested attention to https://github.com/OCA/l10n-estonia/pull/4 (https://github.com/OCA/l10n-estonia/pull/4#issuecomment-839124178).
  
  Also, I'd like to apply for l10n-estonia PSC.
  
  Kind regards,
  Alexey
  

  ---

  by "Alexey Pelykh" <alexey.pelykh@corphub.eu> - 07:16 - 11 Jun 2022

  8 replies 8 replies

  • Re: l10n-estonia status and proposing myself as PSC

    Thanks! Yet haven't received GitHub invite yet
    

    
    

    On 25 Jun 2022, at 23:11, Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:

    
    

    Hello Alexey,

    
    

    I just added your user to the l10-estonia PSC. You should receive the GitHub invite soon.
    

    
    

    Best regards,

    
    

    -sbi
    

    
    

    On Thu, Jun 23, 2022 at 8:57 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
    

    What next steps do I need to take?

    
    

    On Mon, Jun 13, 2022 at 11:02 AM Enric Tobella Alomar <etobella@creublanca.es> wrote:
    

    +1 From my side, it seems the Project is not used, so any contributor who wants to be a team member is good from my side.

     

    Enric Tobella Alomar

    Desarrollo

    Av. J. V. Foix 63

    08034 Barcelona

    Tlf.    932 522 522 (Ext. 1621)

    creublanca.es

     

    

     

    From: "Alexey Pelykh" <alexey.pelykh@corphub.eu>
    To: "Contributors" <contributors@odoo-community.org>
    Date: Sat, 11 Jun 2022 05:22:34 -0000
    Subject: l10n-estonia status and proposing myself as PSC
     

    Dear all,
    
    It seems that PSC for l10n-estonia is inactive entirely as it's been quite over a year since I've requested attention to https://github.com/OCA/l10n-estonia/pull/4 (https://github.com/OCA/l10n-estonia/pull/4#issuecomment-839124178).
    
    Also, I'd like to apply for l10n-estonia PSC.
    
    Kind regards,
    Alexey

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    
    
    
    
    Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
    pueden contener información reservada y/o confidencial, destinada exclusivamente
    para el uso del destinatario o la persona responsable de entregarlo al mismo,
    estando su uso no autorizado prohibido legalmente.
    Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
    salvo ratificación escrita por ambas partes. En caso de su recepción por error,
    rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
    o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
    a su eliminación.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    ---

    by Alexey Pelykh - 07:10 - 28 Jun 2022

  • Re: l10n-estonia status and proposing myself as PSC

    Hello Alexey,

    
    

    I just added your user to the l10-estonia PSC. You should receive the GitHub invite soon.
    

    
    

    Best regards,

    
    

    -sbi
    

    
    

    On Thu, Jun 23, 2022 at 8:57 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
    

    What next steps do I need to take?

    
    

    On Mon, Jun 13, 2022 at 11:02 AM Enric Tobella Alomar <etobella@creublanca.es> wrote:
    

    +1 From my side, it seems the Project is not used, so any contributor who wants to be a team member is good from my side.

     

    Enric Tobella Alomar

    Desarrollo

    Av. J. V. Foix 63

    08034 Barcelona

    Tlf.    932 522 522 (Ext. 1621)

    creublanca.es

     

    

     

    From: "Alexey Pelykh" <alexey.pelykh@corphub.eu>
    To: "Contributors" <contributors@odoo-community.org>
    Date: Sat, 11 Jun 2022 05:22:34 -0000
    Subject: l10n-estonia status and proposing myself as PSC
     

    Dear all,
    
    It seems that PSC for l10n-estonia is inactive entirely as it's been quite over a year since I've requested attention to https://github.com/OCA/l10n-estonia/pull/4 (https://github.com/OCA/l10n-estonia/pull/4#issuecomment-839124178).
    
    Also, I'd like to apply for l10n-estonia PSC.
    
    Kind regards,
    Alexey

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    
    
    
    
    Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
    pueden contener información reservada y/o confidencial, destinada exclusivamente
    para el uso del destinatario o la persona responsable de entregarlo al mismo,
    estando su uso no autorizado prohibido legalmente.
    Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
    salvo ratificación escrita por ambas partes. En caso de su recepción por error,
    rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
    o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
    a su eliminación.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Stéphane Bidoul - 11:10 - 25 Jun 2022

  • Re: l10n-estonia status and proposing myself as PSC

    What next steps do I need to take?

    
    

    On Mon, Jun 13, 2022 at 11:02 AM Enric Tobella Alomar <etobella@creublanca.es> wrote:
    

    +1 From my side, it seems the Project is not used, so any contributor who wants to be a team member is good from my side.

     

    Enric Tobella Alomar

    Desarrollo

    Av. J. V. Foix 63

    08034 Barcelona

    Tlf.    932 522 522 (Ext. 1621)

    creublanca.es

     

    

     

    From: "Alexey Pelykh" <alexey.pelykh@corphub.eu>
    To: "Contributors" <contributors@odoo-community.org>
    Date: Sat, 11 Jun 2022 05:22:34 -0000
    Subject: l10n-estonia status and proposing myself as PSC
     

    Dear all,
    
    It seems that PSC for l10n-estonia is inactive entirely as it's been quite over a year since I've requested attention to https://github.com/OCA/l10n-estonia/pull/4 (https://github.com/OCA/l10n-estonia/pull/4#issuecomment-839124178).
    
    Also, I'd like to apply for l10n-estonia PSC.
    
    Kind regards,
    Alexey

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    
    
    
    
    Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
    pueden contener información reservada y/o confidencial, destinada exclusivamente
    para el uso del destinatario o la persona responsable de entregarlo al mismo,
    estando su uso no autorizado prohibido legalmente.
    Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
    salvo ratificación escrita por ambas partes. En caso de su recepción por error,
    rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
    o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
    a su eliminación.
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Alexey Pelykh - 08:56 - 23 Jun 2022

  • RE: l10n-estonia status and proposing myself as PSC

    +1

     

    De: Oleg Kuryan <oleg.kuryan@xpansa.com>
    Enviado el: lunes, 13 de junio de 2022 13:07
    Para: Contributors <contributors@odoo-community.org>
    Asunto: Re: l10n-estonia status and proposing myself as PSC

     

    +1

     

    On Mon, Jun 13, 2022 at 11:07 AM Sergio Corato <sergiocorato@gmail.com> wrote:

     

    Agree, +1
    

    Sergio Corato

     

     

    Il giorno lun 13 giu 2022 alle ore 11:01 Enric Tobella Alomar <etobella@creublanca.es> ha scritto:

     

    +1 From my side, it seems the Project is not used, so any contributor who wants to be a team member is good from my side.

     

    Enric Tobella Alomar

    Desarrollo

    Av. J. V. Foix 63

    08034 Barcelona

    Tlf.    932 522 522 (Ext. 1621)

    creublanca.es

     

     

     

    From: "Alexey Pelykh" <alexey.pelykh@corphub.eu>
    To: "Contributors" <contributors@odoo-community.org>
    Date: Sat, 11 Jun 2022 05:22:34 -0000
    Subject: l10n-estonia status and proposing myself as PSC
     

    Dear all,
    
    It seems that PSC for l10n-estonia is inactive entirely as it's been quite over a year since I've requested attention to https://github.com/OCA/l10n-estonia/pull/4 (https://github.com/OCA/l10n-estonia/pull/4#issuecomment-839124178).
    
    Also, I'd like to apply for l10n-estonia PSC.
    
    Kind regards,
    Alexey

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    
    
    
    
    Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
    pueden contener información reservada y/o confidencial, destinada exclusivamente
    para el uso del destinatario o la persona responsable de entregarlo al mismo,
    estando su uso no autorizado prohibido legalmente.
    Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
    salvo ratificación escrita por ambas partes. En caso de su recepción por error,
    rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
    o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
    a su eliminación.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    ---

    by Rafael Blasco (Moduon) - 12:05 - 14 Jun 2022

  • Re: l10n-estonia status and proposing myself as PSC

    It should be members from such PSC that needs to approve the inclusion, but I think it's a bit orphaned, and one of them (Oleg) already approved it, so I don't think it is a problem to include him.

    
    

    Regards.
    

    ---

    by Pedro M. Baeza - 01:11 - 13 Jun 2022

  3 more replies

• Problem when 2 person click same button on the same state at the same time.

  Dear community,

  
  

  I don't know technical word to describe this. As we knew, Odoo's view is not refreshed in real time as data got updated backend. And this is problematic.

  
  

  For example,

  • 2 users open the same document at state Draft, and a Confirm Button visible.
  • 1st user clicks Confirm, and document sequence set to 1001
  • 2nd user still see the same Confirm button (as page not refreshed), and click it, sequence now change to 1002 without consent of the first person.

  Because Odoo don't have mechanism to prevent this by the framework, and this can happen easily on less mature code.

  
  

  Anyone have good techniques to prevent this, rather than writing the blocking everywhere?

  
  

  Thanks!

  ---

  by Kitti Upariphutthiphong - 07:20 - 9 Jun 2022

  6 replies 6 replies

  • Re: Problem when 2 person click same button on the same state at the same time.

    Thanks Raph for confirming. 

    
    

    I am also testing, def _check_concurrency(self): without success

    
    

    Seems to be useless without passing __last_update from the client side. May we we keep our hope on v16 OWL.

    
    

    
    

    On Fri, Jun 10, 2022 at 10:46 AM Raphaël Valyi <rvalyi@akretion.com> wrote:
    

    Yes an old one... A few years ago, some Odoo employee told me they planned to push live changes to all Odoo open sessions (server push). Might be a way to make such possibility extremely unlikely enough. But so far it seems they didn't developp the idea further. I guess the web client JS/OWL overhaul would come first anyway.

    
    

    Well in the places were this is extremely important like accounting move posting or stock reservation, we should ensure we have some sort of checking. In the other places, cross fingers, detect and fix later, try to partition the records processing over the users in ways that tend to avoid concurrent updates...

    
    

    May be leaving tabs open forever should also be avoided. May be some minimal autoresfresh could help and cost little dev...

    
    

    On Thu, Jun 9, 2022, 3:42 PM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    Found this problem discussed wayed back by our OCA people, https://github.com/odoo/odoo/issues/6737
    

    
    

    After reading, sound not quite possible, does it?

    
    

    On Fri, Jun 10, 2022 at 1:02 AM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    OK, I think it called the page is "Dirty"

    
    

    I found from ERPNext on the same scenario, the 2nd person attempt to update, it will show warning like following,

    
    

    Error: Document has been modified after you have opened it (2022-06-10 00:59:10.014101, 2022-06-10 00:59:24.963271). Please refresh to get the latest document.
    

    
    

    This would be good too.

    
    

    On Fri, Jun 10, 2022 at 12:45 AM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    Yes Tom, but with that we need to write checking code everywhere. I wonder if there are better way (or yet some base server module in OCA).

    
    

    I know that in other big name ERP., such an issue was prevented at the framework level, no way it can happen at all. Such things, when occur in accounting documents, can be a serious one.

    
    

    Another thing (of the same technical shallowness of Odoo) I experienced iwas, user somehow click reverse document twice (because slow response), and it produce reverse entries twice!

    
    

    On Fri, Jun 10, 2022 at 12:26 AM Tom Blauwendraat <tom@sunflowerweb.nl> wrote:
    

    Regular way is just to check if the sale order is already confirmed, and then don't increase the sequence again.
    

    On 6/9/22 19:22, Kitti U. wrote:
    

    Dear community,

    
    

    I don't know technical word to describe this. As we knew, Odoo's view is not refreshed in real time as data got updated backend. And this is problematic.

    
    

    For example,

    • 2 users open the same document at state Draft, and a Confirm Button visible.
    • 1st user clicks Confirm, and document sequence set to 1001
    • 2nd user still see the same Confirm button (as page not refreshed), and click it, sequence now change to 1002 without consent of the first person.

    Because Odoo don't have mechanism to prevent this by the framework, and this can happen easily on less mature code.

    
    

    Anyone have good techniques to prevent this, rather than writing the blocking everywhere?

    
    

    Thanks!

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Kitti Upariphutthiphong - 06:36 - 10 Jun 2022

  • Re: Problem when 2 person click same button on the same state at the same time.

    Yes an old one... A few years ago, some Odoo employee told me they planned to push live changes to all Odoo open sessions (server push). Might be a way to make such possibility extremely unlikely enough. But so far it seems they didn't developp the idea further. I guess the web client JS/OWL overhaul would come first anyway.

    
    

    Well in the places were this is extremely important like accounting move posting or stock reservation, we should ensure we have some sort of checking. In the other places, cross fingers, detect and fix later, try to partition the records processing over the users in ways that tend to avoid concurrent updates...

    
    

    May be leaving tabs open forever should also be avoided. May be some minimal autoresfresh could help and cost little dev...

    
    

    On Thu, Jun 9, 2022, 3:42 PM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    Found this problem discussed wayed back by our OCA people, https://github.com/odoo/odoo/issues/6737
    

    
    

    After reading, sound not quite possible, does it?

    
    

    On Fri, Jun 10, 2022 at 1:02 AM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    OK, I think it called the page is "Dirty"

    
    

    I found from ERPNext on the same scenario, the 2nd person attempt to update, it will show warning like following,

    
    

    Error: Document has been modified after you have opened it (2022-06-10 00:59:10.014101, 2022-06-10 00:59:24.963271). Please refresh to get the latest document.
    

    
    

    This would be good too.

    
    

    On Fri, Jun 10, 2022 at 12:45 AM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    Yes Tom, but with that we need to write checking code everywhere. I wonder if there are better way (or yet some base server module in OCA).

    
    

    I know that in other big name ERP., such an issue was prevented at the framework level, no way it can happen at all. Such things, when occur in accounting documents, can be a serious one.

    
    

    Another thing (of the same technical shallowness of Odoo) I experienced iwas, user somehow click reverse document twice (because slow response), and it produce reverse entries twice!

    
    

    On Fri, Jun 10, 2022 at 12:26 AM Tom Blauwendraat <tom@sunflowerweb.nl> wrote:
    

    Regular way is just to check if the sale order is already confirmed, and then don't increase the sequence again.
    

    On 6/9/22 19:22, Kitti U. wrote:
    

    Dear community,

    
    

    I don't know technical word to describe this. As we knew, Odoo's view is not refreshed in real time as data got updated backend. And this is problematic.

    
    

    For example,

    • 2 users open the same document at state Draft, and a Confirm Button visible.
    • 1st user clicks Confirm, and document sequence set to 1001
    • 2nd user still see the same Confirm button (as page not refreshed), and click it, sequence now change to 1002 without consent of the first person.

    Because Odoo don't have mechanism to prevent this by the framework, and this can happen easily on less mature code.

    
    

    Anyone have good techniques to prevent this, rather than writing the blocking everywhere?

    
    

    Thanks!

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by "Raphaël Valyi" <rvalyi@akretion.com> - 05:45 - 10 Jun 2022

  • Re: Problem when 2 person click same button on the same state at the same time.

    Found this problem discussed wayed back by our OCA people, https://github.com/odoo/odoo/issues/6737
    

    
    

    After reading, sound not quite possible, does it?

    
    

    On Fri, Jun 10, 2022 at 1:02 AM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    OK, I think it called the page is "Dirty"

    
    

    I found from ERPNext on the same scenario, the 2nd person attempt to update, it will show warning like following,

    
    

    Error: Document has been modified after you have opened it (2022-06-10 00:59:10.014101, 2022-06-10 00:59:24.963271). Please refresh to get the latest document.
    

    
    

    This would be good too.

    
    

    On Fri, Jun 10, 2022 at 12:45 AM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    Yes Tom, but with that we need to write checking code everywhere. I wonder if there are better way (or yet some base server module in OCA).

    
    

    I know that in other big name ERP., such an issue was prevented at the framework level, no way it can happen at all. Such things, when occur in accounting documents, can be a serious one.

    
    

    Another thing (of the same technical shallowness of Odoo) I experienced iwas, user somehow click reverse document twice (because slow response), and it produce reverse entries twice!

    
    

    On Fri, Jun 10, 2022 at 12:26 AM Tom Blauwendraat <tom@sunflowerweb.nl> wrote:
    

    Regular way is just to check if the sale order is already confirmed, and then don't increase the sequence again.
    

    On 6/9/22 19:22, Kitti U. wrote:
    

    Dear community,

    
    

    I don't know technical word to describe this. As we knew, Odoo's view is not refreshed in real time as data got updated backend. And this is problematic.

    
    

    For example,

    • 2 users open the same document at state Draft, and a Confirm Button visible.
    • 1st user clicks Confirm, and document sequence set to 1001
    • 2nd user still see the same Confirm button (as page not refreshed), and click it, sequence now change to 1002 without consent of the first person.

    Because Odoo don't have mechanism to prevent this by the framework, and this can happen easily on less mature code.

    
    

    Anyone have good techniques to prevent this, rather than writing the blocking everywhere?

    
    

    Thanks!

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Kitti Upariphutthiphong - 08:41 - 9 Jun 2022

  • Re: Problem when 2 person click same button on the same state at the same time.

    OK, I think it called the page is "Dirty"

    
    

    I found from ERPNext on the same scenario, the 2nd person attempt to update, it will show warning like following,

    
    

    Error: Document has been modified after you have opened it (2022-06-10 00:59:10.014101, 2022-06-10 00:59:24.963271). Please refresh to get the latest document.
    

    
    

    This would be good too.

    
    

    On Fri, Jun 10, 2022 at 12:45 AM Kitti U. <kittiu@ecosoft.co.th> wrote:
    

    Yes Tom, but with that we need to write checking code everywhere. I wonder if there are better way (or yet some base server module in OCA).

    
    

    I know that in other big name ERP., such an issue was prevented at the framework level, no way it can happen at all. Such things, when occur in accounting documents, can be a serious one.

    
    

    Another thing (of the same technical shallowness of Odoo) I experienced iwas, user somehow click reverse document twice (because slow response), and it produce reverse entries twice!

    
    

    On Fri, Jun 10, 2022 at 12:26 AM Tom Blauwendraat <tom@sunflowerweb.nl> wrote:
    

    Regular way is just to check if the sale order is already confirmed, and then don't increase the sequence again.
    

    On 6/9/22 19:22, Kitti U. wrote:
    

    Dear community,

    
    

    I don't know technical word to describe this. As we knew, Odoo's view is not refreshed in real time as data got updated backend. And this is problematic.

    
    

    For example,

    • 2 users open the same document at state Draft, and a Confirm Button visible.
    • 1st user clicks Confirm, and document sequence set to 1001
    • 2nd user still see the same Confirm button (as page not refreshed), and click it, sequence now change to 1002 without consent of the first person.

    Because Odoo don't have mechanism to prevent this by the framework, and this can happen easily on less mature code.

    
    

    Anyone have good techniques to prevent this, rather than writing the blocking everywhere?

    
    

    Thanks!

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Kitti Upariphutthiphong - 08:06 - 9 Jun 2022

  • Re: Problem when 2 person click same button on the same state at the same time.

    Yes Tom, but with that we need to write checking code everywhere. I wonder if there are better way (or yet some base server module in OCA).

    
    

    I know that in other big name ERP., such an issue was prevented at the framework level, no way it can happen at all. Such things, when occur in accounting documents, can be a serious one.

    
    

    Another thing (of the same technical shallowness of Odoo) I experienced iwas, user somehow click reverse document twice (because slow response), and it produce reverse entries twice!

    
    

    On Fri, Jun 10, 2022 at 12:26 AM Tom Blauwendraat <tom@sunflowerweb.nl> wrote:
    

    Regular way is just to check if the sale order is already confirmed, and then don't increase the sequence again.
    

    On 6/9/22 19:22, Kitti U. wrote:
    

    Dear community,

    
    

    I don't know technical word to describe this. As we knew, Odoo's view is not refreshed in real time as data got updated backend. And this is problematic.

    
    

    For example,

    • 2 users open the same document at state Draft, and a Confirm Button visible.
    • 1st user clicks Confirm, and document sequence set to 1001
    • 2nd user still see the same Confirm button (as page not refreshed), and click it, sequence now change to 1002 without consent of the first person.

    Because Odoo don't have mechanism to prevent this by the framework, and this can happen easily on less mature code.

    
    

    Anyone have good techniques to prevent this, rather than writing the blocking everywhere?

    
    

    Thanks!

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Kitti Upariphutthiphong - 07:45 - 9 Jun 2022

  1 more replies

• Weblate translation locked down for account-analytic-15-0

  Hi,

  
  

  This module translation project is set read-only:

  https://translation.odoo-community.org/projects/account-analytic-15-0/account-analytic-15-0-account_analytic_parent/

  
  

  Due to this error:

  fatal: bad revision 'origin/15.0..'
   (128)

  
  

  Can someone unlock it ?

  
  

  Note that I tried the Push button in repository maintenance but it does not update the lock status even if data seems to be fetched correctly.
  

  Repository for account-analytic-15.0/account-analytic-15.0-account_analytic_parent

  Source code repository	git@github.com:OCA/account-analytic.git

  Repository branch	15.0
  Last remote commit	[ADD] setup.py 2d8aa95

  OCA-git-bot authored 3 weeks ago
  Weblate repository	https://translation.odoo-community.org/git/account-analytic-15-0/account-analytic-15-0-account_analytic_parent/

  Repository details	On branch 15.0 Your branch is up to date with 'origin/15.0'. nothing to commit, working tree clean

  
  

  
  

  --
  Yann PAPOUIN, Ingénieur R&D | DEC

  ---

  by Yann Papouin - 04:40 - 9 Jun 2022

  2 replies 2 replies

  • Re: Weblate translation locked down for account-analytic-15-0

    Thank you 👍

    
    

    --
    Yann PAPOUIN, Ingénieur R&D | DEC

    ---

    by Yann Papouin - 05:01 - 9 Jun 2022

  • Re: Weblate translation locked down for account-analytic-15-0

    I unlocked it.

    
    

    Best regards,
    

    
    

    -sbi
    

    
    

    On Thu, Jun 9, 2022 at 4:42 PM Yann Papouin <ypa@decgroupe.com> wrote:
    

    Hi,

    
    

    This module translation project is set read-only:

    https://translation.odoo-community.org/projects/account-analytic-15-0/account-analytic-15-0-account_analytic_parent/

    
    

    Due to this error:

    fatal: bad revision 'origin/15.0..'
     (128)

    
    

    Can someone unlock it ?

    
    

    Note that I tried the Push button in repository maintenance but it does not update the lock status even if data seems to be fetched correctly.
    

    Repository for account-analytic-15.0/account-analytic-15.0-account_analytic_parent

    Source code repository	git@github.com:OCA/account-analytic.git

    Repository branch	15.0
    Last remote commit	[ADD] setup.py 2d8aa95

    OCA-git-bot authored 3 weeks ago
    Weblate repository	https://translation.odoo-community.org/git/account-analytic-15-0/account-analytic-15-0-account_analytic_parent/

    Repository details	On branch 15.0 Your branch is up to date with 'origin/15.0'. nothing to commit, working tree clean

    
    

    
    

    --
    Yann PAPOUIN, Ingénieur R&D | DEC

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Stéphane Bidoul - 04:51 - 9 Jun 2022

• How to import old invoices from legacy system

  Hello,
  
  I would kindly ask if there is some guide on how to import old invoices from a legacy system. These were processed and paid long time ago so I just need them to be able to see customers' history. However accounting features get in my way when I attempt to import Journal Items (account.move.line) saying "Cannot create unbalanced entry". I guess this has to do with Journal Entries (not) being created as they'd normally do.
  
  Is there a way to do this somewhat easily? Or should I better map the data into Sale Orders? Any advice is greatly welcomed.
  
  Thank you. Best regards
  
  	Radovan Skolnik
  
  
  

  ---

  by Radovan Skolnik - 11:25 - 9 Jun 2022

  6 replies 6 replies

  • Re: How to import old invoices from legacy system

    I dealt with importing at scale and it did not work well. Though I was able to import and get all the lines, etc. but then balancing tax ids and numbers was a really a challenge and we gave up at the end. I like David's approach of creating your own model and just move the meta data for reporting purposes and not use account.move.
    

    
    

    Regards,

    Vishal Mehra

    
    

    eMail: vishal.mehra@bizalytics.net

    cell: (972) 853-1805
    

    website: http://www.bizalytics.net
    

    
    

    BizAlytics Consulting

    Analyzing Your Business for Success
    

    
    

    
    

    On Thu, Jun 9, 2022 at 11:22 AM David Beal <david.beal@akretion.com> wrote:
    

    Hi Radovan,

    
    

    I think that a good approach to bring legacy data in Odoo is to create a model like in your case account.move.imported or account.invoice.imported.

    In this table you'll create some of important fields to use for comparison with new data.
    

    Don't set too many constraints on these fields even if you can setup many2one.
    

    
    

    After imported data, you can create sql views (query in init function of the new model including the 2 previous ones) in which you can aggregate the two models with Union sql
    

    
    

    With this you can have real statistics on whole history without too many headaches on import

    
    

    You may customize functions used in Smart Buttons to have a real count or create new ones to have the 2 stats
    

    
    

    My 2 cents.

    
    

    Regards
    

    
    

    David BEAL

    Akretion
    

    Consultant ERP Odoo
    

    
    

    
    

    Le jeu. 9 juin 2022 à 14:02, Dominique k <dominique.k@elico-corp.com.sg> a écrit :
    

    importing old and paid invoices is complicated.

    
    

    you need to import invoices

    and the payment entries. then you would need to reconcile them. consequently, they won't appear any longer in your list of unpaid invoices

    
    

    next you need to reverse them: let me explain. as you enter old invoices, they would generate revenue and the yearly balance will go to accumulated profit on the balance sheet. But this will be double counted when you will import your actual opening accounting balances. so.. the easiest method would be to reverse (to zero-ise) the entries so that you start with a clean balance sheet.

    
    

    hope this helps

    
    

    On Thu, 9 Jun 2022 at 6:27 PM, Radovan Skolnik <radovan@skolnik.info> wrote:
    

    That makes sense but I guess this will enter into "accounting" and affect many 
    things (accounting-wise). These are invoices spanning more than 15 years and 
    have been "processed" (for the lack of better term on my side). Also not sure 
    I am able to create those balanced entries. So I guess I'd stick with Sale 
    Orders.
    
    Best regards
    
    	Radovan
    
    On štvrtok 9. júna 2022 12:17:26 CEST Pedro M. Baeza (Tecnativa) wrote:
    
    
    
    
    > You have to create the whole `account.move` with `line_ids` one2many totally
    
    
    
    
    > filled and balanced.
    
    
    
    
    > 
    
    
    
    
    > 
    
    
    
    
    > Regards.
    
    
    
    
    > 
    
    
    
    
    > 
    
    
    
    
    > _______________________________________________
    
    
    
    
    > Mailing-List: https://odoo-community.org/groups/contributors-15
    
    
    
    
    > Post to: mailto:contributors@odoo-community.org
    
    
    
    
    > Unsubscribe: https://odoo-community.org/groups?unsubscribe
    
    
    
    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    --
    

    Dominique KON-SUN-TACK  [Project Manager]
    

    Elico Solutions (Singapore/Shanghai/Shenzhen) 

    Odoo Gold Partner, best Odoo Partner 2014 for APAC

    
    

    Mobile: + 65 8502 2399

    Skype: dominique_elico

    Email: dominique.k@elico-corp.com.sg

    Website: www.elico-corp.com
    

    
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by Vishal Mehra - 12:51 - 9 Aug 2022

  • Re: How to import old invoices from legacy system

    Hi Radovan,

    
    

    I think that a good approach to bring legacy data in Odoo is to create a model like in your case account.move.imported or account.invoice.imported.

    In this table you'll create some of important fields to use for comparison with new data.
    

    Don't set too many constraints on these fields even if you can setup many2one.
    

    
    

    After imported data, you can create sql views (query in init function of the new model including the 2 previous ones) in which you can aggregate the two models with Union sql
    

    
    

    With this you can have real statistics on whole history without too many headaches on import

    
    

    You may customize functions used in Smart Buttons to have a real count or create new ones to have the 2 stats
    

    
    

    My 2 cents.

    
    

    Regards
    

    
    

    David BEAL

    Akretion
    

    Consultant ERP Odoo
    

    
    

    
    

    Le jeu. 9 juin 2022 à 14:02, Dominique k <dominique.k@elico-corp.com.sg> a écrit :
    

    importing old and paid invoices is complicated.

    
    

    you need to import invoices

    and the payment entries. then you would need to reconcile them. consequently, they won't appear any longer in your list of unpaid invoices

    
    

    next you need to reverse them: let me explain. as you enter old invoices, they would generate revenue and the yearly balance will go to accumulated profit on the balance sheet. But this will be double counted when you will import your actual opening accounting balances. so.. the easiest method would be to reverse (to zero-ise) the entries so that you start with a clean balance sheet.

    
    

    hope this helps

    
    

    On Thu, 9 Jun 2022 at 6:27 PM, Radovan Skolnik <radovan@skolnik.info> wrote:
    

    That makes sense but I guess this will enter into "accounting" and affect many 
    things (accounting-wise). These are invoices spanning more than 15 years and 
    have been "processed" (for the lack of better term on my side). Also not sure 
    I am able to create those balanced entries. So I guess I'd stick with Sale 
    Orders.
    
    Best regards
    
    	Radovan
    
    On štvrtok 9. júna 2022 12:17:26 CEST Pedro M. Baeza (Tecnativa) wrote:
    
    
    
    > You have to create the whole `account.move` with `line_ids` one2many totally
    
    
    
    > filled and balanced.
    
    
    
    > 
    
    
    
    > 
    
    
    
    > Regards.
    
    
    
    > 
    
    
    
    > 
    
    
    
    > _______________________________________________
    
    
    
    > Mailing-List: https://odoo-community.org/groups/contributors-15
    
    
    
    > Post to: mailto:contributors@odoo-community.org
    
    
    
    > Unsubscribe: https://odoo-community.org/groups?unsubscribe
    
    
    
    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    --
    

    Dominique KON-SUN-TACK  [Project Manager]
    

    Elico Solutions (Singapore/Shanghai/Shenzhen) 

    Odoo Gold Partner, best Odoo Partner 2014 for APAC

    
    

    Mobile: + 65 8502 2399

    Skype: dominique_elico

    Email: dominique.k@elico-corp.com.sg

    Website: www.elico-corp.com
    

    
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    ---

    by David BEAL - 06:20 - 9 Jun 2022

  • Re: How to import old invoices from legacy system

    importing old and paid invoices is complicated.

    
    

    you need to import invoices

    and the payment entries. then you would need to reconcile them. consequently, they won't appear any longer in your list of unpaid invoices

    
    

    next you need to reverse them: let me explain. as you enter old invoices, they would generate revenue and the yearly balance will go to accumulated profit on the balance sheet. But this will be double counted when you will import your actual opening accounting balances. so.. the easiest method would be to reverse (to zero-ise) the entries so that you start with a clean balance sheet.

    
    

    hope this helps

    
    

    On Thu, 9 Jun 2022 at 6:27 PM, Radovan Skolnik <radovan@skolnik.info> wrote:
    

    That makes sense but I guess this will enter into "accounting" and affect many 
    things (accounting-wise). These are invoices spanning more than 15 years and 
    have been "processed" (for the lack of better term on my side). Also not sure 
    I am able to create those balanced entries. So I guess I'd stick with Sale 
    Orders.
    
    Best regards
    
    	Radovan
    
    On štvrtok 9. júna 2022 12:17:26 CEST Pedro M. Baeza (Tecnativa) wrote:
    
    
    > You have to create the whole `account.move` with `line_ids` one2many totally
    
    
    > filled and balanced.
    
    
    > 
    
    
    > 
    
    
    > Regards.
    
    
    > 
    
    
    > 
    
    
    > _______________________________________________
    
    
    > Mailing-List: https://odoo-community.org/groups/contributors-15
    
    
    > Post to: mailto:contributors@odoo-community.org
    
    
    > Unsubscribe: https://odoo-community.org/groups?unsubscribe
    
    
    
    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    --
    

    Dominique KON-SUN-TACK  [Project Manager]
    

    Elico Solutions (Singapore/Shanghai/Shenzhen) 

    Odoo Gold Partner, best Odoo Partner 2014 for APAC

    
    

    Mobile: + 65 8502 2399

    Skype: dominique_elico

    Email: dominique.k@elico-corp.com.sg

    Website: www.elico-corp.com
    

    
    

    
    

    ---

    by dominique.k - 02:00 - 9 Jun 2022

  • Re: How to import old invoices from legacy system

    That makes sense but I guess this will enter into "accounting" and affect many 
    things (accounting-wise). These are invoices spanning more than 15 years and 
    have been "processed" (for the lack of better term on my side). Also not sure 
    I am able to create those balanced entries. So I guess I'd stick with Sale 
    Orders.
    
    Best regards
    
    	Radovan
    
    On štvrtok 9. júna 2022 12:17:26 CEST Pedro M. Baeza (Tecnativa) wrote:
    
    > You have to create the whole `account.move` with `line_ids` one2many totally
    
    > filled and balanced.
    
    > 
    
    > 
    
    > Regards.
    
    > 
    
    > 
    
    > _______________________________________________
    
    > Mailing-List: https://odoo-community.org/groups/contributors-15
    
    > Post to: mailto:contributors@odoo-community.org
    
    > Unsubscribe: https://odoo-community.org/groups?unsubscribe
    
    
    
    
    

    ---

    by Radovan Skolnik - 12:26 - 9 Jun 2022

  • Re: How to import old invoices from legacy system

    You have to create the whole `account.move` with `line_ids` one2many totally filled and balanced.

    
    

    Regards.
    

    ---

    by Pedro M. Baeza - 12:16 - 9 Jun 2022

  1 more replies

• queue_job commit

  Hello,

  
  

  I would like to commit fix for queue_job but am not able to do that with git. Is it enough if I send it to you in email so I don't break something in the repo itself? The description and code itself is below.

  Thanks!

  
  

  queue_job: split autovacuum execution
  
  Sometimes autovacuum method reach thread max execution time and fail (for us it is 120 seconds). Therefore stop its execution if takes long time and run it again as a new job.
  

  
  

  @@ -282,13 +282,19 @@ class QueueJob(models.Model):
           """Delete all jobs done based on the removal interval defined on the
              channel
   
           Called from a cron.
           """
  +        start = datetime.now()
  +        time_exceeded = False
           for channel in self.env["queue.job.channel"].search([]):
               deadline = datetime.now() - timedelta(days=int(channel.removal_interval))
               while True:
  +                if (datetime.now() - start).total_seconds() > 60:
  +                    # we don't want to have thread max execution time exceeded exception
  +                    time_exceeded = True
  +                    break
                   jobs = self.search(
                       [
                           ("date_done", "<=", deadline),
                           ("channel", "=", channel.complete_name),
                       ],
  @@ -296,10 +302,15 @@ class QueueJob(models.Model):
                   )
                   if jobs:
                       jobs.unlink()
                   else:
                       break
  +            if time_exceeded:
  +                break
  +        if time_exceeded:
  +            # there is probably still something to cleanup so run it again
  +            self.env.ref("queue_job.ir_cron_autovacuum_queue_jobs").with_delay().method_direct_trigger()
           return True
   
       def requeue_stuck_jobs(self, enqueued_delta=5, started_delta=0):
           """Fix jobs that are in a bad states
   
  
  

  Code of the autovacuum method:

  
  

      def autovacuum(self):
          """Delete all jobs done based on the removal interval defined on the
             channel
  
          Called from a cron.
          """
          start = datetime.now()
          time_exceeded = False
          for channel in self.env["queue.job.channel"].search([]):
              deadline = datetime.now() - timedelta(days=int(channel.removal_interval))
              while True:
                  if (datetime.now() - start).total_seconds() > 60:
                      # we don't want to have thread max execution time exceeded exception
                      time_exceeded = True
                      break
                  jobs = self.search(
                      [
                          ("date_done", "<=", deadline),
                          ("channel", "=", channel.complete_name),
                      ],
                      limit=1000,
                  )
                  if jobs:
                      jobs.unlink()
                  else:
                      break
              if time_exceeded:
                  break
          if time_exceeded:
              # there is probably still something to cleanup so run it again
              self.env.ref("queue_job.ir_cron_autovacuum_queue_jobs").with_delay().method_direct_trigger()
          return True
  

  
  

  Kind regards,

  Martin

  
  

  
  

  ---

  by "Martin Fraňo" <waky007@gmail.com> - 10:06 - 9 Jun 2022

  1 attachments 1 attachments

  image.png

  1 replies 1 replies

  • Re: queue_job commit

    Hi,

    
    

    There is already a pending PR there : https://github.com/OCA/queue/pull/417

    
    

    You can maybe review it ?

    
    

    Thanks

    
    

    On Thu, Jun 9, 2022 at 10:07 AM Martin Fraňo <waky007@gmail.com> wrote:
    

    Hello,

    
    

    I would like to commit fix for queue_job but am not able to do that with git. Is it enough if I send it to you in email so I don't break something in the repo itself? The description and code itself is below.

    Thanks!

    
    

    queue_job: split autovacuum execution
    
    Sometimes autovacuum method reach thread max execution time and fail (for us it is 120 seconds). Therefore stop its execution if takes long time and run it again as a new job.
    

    
    

    @@ -282,13 +282,19 @@ class QueueJob(models.Model):
             """Delete all jobs done based on the removal interval defined on the
                channel
     
             Called from a cron.
             """
    +        start = datetime.now()
    +        time_exceeded = False
             for channel in self.env["queue.job.channel"].search([]):
                 deadline = datetime.now() - timedelta(days=int(channel.removal_interval))
                 while True:
    +                if (datetime.now() - start).total_seconds() > 60:
    +                    # we don't want to have thread max execution time exceeded exception
    +                    time_exceeded = True
    +                    break
                     jobs = self.search(
                         [
                             ("date_done", "<=", deadline),
                             ("channel", "=", channel.complete_name),
                         ],
    @@ -296,10 +302,15 @@ class QueueJob(models.Model):
                     )
                     if jobs:
                         jobs.unlink()
                     else:
                         break
    +            if time_exceeded:
    +                break
    +        if time_exceeded:
    +            # there is probably still something to cleanup so run it again
    +            self.env.ref("queue_job.ir_cron_autovacuum_queue_jobs").with_delay().method_direct_trigger()
             return True
     
         def requeue_stuck_jobs(self, enqueued_delta=5, started_delta=0):
             """Fix jobs that are in a bad states
     
    
    

    Code of the autovacuum method:

    
    

        def autovacuum(self):
            """Delete all jobs done based on the removal interval defined on the
               channel
    
            Called from a cron.
            """
            start = datetime.now()
            time_exceeded = False
            for channel in self.env["queue.job.channel"].search([]):
                deadline = datetime.now() - timedelta(days=int(channel.removal_interval))
                while True:
                    if (datetime.now() - start).total_seconds() > 60:
                        # we don't want to have thread max execution time exceeded exception
                        time_exceeded = True
                        break
                    jobs = self.search(
                        [
                            ("date_done", "<=", deadline),
                            ("channel", "=", channel.complete_name),
                        ],
                        limit=1000,
                    )
                    if jobs:
                        jobs.unlink()
                    else:
                        break
                if time_exceeded:
                    break
            if time_exceeded:
                # there is probably still something to cleanup so run it again
                self.env.ref("queue_job.ir_cron_autovacuum_queue_jobs").with_delay().method_direct_trigger()
            return True
    

    
    

    Kind regards,

    Martin

    
    

    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    ---

    by Denis Roussel - 10:31 - 9 Jun 2022

• Creation of Wallet repository

  Hi all,

  
  

  As some people are requesting wallet functionalities (aka Financial Reserve), I request the creation of 'wallet' repository under the umbrella of Accounting PSC.

  
  

  As soon as it is created, we are going to propose PR's with our current work.

  
  

  So, see you there!

  
  

  
  

  Many thanks.
  

  
  

  --
  

  
  Denis Roussel
  Software Engineer
  T    : +32 2 888 31 49
  M : +32 472 22 00 57

  
  

  
  

  Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
  

  Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

  Zone industrielle 22 | L-8287 Kehlen | Luxembourg
  

  ---

  by Denis Roussel - 02:36 - 8 Jun 2022

  7 replies 7 replies

  • Re: Creation of Wallet repository

    Could you just init it as I don't have write access ?

    
    

    With 14.0 branch first.

    
    

    Thanks

    
    

    On Tue, Jun 21, 2022 at 11:21 AM Roussel, Denis <denis.roussel@acsone.eu> wrote:
    

    Great, thanks !

    
    

    On Tue, Jun 21, 2022 at 11:17 AM Simone Orsi <simahawk@gmail.com> wrote:
    

    Ciao,

    
    

    done https://github.com/OCA/wallet

    
    

    Cheers

    
    

    On Fri, Jun 17, 2022 at 2:52 PM Roussel, Denis <denis.roussel@acsone.eu> wrote:
    

    Hi @Board,

    
    

    We had a meeting with all people interested in (Grap/Akretion/CoopITEasy/Acsone).

    
    

    So, we agree that we need it.

    
    

    Could you create a 'wallet' one ?

    
    

    Many thanks

    
    

    On Wed, Jun 8, 2022 at 2:54 PM Roussel, Denis <denis.roussel@acsone.eu> wrote:
    

    Of course, we have done it in 8/10/14, the current version is there:

    
    

    https://github.com/acsone/acsone-addons/tree/14.0/account_wallet
    

    
    

    
    

    
    

    
    

    
    

    
    

    On Wed, Jun 8, 2022 at 2:46 PM Sylvain LE GAL <sylvain.legal@grap.coop> wrote:
    

    Hi Denis,

    
    

    Thanks for the information.

    
    

    FYI, we worked with coop it easy on a implementation of wallet for account & pos.

    
    

    the current code for V12 is available here :
    

    - https://github.com/coopiteasy/addons/tree/12.0/account_customer_wallet

    - https://github.com/coopiteasy/addons/tree/12.0/pos_customer_wallet

    
    

    Could be great to benchmark various implementation to choose the better one (or a mix of feature from various implementations)
    

    
    

    Could you send the url of the repo with your current work ?
    

    
    

    kind regards.
    

    
    

    CC : Carmen / Catherine from coop it easy.
    

    
    

    Sylvain LE GAL - Twitter
    

    GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

    Site Web | FramaSphere | Facebook
    3 Grande rue des Feuillants, 69001 Lyon
    Standard : (+33) 09.72.32.33.17
    

    Service Informatique : (+33) 09.73.79.64.40

    Astreinte Informatique : (+33) 06.81.85.61.43

    Member of the OCA (Odoo Community Association)
    

    Web Site | Twitter
    

    
    

    
    

    Le mer. 8 juin 2022 à 14:36, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Hi all,

    
    

    As some people are requesting wallet functionalities (aka Financial Reserve), I request the creation of 'wallet' repository under the umbrella of Accounting PSC.

    
    

    As soon as it is created, we are going to propose PR's with our current work.

    
    

    So, see you there!

    
    

    
    

    Many thanks.
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    ---

    by Denis Roussel - 11:26 - 21 Jun 2022

  • Re: Creation of Wallet repository

    Great, thanks !

    
    

    On Tue, Jun 21, 2022 at 11:17 AM Simone Orsi <simahawk@gmail.com> wrote:
    

    Ciao,

    
    

    done https://github.com/OCA/wallet

    
    

    Cheers

    
    

    On Fri, Jun 17, 2022 at 2:52 PM Roussel, Denis <denis.roussel@acsone.eu> wrote:
    

    Hi @Board,

    
    

    We had a meeting with all people interested in (Grap/Akretion/CoopITEasy/Acsone).

    
    

    So, we agree that we need it.

    
    

    Could you create a 'wallet' one ?

    
    

    Many thanks

    
    

    On Wed, Jun 8, 2022 at 2:54 PM Roussel, Denis <denis.roussel@acsone.eu> wrote:
    

    Of course, we have done it in 8/10/14, the current version is there:

    
    

    https://github.com/acsone/acsone-addons/tree/14.0/account_wallet
    

    
    

    
    

    
    

    
    

    
    

    
    

    On Wed, Jun 8, 2022 at 2:46 PM Sylvain LE GAL <sylvain.legal@grap.coop> wrote:
    

    Hi Denis,

    
    

    Thanks for the information.

    
    

    FYI, we worked with coop it easy on a implementation of wallet for account & pos.

    
    

    the current code for V12 is available here :
    

    - https://github.com/coopiteasy/addons/tree/12.0/account_customer_wallet

    - https://github.com/coopiteasy/addons/tree/12.0/pos_customer_wallet

    
    

    Could be great to benchmark various implementation to choose the better one (or a mix of feature from various implementations)
    

    
    

    Could you send the url of the repo with your current work ?
    

    
    

    kind regards.
    

    
    

    CC : Carmen / Catherine from coop it easy.
    

    
    

    Sylvain LE GAL - Twitter
    

    GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

    Site Web | FramaSphere | Facebook
    3 Grande rue des Feuillants, 69001 Lyon
    Standard : (+33) 09.72.32.33.17
    

    Service Informatique : (+33) 09.73.79.64.40

    Astreinte Informatique : (+33) 06.81.85.61.43

    Member of the OCA (Odoo Community Association)
    

    Web Site | Twitter
    

    
    

    
    

    Le mer. 8 juin 2022 à 14:36, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Hi all,

    
    

    As some people are requesting wallet functionalities (aka Financial Reserve), I request the creation of 'wallet' repository under the umbrella of Accounting PSC.

    
    

    As soon as it is created, we are going to propose PR's with our current work.

    
    

    So, see you there!

    
    

    
    

    Many thanks.
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    ---

    by Denis Roussel - 11:26 - 21 Jun 2022

  • Re: Creation of Wallet repository

    Ciao,

    
    

    done https://github.com/OCA/wallet

    
    

    Cheers

    
    

    On Fri, Jun 17, 2022 at 2:52 PM Roussel, Denis <denis.roussel@acsone.eu> wrote:
    

    Hi @Board,

    
    

    We had a meeting with all people interested in (Grap/Akretion/CoopITEasy/Acsone).

    
    

    So, we agree that we need it.

    
    

    Could you create a 'wallet' one ?

    
    

    Many thanks

    
    

    On Wed, Jun 8, 2022 at 2:54 PM Roussel, Denis <denis.roussel@acsone.eu> wrote:
    

    Of course, we have done it in 8/10/14, the current version is there:

    
    

    https://github.com/acsone/acsone-addons/tree/14.0/account_wallet
    

    
    

    
    

    
    

    
    

    
    

    
    

    On Wed, Jun 8, 2022 at 2:46 PM Sylvain LE GAL <sylvain.legal@grap.coop> wrote:
    

    Hi Denis,

    
    

    Thanks for the information.

    
    

    FYI, we worked with coop it easy on a implementation of wallet for account & pos.

    
    

    the current code for V12 is available here :
    

    - https://github.com/coopiteasy/addons/tree/12.0/account_customer_wallet

    - https://github.com/coopiteasy/addons/tree/12.0/pos_customer_wallet

    
    

    Could be great to benchmark various implementation to choose the better one (or a mix of feature from various implementations)
    

    
    

    Could you send the url of the repo with your current work ?
    

    
    

    kind regards.
    

    
    

    CC : Carmen / Catherine from coop it easy.
    

    
    

    Sylvain LE GAL - Twitter
    

    GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

    Site Web | FramaSphere | Facebook
    3 Grande rue des Feuillants, 69001 Lyon
    Standard : (+33) 09.72.32.33.17
    

    Service Informatique : (+33) 09.73.79.64.40

    Astreinte Informatique : (+33) 06.81.85.61.43

    Member of the OCA (Odoo Community Association)
    

    Web Site | Twitter
    

    
    

    
    

    Le mer. 8 juin 2022 à 14:36, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Hi all,

    
    

    As some people are requesting wallet functionalities (aka Financial Reserve), I request the creation of 'wallet' repository under the umbrella of Accounting PSC.

    
    

    As soon as it is created, we are going to propose PR's with our current work.

    
    

    So, see you there!

    
    

    
    

    Many thanks.
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    Simone Orsi

    
    

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.

    ---

    by Simone Orsi - 11:15 - 21 Jun 2022

  • Re: Creation of Wallet repository

    Hi @Board,

    
    

    We had a meeting with all people interested in (Grap/Akretion/CoopITEasy/Acsone).

    
    

    So, we agree that we need it.

    
    

    Could you create a 'wallet' one ?

    
    

    Many thanks

    
    

    On Wed, Jun 8, 2022 at 2:54 PM Roussel, Denis <denis.roussel@acsone.eu> wrote:
    

    Of course, we have done it in 8/10/14, the current version is there:

    
    

    https://github.com/acsone/acsone-addons/tree/14.0/account_wallet
    

    
    

    
    

    
    

    
    

    
    

    
    

    On Wed, Jun 8, 2022 at 2:46 PM Sylvain LE GAL <sylvain.legal@grap.coop> wrote:
    

    Hi Denis,

    
    

    Thanks for the information.

    
    

    FYI, we worked with coop it easy on a implementation of wallet for account & pos.

    
    

    the current code for V12 is available here :
    

    - https://github.com/coopiteasy/addons/tree/12.0/account_customer_wallet

    - https://github.com/coopiteasy/addons/tree/12.0/pos_customer_wallet

    
    

    Could be great to benchmark various implementation to choose the better one (or a mix of feature from various implementations)
    

    
    

    Could you send the url of the repo with your current work ?
    

    
    

    kind regards.
    

    
    

    CC : Carmen / Catherine from coop it easy.
    

    
    

    Sylvain LE GAL - Twitter
    

    GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

    Site Web | FramaSphere | Facebook
    3 Grande rue des Feuillants, 69001 Lyon
    Standard : (+33) 09.72.32.33.17
    

    Service Informatique : (+33) 09.73.79.64.40

    Astreinte Informatique : (+33) 06.81.85.61.43

    Member of the OCA (Odoo Community Association)
    

    Web Site | Twitter
    

    
    

    
    

    Le mer. 8 juin 2022 à 14:36, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Hi all,

    
    

    As some people are requesting wallet functionalities (aka Financial Reserve), I request the creation of 'wallet' repository under the umbrella of Accounting PSC.

    
    

    As soon as it is created, we are going to propose PR's with our current work.

    
    

    So, see you there!

    
    

    
    

    Many thanks.
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    ---

    by Denis Roussel - 02:51 - 17 Jun 2022

  • Re: Creation of Wallet repository

    We implemented it with "gift cards".

    
    

    
    

    Only v14:

    
    

    gift_card https://github.com/OCA/sale-promotion/pull/45

    account_payment_gift_card https://github.com/OCA/account-payment/pull/485

    account_gift_card_invoice_refund https://github.com/OCA/account-payment/pull/486

    shopinvader_payment_gift_card https://github.com/shopinvader/odoo-shopinvader-payment/pull/70

    pos_payment_gift_card: soon
    

    
    

    
    

    
    

    Le mer. 8 juin 2022 à 14:57, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Of course, we have done it in 8/10/14, the current version is there:

    
    

    https://github.com/acsone/acsone-addons/tree/14.0/account_wallet
    

    
    

    
    

    
    

    
    

    
    

    
    

    On Wed, Jun 8, 2022 at 2:46 PM Sylvain LE GAL <sylvain.legal@grap.coop> wrote:
    

    Hi Denis,

    
    

    Thanks for the information.

    
    

    FYI, we worked with coop it easy on a implementation of wallet for account & pos.

    
    

    the current code for V12 is available here :
    

    - https://github.com/coopiteasy/addons/tree/12.0/account_customer_wallet

    - https://github.com/coopiteasy/addons/tree/12.0/pos_customer_wallet

    
    

    Could be great to benchmark various implementation to choose the better one (or a mix of feature from various implementations)
    

    
    

    Could you send the url of the repo with your current work ?
    

    
    

    kind regards.
    

    
    

    CC : Carmen / Catherine from coop it easy.
    

    
    

    Sylvain LE GAL - Twitter
    

    GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

    Site Web | FramaSphere | Facebook
    3 Grande rue des Feuillants, 69001 Lyon
    Standard : (+33) 09.72.32.33.17
    

    Service Informatique : (+33) 09.73.79.64.40

    Astreinte Informatique : (+33) 06.81.85.61.43

    Member of the OCA (Odoo Community Association)
    

    Web Site | Twitter
    

    
    

    
    

    Le mer. 8 juin 2022 à 14:36, Roussel, Denis <denis.roussel@acsone.eu> a écrit :
    

    Hi all,

    
    

    As some people are requesting wallet functionalities (aka Financial Reserve), I request the creation of 'wallet' repository under the umbrella of Accounting PSC.

    
    

    As soon as it is created, we are going to propose PR's with our current work.

    
    

    So, see you there!

    
    

    
    

    Many thanks.
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57

    
    

    
    

    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    

    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    
    --
    

    Raphaël Reverdy
    

    Mobile +33 6 38 02 03 93
    

    Fixe +33 4 82 53 84 60

    ---

    by Raphaël Reverdy - 11:46 - 9 Jun 2022

  2 more replies

• Migration from V11 to V15 -> Fields on account.invoice.line

  Hello dear contributors,

  
  

  I have an issue, what some of you might have an easy solution for: After the migration from V11 to V15, obviously the account.invoice.line model was replaced in favor of account.move.line . There were custom fields on account.invoice.line which need to be migrated to account.move.line now in order that a custom module works and the data stays correct.

  
  

  The migration was done by Odoo.com (Enterprise). The account.invoice.line table is still there with the custom fields, but I can't see a link to the migrated counterparts on account.move.line. Does anyone know what I could use as a link to copy over the values of my custom fields?

  
  

  Any hint is appreciated!

  
  

  Thanks and cheers,

  -- 
  

  	Laurence Lars Labusch Chief Technology Officer +1 833-767-6366 llabusch@archeti.com archeti.com 2348 Jean Talon Est, #403 Montreal, Quebec, H2E 1V7 Canada

  ---

  by "Laurence Labusch" <llabusch@archeti.com> - 11:11 - 1 Jun 2022

  1 attachments 1 attachments

  signature.asc

• Odoo Integration for SAP Ariba

  Hello dear contributors,
  
  we are right now in search for an Odoo module which could connect to the 
  API of the SAP Ariba application.
  
  I tried to find information about that, but it seems there is definitely 
  not much in that regard.
  
  Do you have any clues or is there possibly even something in the OCA 
  that I did simply miss during research?
  
  Best greetings,
  
  Manuel
  
  
  -- 
  Mit freundlichen Grüßen
  
  Manuel Engel
  Trainee Anwendungsentwicklung
  
  
  initOS GmbH
  Innungsstraße 7
  21224 Buchholz i.d.N.
  
  Phone:   +49 4105 13503-22
  Fax:     +49 4105 13503-10
  
  Email:   manuel.engel@initos.com
  Web:     http://www.initos.com
  
  Geschäftsführung:
  Dr.-Ing. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke
  
  Sitz der Gesellschaft: Buchholz i.d.N.
  Amtsgericht Tostedt, HRB 205226
  Steuer-Nr: 15/200/53247
  USt-IdNr: DE815580155
  
  

  ---

  by Manuel Engel - 03:30 - 30 May 2022

  1 replies 1 replies

  • Re: Odoo Integration for SAP Ariba

    Hi,

    
    

    
    

    In our case we did it like this:

    
    

    Odoo import & export standard UBL [1] <-> Lobester [2] <-> SAP Ariba 

    
    

    Not sure it helps much, but this is how we managed it. If you'd like to make a direct connector to Ariba, I strongly suggest using the EDI stack stated here.

    
    

    Regards,

    
    

    Joël

    
    

    [1] 

    https://github.com/OCA/edi/tree/14.0/base_ubl
    

    https://github.com/OCA/edi/tree/14.0/edi_oca
    

    https://github.com/OCA/edi/tree/14.0/edi_endpoint_oca
    

    https://github.com/OCA/edi/tree/14.0/edi_sale_order_import_ubl
    

    
    

    
    

    [2] https://www.lobster-world.com/de/

    
    

    
    

    
    

    On Mon, May 30, 2022 at 3:31 PM Manuel Engel <manuel.engel@initos.com> wrote:
    

    Hello dear contributors,
    
    we are right now in search for an Odoo module which could connect to the 
    API of the SAP Ariba application.
    
    I tried to find information about that, but it seems there is definitely 
    not much in that regard.
    
    Do you have any clues or is there possibly even something in the OCA 
    that I did simply miss during research?
    
    Best greetings,
    
    Manuel
    
    
    
    -- 
    Mit freundlichen Grüßen
    
    Manuel Engel
    Trainee Anwendungsentwicklung
    
    
    initOS GmbH
    Innungsstraße 7
    21224 Buchholz i.d.N.
    
    Phone:   +49 4105 13503-22
    Fax:     +49 4105 13503-10
    
    Email:   manuel.engel@initos.com
    Web:     http://www.initos.com
    
    Geschäftsführung:
    Dr.-Ing. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke
    
    Sitz der Gesellschaft: Buchholz i.d.N.
    Amtsgericht Tostedt, HRB 205226
    Steuer-Nr: 15/200/53247
    USt-IdNr: DE815580155
    
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe
    

    
    

    
    

    --
    

    
    

    camptocamp

    INNOVATIVE SOLUTIONS

    BY OPEN SOURCE EXPERTS

    
    

    Joël Grand-Guillaume

    Department Head
    

    Business Solutions
    

    
    

    +41 21 619 10 28

    www.camptocamp.com
    

    
    

    ---

    by Joël Grand Guillaume - 12:06 - 1 Jun 2022