Archives
Contributors
-
Re: 2019 OCA Financial Auditors Campaign - NOW OPEN
Congratulations!
Antonio M. VigliottiPresidente eletto associazione Odoo Italia
Mobile (+39) 342.8740910
Il 03/09/2019 09:56, admin@ygol.com ha scritto:
Thank you guys. glad to be on board!
--
Yves Goldberg - איב גולדברג
odoo| Official Partner - OCA member
Open Source ERP, CRM & CMS
T +972 (3) 720 8818
M +972 (55) 966 1405T +32 (2) 588 2500
--
----- Original message -----
From: Jay Vora <vora.jay@serpentcs.com>
To: Contributors <contributors@odoo-community.org>
Subject: Re: 2019 OCA Financial Auditors Campaign - NOW OPEN
Date: Tuesday, September 03, 2019 06:12
Congratulations guys!
On Tue, Sep 3, 2019, 5:47 AM Maxime Chambreuil <mchambreuil@opensourceintegrators.com> wrote:
Congratulations to the new Delegates! Welcome on board.
Make yourself at home :)
On Mon, Sep 2, 2019 at 6:52 PM Rebecca Gellatly <rebecca@o4sb.com> wrote:
Dear OCA Contributors,
The 2019 Delegates Campaign has now closed with 3 new Delegates being appointed:
- Yves Goldberg
- Simone Orsi
- Sergio Teruel
We welcome the new Delegates onboard.
The campaign to become an OCA Board Member or OCA Financial Auditor is NOW OPEN.
Only valid (paid) Delegates are eligible to apply for the Board Member positions - the link for these applications has been sent to the Delegates mailing list.
To apply for 2019 OCA Financial Auditor, please fill in this form:
https://odoo-community.org/survey/start/2019-oca-financial-auditors-candidates-31
You do NOT need to have a valid membership to apply.
For more information on their responsibilities, please read the Bylaws:
The campaign will be closed on September 15th, 2019 with the election following.
If you have any questions, please do not hesitate to reply on this list.
Warm regards,
Rebecca
--
Rebecca Gellatly
General Secretary
Odoo Community Association
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Antonio M. Vigliotti - 12:36 - 3 Sep 2019 - Yves Goldberg
-
Re: 2019 OCA Financial Auditors Campaign - NOW OPEN
Thank you guys. glad to be on board!--Yves Goldberg - איב גולדברגodoo| Official Partner - OCA memberOpen Source ERP, CRM & CMST +972 (3) 720 8818
M +972 (55) 966 1405T +32 (2) 588 2500 ------- Original message -----From: Jay Vora <vora.jay@serpentcs.com>To: Contributors <contributors@odoo-community.org>Subject: Re: 2019 OCA Financial Auditors Campaign - NOW OPENDate: Tuesday, September 03, 2019 06:12Congratulations guys!On Tue, Sep 3, 2019, 5:47 AM Maxime Chambreuil <mchambreuil@opensourceintegrators.com> wrote:Congratulations to the new Delegates! Welcome on board.Make yourself at home :)On Mon, Sep 2, 2019 at 6:52 PM Rebecca Gellatly <rebecca@o4sb.com> wrote:Dear OCA Contributors,The 2019 Delegates Campaign has now closed with 3 new Delegates being appointed:- Yves Goldberg
- Simone Orsi
- Sergio Teruel
We welcome the new Delegates onboard.The campaign to become an OCA Board Member or OCA Financial Auditor is NOW OPEN.Only valid (paid) Delegates are eligible to apply for the Board Member positions - the link for these applications has been sent to the Delegates mailing list.To apply for 2019 OCA Financial Auditor, please fill in this form:https://odoo-community.org/survey/start/2019-oca-financial-auditors-candidates-31
You do NOT need to have a valid membership to apply.For more information on their responsibilities, please read the Bylaws:The campaign will be closed on September 15th, 2019 with the election following.If you have any questions, please do not hesitate to reply on this list.Warm regards,Rebecca--Rebecca GellatlyGeneral SecretaryOdoo Community Association_______________________________________________Mailing-List: https://odoo-community.org/groups/contributors-15Post to: mailto:contributors@odoo-community.orgUnsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________Mailing-List: https://odoo-community.org/groups/contributors-15Post to: mailto:contributors@odoo-community.orgUnsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________Mailing-List: https://odoo-community.org/groups/contributors-15Post to: mailto:contributors@odoo-community.orgUnsubscribe: https://odoo-community.org/groups?unsubscribe
by Yves Goldberg - 09:55 - 3 Sep 2019 - Yves Goldberg
-
Re: 2019 OCA Financial Auditors Campaign - NOW OPEN
Congratulations guys!On Tue, Sep 3, 2019, 5:47 AM Maxime Chambreuil <mchambreuil@opensourceintegrators.com> wrote:Congratulations to the new Delegates! Welcome on board.Make yourself at home :)MAXIME CHAMBREUIL
PROJECT MANAGER/CONSULTANTO: 1.855.877.2377 EXT. 710
M: 602.427.5632
E: MChambreuil@OpenSourcelntegrators.comP.O. BOX 940, HIGLEY, AZ 85236 
On Mon, Sep 2, 2019 at 6:52 PM Rebecca Gellatly <rebecca@o4sb.com> wrote:Dear OCA Contributors,
The 2019 Delegates Campaign has now closed with 3 new Delegates being appointed:- Yves Goldberg
- Simone Orsi
- Sergio Teruel
We welcome the new Delegates onboard.The campaign to become an OCA Board Member or OCA Financial Auditor is NOW OPEN.Only valid (paid) Delegates are eligible to apply for the Board Member positions - the link for these applications has been sent to the Delegates mailing list.To apply for 2019 OCA Financial Auditor, please fill in this form:https://odoo-community.org/survey/start/2019-oca-financial-auditors-candidates-31
You do NOT need to have a valid membership to apply.For more information on their responsibilities, please read the Bylaws:The campaign will be closed on September 15th, 2019 with the election following.If you have any questions, please do not hesitate to reply on this list.Warm regards,Rebecca--Rebecca GellatlyGeneral SecretaryOdoo Community Association_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Jay Vora - 05:11 - 3 Sep 2019 -
Re: 2019 OCA Financial Auditors Campaign - NOW OPEN
Congratulations to the new Delegates! Welcome on board.Make yourself at home :)MAXIME CHAMBREUIL
PROJECT MANAGER/CONSULTANTO: 1.855.877.2377 EXT. 710
M: 602.427.5632
E: MChambreuil@OpenSourcelntegrators.comP.O. BOX 940, HIGLEY, AZ 85236 On Mon, Sep 2, 2019 at 6:52 PM Rebecca Gellatly <rebecca@o4sb.com> wrote:Dear OCA Contributors,
The 2019 Delegates Campaign has now closed with 3 new Delegates being appointed:- Yves Goldberg
- Simone Orsi
- Sergio Teruel
We welcome the new Delegates onboard.The campaign to become an OCA Board Member or OCA Financial Auditor is NOW OPEN.Only valid (paid) Delegates are eligible to apply for the Board Member positions - the link for these applications has been sent to the Delegates mailing list.To apply for 2019 OCA Financial Auditor, please fill in this form:https://odoo-community.org/survey/start/2019-oca-financial-auditors-candidates-31
You do NOT need to have a valid membership to apply.For more information on their responsibilities, please read the Bylaws:The campaign will be closed on September 15th, 2019 with the election following.If you have any questions, please do not hesitate to reply on this list.Warm regards,Rebecca--Rebecca GellatlyGeneral SecretaryOdoo Community Association_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Maxime Chambreuil - 02:16 - 3 Sep 2019 -
2019 OCA Financial Auditors Campaign - NOW OPEN
Dear OCA Contributors,
The 2019 Delegates Campaign has now closed with 3 new Delegates being appointed:- Yves Goldberg
- Simone Orsi
- Sergio Teruel
We welcome the new Delegates onboard.The campaign to become an OCA Board Member or OCA Financial Auditor is NOW OPEN.Only valid (paid) Delegates are eligible to apply for the Board Member positions - the link for these applications has been sent to the Delegates mailing list.To apply for 2019 OCA Financial Auditor, please fill in this form:https://odoo-community.org/survey/start/2019-oca-financial-auditors-candidates-31
You do NOT need to have a valid membership to apply.For more information on their responsibilities, please read the Bylaws:The campaign will be closed on September 15th, 2019 with the election following.If you have any questions, please do not hesitate to reply on this list.Warm regards,Rebecca--Rebecca GellatlyGeneral SecretaryOdoo Community Association
by Rebecca Gellatly - 01:50 - 3 Sep 2019 -
Re: new PSC dedicated to Brand management
+1On Mon, Sep 2, 2019 at 12:26 PM Simone Orsi <simahawk@gmail.com> wrote:+1Looks good, indeed, thanks!On Mon, Sep 2, 2019 at 11:52 AM Pedro Manuel Baeza Romero <pedro.baeza@gmail.com> wrote:+1Thanks for bringing this to the table.El lun., 2 sept. 2019 11:12, Stéphane Bidoul <stephane.bidoul@acsone.eu> escribió:Dear contributors,We currently have some modules in OCA that are dedicated to brand management spread a few different repositories: product_brand, partner_brand, account_brand, sale_brand.There are currently two broad brand mechanisms/use cases:- companies that sell under different brands and want to influence their document layouts, managecredit control by brand, etc- classifying products by brand (module product_brand)Following a conversation in the partner-contact repo, we came to the conclusion a new repository and PSC is appropriate, since this is a transversal concept.Unless there are objections i'll proceed with the creation of the brand PSC and repo.As PSC members, I propose Maxime Chambreuil and Souheil Bejaoui who have been and/or will be active in this area in the past/coming months at least. If there are other candidates or suggestion about members, please speak up :)Since most modules are relatively new the current plan is to move them, as well as related issues and PRs to the new brand repo for the 12.0 branch.Best regards,-sbi--_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Laurent Mignon - 03:05 - 2 Sep 2019 -
Re: new PSC dedicated to Brand management
+1Looks good, indeed, thanks!On Mon, Sep 2, 2019 at 11:52 AM Pedro Manuel Baeza Romero <pedro.baeza@gmail.com> wrote:+1Thanks for bringing this to the table.El lun., 2 sept. 2019 11:12, Stéphane Bidoul <stephane.bidoul@acsone.eu> escribió:Dear contributors,We currently have some modules in OCA that are dedicated to brand management spread a few different repositories: product_brand, partner_brand, account_brand, sale_brand.There are currently two broad brand mechanisms/use cases:- companies that sell under different brands and want to influence their document layouts, managecredit control by brand, etc- classifying products by brand (module product_brand)Following a conversation in the partner-contact repo, we came to the conclusion a new repository and PSC is appropriate, since this is a transversal concept.Unless there are objections i'll proceed with the creation of the brand PSC and repo.As PSC members, I propose Maxime Chambreuil and Souheil Bejaoui who have been and/or will be active in this area in the past/coming months at least. If there are other candidates or suggestion about members, please speak up :)Since most modules are relatively new the current plan is to move them, as well as related issues and PRs to the new brand repo for the 12.0 branch.Best regards,-sbi--_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Simone Orsi - 12:25 - 2 Sep 2019 -
Re: new PSC dedicated to Brand management
+1Thanks for bringing this to the table.El lun., 2 sept. 2019 11:12, Stéphane Bidoul <stephane.bidoul@acsone.eu> escribió:Dear contributors,We currently have some modules in OCA that are dedicated to brand management spread a few different repositories: product_brand, partner_brand, account_brand, sale_brand.There are currently two broad brand mechanisms/use cases:- companies that sell under different brands and want to influence their document layouts, managecredit control by brand, etc- classifying products by brand (module product_brand)Following a conversation in the partner-contact repo, we came to the conclusion a new repository and PSC is appropriate, since this is a transversal concept.Unless there are objections i'll proceed with the creation of the brand PSC and repo.As PSC members, I propose Maxime Chambreuil and Souheil Bejaoui who have been and/or will be active in this area in the past/coming months at least. If there are other candidates or suggestion about members, please speak up :)Since most modules are relatively new the current plan is to move them, as well as related issues and PRs to the new brand repo for the 12.0 branch.Best regards,-sbi--
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Pedro M. Baeza - 11:51 - 2 Sep 2019 -
new PSC dedicated to Brand management
Dear contributors,We currently have some modules in OCA that are dedicated to brand management spread a few different repositories: product_brand, partner_brand, account_brand, sale_brand.There are currently two broad brand mechanisms/use cases:- companies that sell under different brands and want to influence their document layouts, managecredit control by brand, etc- classifying products by brand (module product_brand)Following a conversation in the partner-contact repo, we came to the conclusion a new repository and PSC is appropriate, since this is a transversal concept.Unless there are objections i'll proceed with the creation of the brand PSC and repo.As PSC members, I propose Maxime Chambreuil and Souheil Bejaoui who have been and/or will be active in this area in the past/coming months at least. If there are other candidates or suggestion about members, please speak up :)Since most modules are relatively new the current plan is to move them, as well as related issues and PRs to the new brand repo for the 12.0 branch.Best regards,-sbi--
by Stéphane Bidoul - 11:10 - 2 Sep 2019 -
Re: Issue with allowed_user_ids ?
Do you know where allowed_user_ids is defined and used?On Fri, 30 Aug 2019 at 16:11, Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community,Sorry for bothering via email, but I’ve encountered a very odd issue that goes beyond my area of knowledge. Please see https://github.com/OCA/project/pull/570It fails on OCA Travis, but works on our Travis, and fails with oddest issue ever:Field 'allowed_user_ids' used in attributes must be present in view but is missing: - 'allowed_user_ids' in domain="[('id', 'in', allowed_user_ids)]"I’ve tried:<field name="allowed_user_ids" invisible="1"/>adding this fixed OCA Travis, but breaks Runbot and our Travis. Not having that line (which seems really correct to me) is perfectly fine for Runbot and our Travis, but breaks OCA Travis. Any ideas?Alexey_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Lorenzo Battistini
https://github.com/eLBati
by Lorenzo Battistini. - 02:56 - 31 Aug 2019 -
Re: Stale PR closing
I'm in favor to move forward with this.Alexey was kind enough to do a PR, which includes adding a "stale 🗃" label so they are easy to find.Note PR merged by /ocabot merge (virtually all of them these days) are labeled as "merged 🎉" so they too are easy to find even in case a rebase has been done.12 months is a reasonably long time. And if anyone is still interested it's easy to (ask to) reopen to get a new one year lease.@Graeme Gellatly does this address your concerns?-sbiOn Thu, Aug 29, 2019 at 6:27 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:We can implement just-labeling initially, at least to see the amount of impact. Personally, I don’t see any harm in closing PR that had 0 comments for 12 months, assuming it’s valuable and reviewers are doing their part of the deal.
On Aug 29, 2019, at 18:17, Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> wrote:For your case @Graeme Gellatly may be we can just add a label "Close by bot" so it's still pretty easy to find them right ?Because today, the fact so many PRs remain open for months if not years is a real issue I think.Any how, we all agree there is something to do here. The OCA days is probably the best place to discuss it right ;)On Thu, Aug 29, 2019 at 2:36 PM Daniel Reis <dgreis@sapo.pt> wrote:If we do this, we need to make sure that closed PR really means that the PR was not merged.I see on the Odoo repo may closed PRs that had their code manually merged - not sure if we have this in the OCA.What if the bot just regularly (monthly?) pinged the followers.People would manually close a stale PR if that makes sense.DanielOr once it hit 12 months of inactivity, ocabot can auto assign to any active contributors (i..e, 2 person) to review it?After that like 3 months, if still no activity, close it.On Thu, Aug 29, 2019 at 4:17 PM Eduardo Magdalena <emagdalena@c2i.es> wrote:+1 12 months - 18 months. First add a comment or label as a warning, telling that the PR will be closed an the closed if there are no activity 6 months afterUn saludo,
Eduardo Magdalena
Fundador & CEO
✆ +34 678 713 373
C2i Change 2 improve
Optimización de procesos
Averigua a quién conocemos en común
Este correo y sus archivos asociados son privados y confidenciales y van dirigidos exclusivamente a su destinatario. Si recibe este correo sin ser el destinatario del mismo le rogamos proceda a su eliminación y lo ponga en conocimiento de su emisor. La difusión por cualquier medio de su contenido podría ser sancionada conforme a lo previsto en la legislación vigente, Ley Orgánica 15/1999, de Protección de Datos de Carácter Personal. Le rogamos que no imprima este correo ni sus documentos adjuntos, salvo que lo estime necesario. El jue., 29 ago. 2019 a las 3:32, Graeme Gellatly (<gdgellatly@gmail.com>) escribió:Hi,I don't like the idea personally, especially on OCA wide level. I often pick up abandoned PR's fix them up and resubmit them. At the very least I like to go through them when porting modules to see if anything in there is value that needs porting. If they are closed it is a hassle working out why it was closed (superseded, abandoned etc).Maybe for new to OCA modules, but for existing modules, a human should really determine whether it is worth reviving IMO. I think a much better application for a Bot is to find interested reviewers. Do some smart stuff likeWhen a PR is submitted, crawl history and cc any past reviewer or committer for that module (maybe even have a reviewer group so people can choose to opt in) (maybe in past 18 months)On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <rafael.blasco@tecnativa.com> wrote:+1 18 months
De: Mignon, Laurent [mailto:laurent.mignon@acsone.eu]
Enviado el: martes, 27 de agosto de 2019 10:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing+1
On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
Hello Alexey,
+1
This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10, awaiting PR :)
If someone wants to work on this at #OCADays, I'll be happy to help.
-sbi
On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
Dear community,
In OCA repositories there are PRs that have not been updated for years, and are either abandoned by authors or by reviewers. Should we agree on policy (and implement it via OCA Bot) to close PR/issue if there was no activity for more than 6-12-18 months?
Kind regards,
Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--camptocampINNOVATIVE SOLUTIONSBY OPEN SOURCE EXPERTSJoël Grand-GuillaumeDepartment HeadBusiness Solutions_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Stéphane Bidoul - 07:16 - 29 Aug 2019 -
Re: Stale PR closing
We can implement just-labeling initially, at least to see the amount of impact. Personally, I don’t see any harm in closing PR that had 0 comments for 12 months, assuming it’s valuable and reviewers are doing their part of the deal.
On Aug 29, 2019, at 18:17, Joël Grand-Guillaume <joel.grandguillaume@camptocamp.com> wrote:For your case @Graeme Gellatly may be we can just add a label "Close by bot" so it's still pretty easy to find them right ?Because today, the fact so many PRs remain open for months if not years is a real issue I think.Any how, we all agree there is something to do here. The OCA days is probably the best place to discuss it right ;)On Thu, Aug 29, 2019 at 2:36 PM Daniel Reis <dgreis@sapo.pt> wrote:If we do this, we need to make sure that closed PR really means that the PR was not merged.I see on the Odoo repo may closed PRs that had their code manually merged - not sure if we have this in the OCA.What if the bot just regularly (monthly?) pinged the followers.People would manually close a stale PR if that makes sense.DanielOr once it hit 12 months of inactivity, ocabot can auto assign to any active contributors (i..e, 2 person) to review it?After that like 3 months, if still no activity, close it.On Thu, Aug 29, 2019 at 4:17 PM Eduardo Magdalena <emagdalena@c2i.es> wrote:+1 12 months - 18 months. First add a comment or label as a warning, telling that the PR will be closed an the closed if there are no activity 6 months afterUn saludo,
Eduardo Magdalena
Fundador & CEO
✆ +34 678 713 373
C2i Change 2 improve
Optimización de procesos
Averigua a quién conocemos en común Este correo y sus archivos asociados son privados y confidenciales y van dirigidos exclusivamente a su destinatario. Si recibe este correo sin ser el destinatario del mismo le rogamos proceda a su eliminación y lo ponga en conocimiento de su emisor. La difusión por cualquier medio de su contenido podría ser sancionada conforme a lo previsto en la legislación vigente, Ley Orgánica 15/1999, de Protección de Datos de Carácter Personal. Le rogamos que no imprima este correo ni sus documentos adjuntos, salvo que lo estime necesario. El jue., 29 ago. 2019 a las 3:32, Graeme Gellatly (<gdgellatly@gmail.com>) escribió:Hi,I don't like the idea personally, especially on OCA wide level. I often pick up abandoned PR's fix them up and resubmit them. At the very least I like to go through them when porting modules to see if anything in there is value that needs porting. If they are closed it is a hassle working out why it was closed (superseded, abandoned etc).Maybe for new to OCA modules, but for existing modules, a human should really determine whether it is worth reviving IMO. I think a much better application for a Bot is to find interested reviewers. Do some smart stuff likeWhen a PR is submitted, crawl history and cc any past reviewer or committer for that module (maybe even have a reviewer group so people can choose to opt in) (maybe in past 18 months)On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <rafael.blasco@tecnativa.com> wrote:+1 18 months
De: Mignon, Laurent [mailto:laurent.mignon@acsone.eu]
Enviado el: martes, 27 de agosto de 2019 10:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing+1
On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
Hello Alexey,
+1
This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10, awaiting PR :)
If someone wants to work on this at #OCADays, I'll be happy to help.
-sbi
On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
Dear community,
In OCA repositories there are PRs that have not been updated for years, and are either abandoned by authors or by reviewers. Should we agree on policy (and implement it via OCA Bot) to close PR/issue if there was no activity for more than 6-12-18 months?
Kind regards,
Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--camptocampINNOVATIVE SOLUTIONSBY OPEN SOURCE EXPERTSJoël Grand-GuillaumeDepartment HeadBusiness Solutions_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Alexey Pelykh <alexey.pelykh@gmail.com> - 06:26 - 29 Aug 2019 -
Re: Stale PR closing
For your case @Graeme Gellatly may be we can just add a label "Close by bot" so it's still pretty easy to find them right ?Because today, the fact so many PRs remain open for months if not years is a real issue I think.Any how, we all agree there is something to do here. The OCA days is probably the best place to discuss it right ;)On Thu, Aug 29, 2019 at 2:36 PM Daniel Reis <dgreis@sapo.pt> wrote:If we do this, we need to make sure that closed PR really means that the PR was not merged.I see on the Odoo repo may closed PRs that had their code manually merged - not sure if we have this in the OCA.What if the bot just regularly (monthly?) pinged the followers.People would manually close a stale PR if that makes sense.DanielOr once it hit 12 months of inactivity, ocabot can auto assign to any active contributors (i..e, 2 person) to review it?After that like 3 months, if still no activity, close it.On Thu, Aug 29, 2019 at 4:17 PM Eduardo Magdalena <emagdalena@c2i.es> wrote:+1 12 months - 18 months. First add a comment or label as a warning, telling that the PR will be closed an the closed if there are no activity 6 months afterUn saludo,
Eduardo Magdalena
Fundador & CEO
✆ +34 678 713 373
C2i Change 2 improve
Optimización de procesos
Averigua a quién conocemos en común Este correo y sus archivos asociados son privados y confidenciales y van dirigidos exclusivamente a su destinatario. Si recibe este correo sin ser el destinatario del mismo le rogamos proceda a su eliminación y lo ponga en conocimiento de su emisor. La difusión por cualquier medio de su contenido podría ser sancionada conforme a lo previsto en la legislación vigente, Ley Orgánica 15/1999, de Protección de Datos de Carácter Personal. Le rogamos que no imprima este correo ni sus documentos adjuntos, salvo que lo estime necesario. El jue., 29 ago. 2019 a las 3:32, Graeme Gellatly (<gdgellatly@gmail.com>) escribió:Hi,I don't like the idea personally, especially on OCA wide level. I often pick up abandoned PR's fix them up and resubmit them. At the very least I like to go through them when porting modules to see if anything in there is value that needs porting. If they are closed it is a hassle working out why it was closed (superseded, abandoned etc).Maybe for new to OCA modules, but for existing modules, a human should really determine whether it is worth reviving IMO. I think a much better application for a Bot is to find interested reviewers. Do some smart stuff likeWhen a PR is submitted, crawl history and cc any past reviewer or committer for that module (maybe even have a reviewer group so people can choose to opt in) (maybe in past 18 months)On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <rafael.blasco@tecnativa.com> wrote:+1 18 months
De: Mignon, Laurent [mailto:laurent.mignon@acsone.eu]
Enviado el: martes, 27 de agosto de 2019 10:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing+1
On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
Hello Alexey,
+1
This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10, awaiting PR :)
If someone wants to work on this at #OCADays, I'll be happy to help.
-sbi
On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
Dear community,
In OCA repositories there are PRs that have not been updated for years, and are either abandoned by authors or by reviewers. Should we agree on policy (and implement it via OCA Bot) to close PR/issue if there was no activity for more than 6-12-18 months?
Kind regards,
Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--camptocampINNOVATIVE SOLUTIONSBY OPEN SOURCE EXPERTSJoël Grand-GuillaumeDepartment HeadBusiness Solutions
by Joël Grand Guillaume - 06:16 - 29 Aug 2019 -
Re: Stale PR closing
If we do this, we need to make sure that closed PR really means that the PR was not merged.I see on the Odoo repo may closed PRs that had their code manually merged - not sure if we have this in the OCA.What if the bot just regularly (monthly?) pinged the followers.People would manually close a stale PR if that makes sense.DanielOr once it hit 12 months of inactivity, ocabot can auto assign to any active contributors (i..e, 2 person) to review it?After that like 3 months, if still no activity, close it.On Thu, Aug 29, 2019 at 4:17 PM Eduardo Magdalena <emagdalena@c2i.es> wrote:+1 12 months - 18 months. First add a comment or label as a warning, telling that the PR will be closed an the closed if there are no activity 6 months afterUn saludo,
Eduardo Magdalena
Fundador & CEO
✆ +34 678 713 373
C2i Change 2 improve
Optimización de procesos
Averigua a quién conocemos en común Este correo y sus archivos asociados son privados y confidenciales y van dirigidos exclusivamente a su destinatario. Si recibe este correo sin ser el destinatario del mismo le rogamos proceda a su eliminación y lo ponga en conocimiento de su emisor. La difusión por cualquier medio de su contenido podría ser sancionada conforme a lo previsto en la legislación vigente, Ley Orgánica 15/1999, de Protección de Datos de Carácter Personal. Le rogamos que no imprima este correo ni sus documentos adjuntos, salvo que lo estime necesario. El jue., 29 ago. 2019 a las 3:32, Graeme Gellatly (<gdgellatly@gmail.com>) escribió:Hi,I don't like the idea personally, especially on OCA wide level. I often pick up abandoned PR's fix them up and resubmit them. At the very least I like to go through them when porting modules to see if anything in there is value that needs porting. If they are closed it is a hassle working out why it was closed (superseded, abandoned etc).Maybe for new to OCA modules, but for existing modules, a human should really determine whether it is worth reviving IMO. I think a much better application for a Bot is to find interested reviewers. Do some smart stuff likeWhen a PR is submitted, crawl history and cc any past reviewer or committer for that module (maybe even have a reviewer group so people can choose to opt in) (maybe in past 18 months)On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <rafael.blasco@tecnativa.com> wrote:+1 18 months
De: Mignon, Laurent [mailto:laurent.mignon@acsone.eu]
Enviado el: martes, 27 de agosto de 2019 10:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing+1
On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
Hello Alexey,
+1
This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10, awaiting PR :)
If someone wants to work on this at #OCADays, I'll be happy to help.
-sbi
On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
Dear community,
In OCA repositories there are PRs that have not been updated for years, and are either abandoned by authors or by reviewers. Should we agree on policy (and implement it via OCA Bot) to close PR/issue if there was no activity for more than 6-12-18 months?
Kind regards,
Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Daniel Reis - 02:35 - 29 Aug 2019 -
Re: Stale PR closing
Or once it hit 12 months of inactivity, ocabot can auto assign to any active contributors (i..e, 2 person) to review it?After that like 3 months, if still no activity, close it.On Thu, Aug 29, 2019 at 4:17 PM Eduardo Magdalena <emagdalena@c2i.es> wrote:+1 12 months - 18 months. First add a comment or label as a warning, telling that the PR will be closed an the closed if there are no activity 6 months afterUn saludo,
Eduardo Magdalena
Fundador & CEO
✆ +34 678 713 373
C2i Change 2 improve
Optimización de procesos
Averigua a quién conocemos en común Este correo y sus archivos asociados son privados y confidenciales y van dirigidos exclusivamente a su destinatario. Si recibe este correo sin ser el destinatario del mismo le rogamos proceda a su eliminación y lo ponga en conocimiento de su emisor. La difusión por cualquier medio de su contenido podría ser sancionada conforme a lo previsto en la legislación vigente, Ley Orgánica 15/1999, de Protección de Datos de Carácter Personal. Le rogamos que no imprima este correo ni sus documentos adjuntos, salvo que lo estime necesario. El jue., 29 ago. 2019 a las 3:32, Graeme Gellatly (<gdgellatly@gmail.com>) escribió:Hi,I don't like the idea personally, especially on OCA wide level. I often pick up abandoned PR's fix them up and resubmit them. At the very least I like to go through them when porting modules to see if anything in there is value that needs porting. If they are closed it is a hassle working out why it was closed (superseded, abandoned etc).Maybe for new to OCA modules, but for existing modules, a human should really determine whether it is worth reviving IMO. I think a much better application for a Bot is to find interested reviewers. Do some smart stuff likeWhen a PR is submitted, crawl history and cc any past reviewer or committer for that module (maybe even have a reviewer group so people can choose to opt in) (maybe in past 18 months)On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <rafael.blasco@tecnativa.com> wrote:+1 18 months
De: Mignon, Laurent [mailto:laurent.mignon@acsone.eu]
Enviado el: martes, 27 de agosto de 2019 10:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing+1
On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
Hello Alexey,
+1
This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10, awaiting PR :)
If someone wants to work on this at #OCADays, I'll be happy to help.
-sbi
On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
Dear community,
In OCA repositories there are PRs that have not been updated for years, and are either abandoned by authors or by reviewers. Should we agree on policy (and implement it via OCA Bot) to close PR/issue if there was no activity for more than 6-12-18 months?
Kind regards,
Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Kitti Upariphutthiphong - 01:10 - 29 Aug 2019 -
Re: Stale PR closing
+1 12 months - 18 months. First add a comment or label as a warning, telling that the PR will be closed an the closed if there are no activity 6 months after
Un saludo,
Eduardo Magdalena
Fundador & CEO
✆ +34 678 713 373
C2i Change 2 improve
Optimización de procesos
Averigua a quién conocemos en común Este correo y sus archivos asociados son privados y confidenciales y van dirigidos exclusivamente a su destinatario. Si recibe este correo sin ser el destinatario del mismo le rogamos proceda a su eliminación y lo ponga en conocimiento de su emisor. La difusión por cualquier medio de su contenido podría ser sancionada conforme a lo previsto en la legislación vigente, Ley Orgánica 15/1999, de Protección de Datos de Carácter Personal. Le rogamos que no imprima este correo ni sus documentos adjuntos, salvo que lo estime necesario. El jue., 29 ago. 2019 a las 3:32, Graeme Gellatly (<gdgellatly@gmail.com>) escribió:Hi,I don't like the idea personally, especially on OCA wide level. I often pick up abandoned PR's fix them up and resubmit them. At the very least I like to go through them when porting modules to see if anything in there is value that needs porting. If they are closed it is a hassle working out why it was closed (superseded, abandoned etc).Maybe for new to OCA modules, but for existing modules, a human should really determine whether it is worth reviving IMO. I think a much better application for a Bot is to find interested reviewers. Do some smart stuff likeWhen a PR is submitted, crawl history and cc any past reviewer or committer for that module (maybe even have a reviewer group so people can choose to opt in) (maybe in past 18 months)On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <rafael.blasco@tecnativa.com> wrote:+1 18 months
De: Mignon, Laurent [mailto:laurent.mignon@acsone.eu]
Enviado el: martes, 27 de agosto de 2019 10:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing+1
On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
Hello Alexey,
+1
This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10, awaiting PR :)
If someone wants to work on this at #OCADays, I'll be happy to help.
-sbi
On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
Dear community,
In OCA repositories there are PRs that have not been updated for years, and are either abandoned by authors or by reviewers. Should we agree on policy (and implement it via OCA Bot) to close PR/issue if there was no activity for more than 6-12-18 months?
Kind regards,
Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Eduardo Magdalena - 11:16 - 29 Aug 2019 -
Re: Stale PR closing
Hi,I don't like the idea personally, especially on OCA wide level. I often pick up abandoned PR's fix them up and resubmit them. At the very least I like to go through them when porting modules to see if anything in there is value that needs porting. If they are closed it is a hassle working out why it was closed (superseded, abandoned etc).Maybe for new to OCA modules, but for existing modules, a human should really determine whether it is worth reviving IMO. I think a much better application for a Bot is to find interested reviewers. Do some smart stuff likeWhen a PR is submitted, crawl history and cc any past reviewer or committer for that module (maybe even have a reviewer group so people can choose to opt in) (maybe in past 18 months)On Thu, Aug 29, 2019 at 10:41 AM Rafael Blasco <rafael.blasco@tecnativa.com> wrote:+1 18 months
De: Mignon, Laurent [mailto:laurent.mignon@acsone.eu]
Enviado el: martes, 27 de agosto de 2019 10:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Stale PR closing+1
On Tue, Aug 27, 2019 at 10:27 AM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
Hello Alexey,
+1
This is being tracked in: https://github.com/OCA/oca-github-bot/issues/10, awaiting PR :)
If someone wants to work on this at #OCADays, I'll be happy to help.
-sbi
On Tue, Aug 27, 2019 at 10:16 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:
Dear community,
In OCA repositories there are PRs that have not been updated for years, and are either abandoned by authors or by reviewers. Should we agree on policy (and implement it via OCA Bot) to close PR/issue if there was no activity for more than 6-12-18 months?
Kind regards,
Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Graeme Gellatly - 03:31 - 29 Aug 2019
