Archives
Contributors
-
Re: Proposal: add a forum
I sympathize with this proposal.
We could experiment with it and confirm it could replace the Contributors mailing list.
A candidate for this might be
https://github.com/OCA/odoo-community.org
It already holds reference documents, such as CONTRIBUTING or Bylaws.
I can see it as the central place for global documentation regarding OCA, like an entry door to the community.
I don't think a PSC would be needed for it.
Thanks
Daniel
On 01/03/2023 09:16, Jairo Llopis wrote:
Hello! I want to propose something I hope will help everybody communicate better :)
Many of you might have notice that since long ago Github includes a discussions feature that can be enabled per repo.
Since not-so-long ago, there's a possibility to enable discussions for a whole organization. The implementation is rather simple: just select one repo from the org that becomes the "main forum repo".
Communicating through mailing lists looks very old-fashioned these days. 🧓 Every decent community has a decent forum, be it discourse or github discussions or whatever.
IMHO the best solution would be:- Create a new repo. We can call it "community" or "oca-forum" or "oca-discuss"... you name it
- PSC for this repo would be community moderators. Maybe a new PSC group?
- Set it as main discussion repo, organization-wide.
- Gradually deprecate the mailing list.
Benefits of this approach:- Look more modern.
- We can edit answers.
- We can put polls.
- We don't need to send mails with +1.
- We can link to comments.
- Community discussion more close to where the community actually works.
- Less things to maintain in odoo-community.org
That doesn't mean we can't enable discussions for specific repos, to become more focused, just like it's done in OpenUpgrade. But at least we have a general place to talk asynchronously about general stuff, just like we have the Matrix/Discord community for synchronous communication.
WDYT?_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Daniel Reis - 11:11 - 1 Mar 2023 -
Re: Proposal: add a forum
Great ideaEl mié, 1 mar 2023 a las 10:16, Jairo Llopis (<notifications@odoo-community.org>) escribió:Hello! I want to propose something I hope will help everybody communicate better :)Many of you might have notice that since long ago Github includes a discussions feature that can be enabled per repo.Since not-so-long ago, there's a possibility to enable discussions for a whole organization. The implementation is rather simple: just select one repo from the org that becomes the "main forum repo".Communicating through mailing lists looks very old-fashioned these days. 🧓 Every decent community has a decent forum, be it discourse or github discussions or whatever.IMHO the best solution would be:- Create a new repo. We can call it "community" or "oca-forum" or "oca-discuss"... you name it
- PSC for this repo would be community moderators. Maybe a new PSC group?
- Set it as main discussion repo, organization-wide.
- Gradually deprecate the mailing list.
Benefits of this approach:- Look more modern.
- We can edit answers.
- We can put polls.
- We don't need to send mails with +1.
- We can link to comments.
- Community discussion more close to where the community actually works.
- Less things to maintain in odoo-community.org
That doesn't mean we can't enable discussions for specific repos, to become more focused, just like it's done in OpenUpgrade. But at least we have a general place to talk asynchronously about general stuff, just like we have the Matrix/Discord community for synchronous communication.WDYT?_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Fernando La Chica - 11:11 - 1 Mar 2023 -
Re: Proposing myself as PSC for community-maintainers
+1On Wed, Mar 1, 2023 at 9:17 AM Jairo Llopis <notifications@odoo-community.org> wrote:Hello everybody! I hope you're doing well.I'd like to become PSC in community-maintainers repos.This is my github profile, for those that don't know me: https://github.com/yajoI'm very active in packaging, solving pre-commit issues, and I maintain the copier template and copier itself. I have years of experience and community engagement.Thanks!_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Alex Comba
Tel (CH): +41 91 210 23 40
by Alex Comba. - 10:21 - 1 Mar 2023 -
Proposal: add a forum
Hello! I want to propose something I hope will help everybody communicate better :)Many of you might have notice that since long ago Github includes a discussions feature that can be enabled per repo.Since not-so-long ago, there's a possibility to enable discussions for a whole organization. The implementation is rather simple: just select one repo from the org that becomes the "main forum repo".Communicating through mailing lists looks very old-fashioned these days. 🧓 Every decent community has a decent forum, be it discourse or github discussions or whatever.IMHO the best solution would be:- Create a new repo. We can call it "community" or "oca-forum" or "oca-discuss"... you name it
- PSC for this repo would be community moderators. Maybe a new PSC group?
- Set it as main discussion repo, organization-wide.
- Gradually deprecate the mailing list.
Benefits of this approach:- Look more modern.
- We can edit answers.
- We can put polls.
- We don't need to send mails with +1.
- We can link to comments.
- Community discussion more close to where the community actually works.
- Less things to maintain in odoo-community.org
That doesn't mean we can't enable discussions for specific repos, to become more focused, just like it's done in OpenUpgrade. But at least we have a general place to talk asynchronously about general stuff, just like we have the Matrix/Discord community for synchronous communication.WDYT?
by Jairo Llopis - 10:15 - 1 Mar 2023 -
pre-commit will fail from today unless you update the templates
Hi community!I just wanted to announce that I just released https://github.com/OCA/oca-addons-repo-template/releases/tag/v1.14.2
IfWhen you see pre-commit going nuts from today, please update the repo to the latest version of the template to fix it.Have a nice day!
by Jairo Llopis - 10:06 - 1 Mar 2023 -
Re: Proposing myself as PSC for community-maintainers
+1
On Wed, 1 Mar 2023, 09:32 Angel Moya, <notifications@odoo-community.org> wrote:+1El mié, 1 mar 2023 a las 9:27, Holger Brunn (<notifications@odoo-community.org>) escribió:> I'd like to become PSC in community-maintainers repos. +1 -- Your partner for the hard Odoo problems https://hunki-enterprises.com_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
Angel Moya Pardo
Tlf: (+34) 636 441 277
angel.moya@pesol.es
http://pesol.es
http://angelmoya.es
No me imprimas si no es necesario. Protejamos el medio ambiente
AVISO LEGAL: El contenido de este mensaje de correo electrónico, incluidos los ficheros adjuntos, es confidencial y está protegido por el artículo 18.3 de la Constitución Española, que garantiza el secreto de las comunicaciones. Si usted recibe este mensaje por error, por favor póngase en contacto con el remitente para informarle de este hecho, y no difunda su contenido ni haga copias.
Este aviso legal ha sido incorporado automáticamente al mensaje._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Luis Lafaurie - 09:41 - 1 Mar 2023 -
Re: Proposing myself as PSC for community-maintainers
+1 for JairoEl mié, 1 mar 2023 a las 9:32, Angel Moya (<notifications@odoo-community.org>) escribió:+1El mié, 1 mar 2023 a las 9:27, Holger Brunn (<notifications@odoo-community.org>) escribió:> I'd like to become PSC in community-maintainers repos. +1 -- Your partner for the hard Odoo problems https://hunki-enterprises.com_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Angel Moya Pardo
Tlf: (+34) 636 441 277
angel.moya@pesol.es
http://pesol.es
http://angelmoya.es No me imprimas si no es necesario. Protejamos el medio ambiente
AVISO LEGAL: El contenido de este mensaje de correo electrónico, incluidos los ficheros adjuntos, es confidencial y está protegido por el artículo 18.3 de la Constitución Española, que garantiza el secreto de las comunicaciones. Si usted recibe este mensaje por error, por favor póngase en contacto con el remitente para informarle de este hecho, y no difunda su contenido ni haga copias.
Este aviso legal ha sido incorporado automáticamente al mensaje._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Harald Panten López
CEO
Sygel Technology S.L
+34 613 04 76 66 
harald.panten@sygel.es 
https://www.sygel.es 
C/ Àlaba 61, 5ª planta, 08005, Barcelona
by Harald Panten Lopez - 09:37 - 1 Mar 2023 -
Re: Proposing myself as PSC for community-maintainers
+1El mié., 1 mar. 2023 9:32, Valentin Vinagre Urteaga <notifications@odoo-community.org> escribió:+1El mié, 1 mar 2023 a las 9:27, Holger Brunn (<notifications@odoo-community.org>) escribió:> I'd like to become PSC in community-maintainers repos. +1 -- Your partner for the hard Odoo problems https://hunki-enterprises.com_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Valentín Vinagre Urteaga
CTO
Sygel Technology S.L
+34 613 04 66 67 valentin.vinagre@sygel.es https://www.sygel.es C/ Àlaba 61, 5ª planta, 08005, Barcelona _______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Rafael Blasco (Moduon) - 09:36 - 1 Mar 2023 -
Re: Proposing myself as PSC for community-maintainers
+1El mié, 1 mar 2023 a las 9:27, Holger Brunn (<notifications@odoo-community.org>) escribió:> I'd like to become PSC in community-maintainers repos. +1 -- Your partner for the hard Odoo problems https://hunki-enterprises.com_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Angel Moya Pardo
Tlf: (+34) 636 441 277
angel.moya@pesol.es
http://pesol.es
http://angelmoya.es No me imprimas si no es necesario. Protejamos el medio ambiente
AVISO LEGAL: El contenido de este mensaje de correo electrónico, incluidos los ficheros adjuntos, es confidencial y está protegido por el artículo 18.3 de la Constitución Española, que garantiza el secreto de las comunicaciones. Si usted recibe este mensaje por error, por favor póngase en contacto con el remitente para informarle de este hecho, y no difunda su contenido ni haga copias.
Este aviso legal ha sido incorporado automáticamente al mensaje.
by angel.moya - 09:31 - 1 Mar 2023 -
Re: Proposing myself as PSC for community-maintainers
+1El mié, 1 mar 2023 a las 9:27, Holger Brunn (<notifications@odoo-community.org>) escribió:> I'd like to become PSC in community-maintainers repos. +1 -- Your partner for the hard Odoo problems https://hunki-enterprises.com_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Valentín Vinagre Urteaga
CTO
Sygel Technology S.L
+34 613 04 66 67 valentin.vinagre@sygel.es https://www.sygel.es C/ Àlaba 61, 5ª planta, 08005, Barcelona
by Valentín Vinagre - 09:31 - 1 Mar 2023 -
Re: Proposing myself as PSC for community-maintainers
> I'd like to become PSC in community-maintainers repos. +1 -- Your partner for the hard Odoo problems https://hunki-enterprises.com
by Holger Brunn - 09:25 - 1 Mar 2023 -
Proposing myself as PSC for community-maintainers
Hello everybody! I hope you're doing well.I'd like to become PSC in community-maintainers repos.This is my github profile, for those that don't know me: https://github.com/yajoI'm very active in packaging, solving pre-commit issues, and I maintain the copier template and copier itself. I have years of experience and community engagement.Thanks!
by Jairo Llopis - 09:15 - 1 Mar 2023 -
Payroll 15.0 PR review request
Hello contributorsMy name is Ivan Candelas from Guadalajara Mexico.I have almost 20 years of experience in ERP implementations, mainly in manufacturing, payroll and HR modules, I have been working with odoo for a few years as an implementer and freelance programmer.I look forward to actively contributing to the OCA modules.Also I'd like to request a PR review https://github.com/OCA/payroll/pull/119 of the payroll module for the 15.0 branchIván Candelas
by Ivan Candelas - 05:15 - 27 Feb 2023 -
Re: Pricelist sale price on form
Thank you very much ! Last question, in pricelist based on formula for example do we have a way to compute the discount price percentage by setting up the sales price ? I did not find anything but I might have missed it eheh.
Thanks for your help. Regards,
Hi everyone, I have tried to make an implementation for this feature that I can share.In case someone is interested in it, I made a PR named [ADD] 14.0: product_form_pricelist_percent_change" in product-attribute repository.Regards,Francesco BalleriniIl giorno mer 15 feb 2023 alle ore 12:40 Francesco Ballerini <francescobl.lavoro@gmail.com> ha scritto:Thank you Pedro and Matthieu ^^
I anticipate to you that I am also developing a module that will extend https://github.com/OCA/product-attribute/tree/14.0/product_form_pricelist and allows to open the whole pricelist rule form by product form, compute product sales price for that specific product-pricelist rule, and will also try to implement one of my previous request:8 feb 2023, 20:41 Francesco Ballerini:Last question, in pricelist based on formula do we have a way to compute the discount price percentage by setting up the sales price ?
I can notify here when PR is ready in beta if someone is interested to help with this feature.
Regards,FrancescoIl giorno mer 15 feb 2023 alle ore 11:37 Matthieu Mequignon <notifications@odoo-community.org> ha scritto:On 2/15/23 11:27, Francesco Ballerini wrote:
Thank you for mentioning about https://github.com/OCA/sale-workflow/pull/2372,
It wasn't caching because of the with_delay function https://github.com/OCA/sale-workflow/blob/6c0549005b20e695173ab7b34901cf8493418960/pricelist_cache/models/product_pricelist_cache.py#L197, I removed it because I wasn't sure how to manage function parameters, not the best way to handle maybe but now it caches instantly.
I want to ask one more thing: does Odoo not allow by default to export pricelist for customer? In that case we definitely want to use your module = )
Thanks for yor help,
Francesco
Il giorno mer 15 feb 2023 alle ore 09:52 Matthieu Mequignon <notifications@odoo-community.org> ha scritto:
On 2/15/23 09:42, Francesco Ballerini wrote:
Thank you very much for the feedback Matthieu,
can I run the creation of the cache manually for testing purposes ?I have found a cron "Reset pricelist cache" and an automation to update pricelists cache but I am not sure how to run the process from an empty cache.Il giorno mar 14 feb 2023 alle ore 12:47 Matthieu Mequignon <notifications@odoo-community.org> ha scritto:
On 2/8/23 10:22, Francesco Ballerini wrote: > Hello, > > I would like to be able to show sales price in pricelist items form. > > Very similar task to this module (only available for odoo13 at the > moment) > https://odoo-community.org/shop/product-list-pricelist-price-6617#attr=12054, > but this one does the job in the product template tree-view. > > We would need the same one in the product pricelist item form. > I need it for odoo14 but I can consider modules for other version is > there is one available but not available for 14 (could try to perform > a migration in some cases). > > Thank you in advance. Regards, > > Francesco Ballerini > > > > _______________________________________________ > Mailing-List: https://odoo-community.org/groups/contributors-15 > Post to: mailto:contributors@odoo-community.org > Unsubscribe: https://odoo-community.org/groups?unsubscribe > Hi, I wrote a module for that https://github.com/OCA/sale-workflow/tree/14.0/pricelist_cache Prices are cached everyday, so the price you see is today's price. With this module, you get a "display pricelist prices" button on the pricelist's form. Also, you get a handy "display customer prices" action on the partner. Those are popping up a tree view with all prices, which you can then filter and so on. -- Matthieu Méquignon Business Solutions Odoo Developer Camptocamp France SA Phone: +33 4 58 48 20 18 https://www.camptocamp.com/
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
Yes, you can run the scheduled action manually.
Please note that there's an ongoing bug (with the fix here https://github.com/OCA/sale-workflow/pull/2372).
It is possible to retrieve prices while caching is not done, which is wrong.
-- Matthieu Méquignon Business Solutions Odoo Developer Camptocamp France SA Phone: +33 4 58 48 20 18 https://www.camptocamp.com/
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
Because it is very slow.
In the case of the customer I wrote this module for, it takes ~10 minutes to retrieve all prices for a given pricelist.
It is okay when you don't have much products, though.
-- Matthieu Méquignon Business Solutions Odoo Developer Camptocamp France SA Phone: +33 4 58 48 20 18 https://www.camptocamp.com/
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Francesco Ballerini - 11:50 - 25 Feb 2023 -
Re: OCA Contract Repository
Hi,We have nearly completed an extensive contract project integrating contract/project/accounting/sale/purchase/schedules/field service. All in it is about 30k lines replacing 100k lines of prior custom code for a janitorial organisation.Random assortment of Notes.Supplier Contracts - used in order to communicate back to back service agreements for certain services on customer contracts. Suspensions, modifications etc. But in truth, we did that because we could.Contract Name - maybe an onchange, but some concerns with computing. The case here is that the name is an internal reference/common name used widely in online and offline conversation.Contract States - added, computed based on modifications.Margins - added in style of sale_margin module.Sale Commissions Management.Point in time revenue - can view contract (or list of contracts) value based on state at given date in future or past (contract has auto pricing so value can differ, also modifications)Portal Views - we completely rewrote in the style of sale order and added signatures.Modifications - Underrated, undeveloped feature IMO. We added extensively to record approvals, signatures and manage line and contract state. Different types of modifications trigger different actions/activities/communications.Contract Lines - distinction between regular recurring items (e.g. Window Cleaning) and As Required items (toilet paper, fridge clean out).Grouping and defaults is kind of provided if you use contract templates.I personally don't see the link between an agreement and contract. I never worked out why they are in the same repo. A contract IS an agreement, and while I accept that an agreement is not always a contract, in practice, in business it is.When evaluating this project, we tried first with agreement, but didn't do as needed. With contract states, a draft state is not yet sent, pending is awaiting signature, open, suspended, rejected, terminated all self explanatory. Really all else we did was add terms text to contracts and it largely covered the agreement parts off that were needed.Bits we need to tidy up, contract has a kind of all or nothing approach to line based vs contract based billing. In practice we find it is the lines that drive what is billed, start dates, stop dates and contracts that drive when it is billed. Also, there is no nice proration in the invoicing function. But it seems very accessible so we should have that written next week.There is a lot of work we can extract and share, and lots of things I haven't added here.On Sat, Feb 25, 2023 at 11:56 AM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:I don't know any cases of "supplier"contracts either... The logic for me states that a supplier contract is managed by the supplier. I don't see benefit in making recurring supplier invoices since supplier invoices are loaded in the system in other workflows. At least from what I saw, I never saw "supplier contracts" in any system.On Fri, Feb 24, 2023 at 2:02 PM Raphaël Reverdy <notifications@odoo-community.org> wrote:Hi,Does anyone have a real use case with a supplier contract ?I have the feeling supporting this use case adds a lot of complexity on the contract module.Good idea to refactor / split this contract module.Regards,Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.> In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like:States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active.This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view.Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier.And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR.Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread.Regards and good week for all of you!El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:> - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94> I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering.Indeed, this can be improved.> - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters.Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110> - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module.This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.> - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality.This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).I hope this answered your questions.Regards,On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions.
I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others.I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me.From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here:- Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.- I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering.- There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters.- There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module.- Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce.- Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts.- I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality.If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it.Regards and i want for your thoughts._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Raphaël ReverdyMobile +33 6 38 02 03 93Fixe +33 4 82 53 84 60_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Graeme Gellatly - 08:11 - 25 Feb 2023 -
Re: OCA Contract Repository
I don't know any cases of "supplier"contracts either... The logic for me states that a supplier contract is managed by the supplier. I don't see benefit in making recurring supplier invoices since supplier invoices are loaded in the system in other workflows. At least from what I saw, I never saw "supplier contracts" in any system.On Fri, Feb 24, 2023 at 2:02 PM Raphaël Reverdy <notifications@odoo-community.org> wrote:Hi,Does anyone have a real use case with a supplier contract ?I have the feeling supporting this use case adds a lot of complexity on the contract module.Good idea to refactor / split this contract module.Regards,Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.> In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like:States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active.This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view.Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier.And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR.Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread.Regards and good week for all of you!El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:> - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94> I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering.Indeed, this can be improved.> - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters.Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110> - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module.This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.> - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality.This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).I hope this answered your questions.Regards,On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions.
I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others.I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me.From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here:- Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.- I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering.- There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters.- There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module.- Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce.- Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts.- I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality.If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it.Regards and i want for your thoughts._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Raphaël ReverdyMobile +33 6 38 02 03 93Fixe +33 4 82 53 84 60_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Nicolas Rodriguez Sande - 11:56 - 24 Feb 2023 -
Re: OCA Contract Repository
Hello Raphael, this is also used for Suppliers.You can use it for Suppliers contracts that Bill you monthly, and help you know the expected expenses.But splitting complexity into a separate module sounds good ro me.A sexta, 24/02/2023, 17:02, Raphaël Reverdy <notifications@odoo-community.org> escreveu:Hi,Does anyone have a real use case with a supplier contract ?I have the feeling supporting this use case adds a lot of complexity on the contract module.Good idea to refactor / split this contract module.Regards,Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.> In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like:States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active.This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view.Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier.And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR.Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread.Regards and good week for all of you!El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:> - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94> I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering.Indeed, this can be improved.> - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters.Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110> - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module.This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.> - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality.This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).I hope this answered your questions.Regards,On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:
Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions.
I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others.I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me.From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here:- Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.- I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering.- There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters.- There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module.- Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce.- Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts.- I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality.If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it.Regards and i want for your thoughts._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Raphaël ReverdyMobile +33 6 38 02 03 93Fixe +33 4 82 53 84 60_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Daniel Reis - 09:35 - 24 Feb 2023 -
Re: OCA Contract Repository
Hi,Does anyone have a real use case with a supplier contract ?I have the feeling supporting this use case adds a lot of complexity on the contract module.Good idea to refactor / split this contract module.Regards,Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.> In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like:States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active.This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view.Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier.And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR.Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread.Regards and good week for all of you!El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:> - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94> I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering.Indeed, this can be improved.> - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters.Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110> - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module.This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.> - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality.This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).I hope this answered your questions.Regards,On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions.
I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others.I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me.From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here:- Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.- I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering.- There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters.- There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module.- Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce.- Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts.- I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality.If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it.Regards and i want for your thoughts._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Raphaël ReverdyMobile +33 6 38 02 03 93Fixe +33 4 82 53 84 60
by Raphaël Reverdy - 06:01 - 24 Feb 2023 -
Re: Module to bulk select products to Transfer
Thank you so much Denis.
That looks like exactly what I need, I guess I didn't dig enough into the available modules :-)
/Daniel
On 23/02/2023 09:57, Roussel, Denis wrote:
Hi Daniel,
Have you tested this one : https://github.com/OCA/stock-logistics-warehouse/tree/16.0/stock_move_location ?
On Thu, Feb 23, 2023 at 10:52 AM Daniel Reis <notifications@odoo-community.org> wrote:
Hello,
I wonder if someone worked on a similar need:
We are doing stock internal transfers, and would like to be able to select all the contents of the source location to the picking lines.
A use case is where the Source Location is a Truck, and you want to unload (transfer) the content of the truck to another location.
My target version is v16.
Thank you
Daniel
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
Atrium Building, Drève Richelle 167 | B-1410 Waterloo | BelgiumZone industrielle 22 | L-8287 Kehlen | Luxembourg
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Daniel Reis - 01:46 - 23 Feb 2023
