Skip to Content
  2. Mailing Lists
  3. Contributors

Archives

Contributors

  • Repos update
    Hi everyone,

    I launched an update of all repos (branches 12 - 16) to apply the latest repo template.

    PSCs, your help may be needed to handle cases where a manual intervention is required. Look for PRs with title dotfiles update needs manual intervention.

    These are mostly due to manual updates to files otherwise generated from the template. We should try to avoid them as much as possible, so if you really need some manual changes, please open an issue on github.com/oca/oca-addons-repo-template to discuss adding options to the template.

    Best regards,

    -Stéphane

    by Stéphane Bidoul - 09:20 - 12 Mar 2023

    1 replies 1 replies

  • Weblate certificate is expired
    Hello,

    The website https://translation.odoo-community.org/ is not working because the certificate is expired.


    by "Jesús Alan Ramos Rodríguez" <alan.ramos@jarsa.com> - 08:30 - 11 Mar 2023

    4 replies 4 replies

  • New thread: Odoo & Clean architectures
    by Fernando La Chica - 03:06 - 11 Mar 2023
  • Copier template for bootstrapping a new module
    Hi friends!

    We were a bit bored of copying https://github.com/OCA/maintainer-tools/tree/master/template/module and modifying all stuff. And odoo scaffold is not so good...


    See its readme to know how to bootstrap a new module from scratch. It includes all standards from https://github.com/OCA/maintainer-tools (actually I copied the whole module template from there, with commit history included).

    We can donate the template to OCA if you consider it interesting, or otherwise just use it freely. MRs welcome, as usual!

    Happy weekend everybody.
    by Jairo Llopis - 02:56 - 10 Mar 2023

    1 replies 1 replies

  • Weblate - increase the operation limit before locking
    Hi all,
    sometime I have time to translate on OCA Weblate.
    Normally I choose a repository and complete all modules starting from the last version available.
    Because this mode to operate is quite fast due to the repetition of the terms, I hoften incour on the blocking message because I did too much operations.
    This situation is frequent when you add new module, as if doing this weight more than adding single translations.
    Someone know if there is a way to increase the limit of the operations, maybe at user level?

    Thanks in advance

    Stefano Consolaro
    www.mymage.it
    by Stefano Consolaro - 08:21 - 9 Mar 2023
  • Proposing jbaudoux as PSC for stock*/wms
    Hello,

    It has been quite some years now that I've been working on the design, roadmap & review of the logistics stack in the OCA.
    I'm happy the user base is growing and many contributors are helping to improve the features over the years. I'm involved as architect on more and more logistics projects with several odoo integrators and this allows us to continuously enhance the stack while keeping it the most generic.
    We have done many improvements the last months on v14 & v16. And, in parallel, since a few months now, we have also started the process of migrating a lot of modules to v16.

    I'd like to have the role of PSC on all the logistics repositories. I would also like to participate in the merging process of the approved modules.

    Kind regards
    Jacques-Etienne Baudoux
    github: jbaudoux
    by Jacques-Etienne Baudoux - 12:46 - 9 Mar 2023

    10 replies 10 replies

  • Some repositories cannot save translations
    Dear all,

    I want to translate the stock_request module of the stock_logistic_warehouse repository, but it displays "Insufficient privileges for saving translations" and I cannot save the translation.

    But I've emailed transbot@odoo-community.org and I have been added to the Japanese translation group.  And I can save translations if they are in other repositories (For example, a commission repository.).

    What is the difference? And how can I translate the stock_logistic_warehouse repository?

    Also maybe I should put this question on the translation mailing list but I can't find the translation mailing list. (I looked for OCA web page > News&Update > Mailing lists and I can find only a contributor mailing list)
    How can I join the translation mailing list?

    Thank you.
    by Tatsuki Kanda - 02:35 - 8 Mar 2023
  • New repo proposal: edi-framework
    Hi all,

    As mentioned during my talk at OCA days, I'd like to move the EDI framework to its own repo.
    Main reasons:

    1. OCA/edi is getting crowded
    2. clearly separate generic EDI modules from the framework itself

    Thoughts?
    Bests,
    S

    --
    Simone Orsi

    Full stack Python web developer, Odoo specialist, Odoo Community Board Member, in love with open source.
    by Simone Orsi - 06:45 - 2 Mar 2023

    7 replies 7 replies

  • Proposal: add a forum
    Hello! I want to propose something I hope will help everybody communicate better :)

    Many of you might have notice that since long ago Github includes a discussions feature that can be enabled per repo.

    Since not-so-long ago, there's a possibility to enable discussions for a whole organization. The implementation is rather simple: just select one repo from the org that becomes the "main forum repo".

    Communicating through mailing lists looks very old-fashioned these days. 🧓 Every decent community has a decent forum, be it discourse or github discussions or whatever.

    IMHO the best solution would be:
    1. Create a new repo. We can call it "community" or "oca-forum" or "oca-discuss"... you name it
    2. PSC for this repo would be community moderators. Maybe a new PSC group?
    3. Set it as main discussion repo, organization-wide.
    4. Gradually deprecate the mailing list.
    Benefits of this approach:
    1. Look more modern.
    2. We can edit answers.
    3. We can put polls.
    4. We don't need to send mails with +1.
    5. We can link to comments.
    6. Community discussion more close to where the community actually works.
    7. Less things to maintain in odoo-community.org
    That doesn't mean we can't enable discussions for specific repos, to become more focused, just like it's done in OpenUpgrade. But at least we have a general place to talk asynchronously about general stuff, just like we have the Matrix/Discord community for synchronous communication.

    WDYT?
    by Jairo Llopis - 10:15 - 1 Mar 2023

    10 replies 10 replies

  • pre-commit will fail from today unless you update the templates
    Hi community!

    I just wanted to announce that I just released https://github.com/OCA/oca-addons-repo-template/releases/tag/v1.14.2

    If When you see pre-commit going nuts from today, please update the repo to the latest version of the template to fix it.

    Have a nice day!
    by Jairo Llopis - 10:06 - 1 Mar 2023

    3 replies 3 replies

  • Proposing myself as PSC for community-maintainers
    Hello everybody! I hope you're doing well.

    I'd like to become PSC in community-maintainers repos.

    This is my github profile, for those that don't know me: https://github.com/yajo

    I'm very active in packaging, solving pre-commit issues, and I maintain the copier template and copier itself. I have years of experience and community engagement.

    Thanks!
    by Jairo Llopis - 09:15 - 1 Mar 2023

    13 replies 13 replies

  • Payroll 15.0 PR review request

    Hello contributors

    My name is Ivan Candelas from Guadalajara Mexico. 
    I have almost 20 years of experience in ERP implementations, mainly in manufacturing, payroll and HR modules, I have been working with odoo for a few years as an implementer and freelance programmer.

    I look forward to actively contributing to the OCA modules. 
    Also I'd like to request a PR review https://github.com/OCA/payroll/pull/119 of the payroll module for the 15.0 branch

    Iván Candelas
    by Ivan Candelas - 05:15 - 27 Feb 2023
  • Module to bulk select products to Transfer
    Hello,

    I wonder if someone worked on a similar need:

    We are doing stock internal transfers, and would like to be able to select all the contents of the source location to the picking lines.
    A use case is where the Source Location is a Truck, and you want to unload (transfer) the content of the truck to another location.
    My target version is v16.


    Thank you
    Daniel
    by Daniel Reis - 10:50 - 23 Feb 2023

    2 replies 2 replies

  • Odoo calendar <-> outlook calendar sync 
    Hello,
We have a customer using native odoo synchronization between outlook calendar
and odoo calendar.

But since 2 month, the following warning has be added to the odoo documentation
<https://www.odoo.com/documentation/15.0/applications/general/calendars/outlook/outlook_calendar.html?highlight=outlook>
      Warning

      Odoo highly recommends testing the Outlook calendar synchronization
      on a test database and a test email address (that is not used for
      any other purpose) before attempting to sync the desired Outlook
      Calendar with the user’s production database.
      If the user has any past, present, or future events on their Odoo
      calendar before syncing their Outlook calendar, Outlook will treat
      the events pulled from Odoo’s calendar during the sync as new
      events, causing an email notification to be sent from Outlook to all
      the event attendees.
      To avoid unwanted emails being sent to all past, present, and future
      event attendees, the user must add the events from the Odoo calendar
      to the Outlook calendar before the first ever sync, delete the
      events from Odoo, and then start the sync.
      Even after synchronizing the Odoo Calendar with the Outlook
      calendar, Outlook will still send a notification to all event
      participants every time an event is edited (created, deleted,
      unarchived, or event date/time changed), with no exceptions. This is
      a limitation that cannot be fixed from Odoo’s side.
      After one user syncs their Outlook calendar to the Odoo database,
      unwanted email notifications are unavoidable because the first
      synchronized user’s events will be in the Odoo Calendar. If the Odoo
      database is shared amongst multiple users, and another user wants to
      sync their Outlook calendar with Odoo Calendar, Outlook will again
      pull the existing Odoo Calendar events during the sync and treat
      them as new events, causing Outlook to send email invitations to all
      event attendees.

      In summary, once a user synchronizes their Outlook calendar with the
      Odoo calendar:
          Creating an event in Odoo causes Outlook to send an invitation
          to all event attendees.
          Deleting an event in Odoo causes Outlook to send a cancellation
          to all event attendees.
          Unarchiving an event in Odoo causes Outlook to send an
          invitation to all event attendees.
          Archiving an event in Odoo causes Outlook to send a cancellation
          to all event attendees.
          Adding a contact to an event causes Outlook to send an
          invitation to all event attendees.
          Removing a contact from an event causes Outlook to send a
          cancellation to all event attendees.

And indeed, the synchronization has became unusable because of all the
invitations sent to all event attendees in outlook.

Odoo doesn't seem to address the problem, do you know any module that would work
properly to sync the calendars?

Regards
Simon


--
    by simon - 02:31 - 22 Feb 2023

    1 replies 1 replies

    • Re: Odoo calendar <-> outlook calendar sync 
      I think this issue was fixed last week in 
https://github.com/odoo/odoo/commit/86862f2527341247b75df155de16b09d44a7eee6

Alexandre

On 22/02/2023 14:32, Simon Pessemesse wrote:

> Hello,

> We have a customer using native odoo synchronization between outlook calendar

> and odoo calendar.

> 

> But since 2 month, the following warning has be added to the odoo documentation

> <https://www.odoo.com/documentation/15.0/applications/general/calendars/outlook/outlook_calendar.html?highlight=outlook>

>        Warning

> 

>        Odoo highly recommends testing the Outlook calendar synchronization

>        on a test database and a test email address (that is not used for

>        any other purpose) before attempting to sync the desired Outlook

>        Calendar with the user’s production database.

>        If the user has any past, present, or future events on their Odoo

>        calendar before syncing their Outlook calendar, Outlook will treat

>        the events pulled from Odoo’s calendar during the sync as new

>        events, causing an email notification to be sent from Outlook to all

>        the event attendees.

>        To avoid unwanted emails being sent to all past, present, and future

>        event attendees, the user must add the events from the Odoo calendar

>        to the Outlook calendar before the first ever sync, delete the

>        events from Odoo, and then start the sync.

>        Even after synchronizing the Odoo Calendar with the Outlook

>        calendar, Outlook will still send a notification to all event

>        participants every time an event is edited (created, deleted,

>        unarchived, or event date/time changed), with no exceptions. This is

>        a limitation that cannot be fixed from Odoo’s side.

>        After one user syncs their Outlook calendar to the Odoo database,

>        unwanted email notifications are unavoidable because the first

>        synchronized user’s events will be in the Odoo Calendar. If the Odoo

>        database is shared amongst multiple users, and another user wants to

>        sync their Outlook calendar with Odoo Calendar, Outlook will again

>        pull the existing Odoo Calendar events during the sync and treat

>        them as new events, causing Outlook to send email invitations to all

>        event attendees.

> 

>        In summary, once a user synchronizes their Outlook calendar with the

>        Odoo calendar:

>            Creating an event in Odoo causes Outlook to send an invitation

>            to all event attendees.

>            Deleting an event in Odoo causes Outlook to send a cancellation

>            to all event attendees.

>            Unarchiving an event in Odoo causes Outlook to send an

>            invitation to all event attendees.

>            Archiving an event in Odoo causes Outlook to send a cancellation

>            to all event attendees.

>            Adding a contact to an event causes Outlook to send an

>            invitation to all event attendees.

>            Removing a contact from an event causes Outlook to send a

>            cancellation to all event attendees.

> 

> And indeed, the synchronization has became unusable because of all the

> invitations sent to all event attendees in outlook.

> 

> Odoo doesn't seem to address the problem, do you know any module that would work

> properly to sync the calendars?

> 

> Regards

> Simon

> 

> -- 

> 

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 

> <https://odoo-community.org/groups/contributors-15>

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe 

> <https://odoo-community.org/groups?unsubscribe>

> 


-- 
Alexandre Fayolle
Senior Software Engineer
Tel : +33 4 58 48 20 30

Camptocamp France SAS
18 rue du Lac Saint André
73 370 Le Bourget-du-Lac
France

http://www.camptocamp.com
      by Alexandre Fayolle - 02:40 - 22 Feb 2023
  • write access to repositories for oca-git-bot

    hello,

    maybe this is documented somewhere but i could not find the information.

    for the /ocabot rebase command to work, oca-git-bot needs write access to the repository that contains the branch. without it, it fails like this:

    The rebase process failed, because command git push --force coopiteasy tmp-pr-40:12.0-cooperator_website_add_validation_hook failed with output: 

    remote: Permission to coopiteasy/cooperative.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/cooperative/': The requested URL returned error: 403

    how is this supposed to be handled? should oca-git-bot be part of our github organization? i invited it, thinking that maybe it auto-accepts invites, but nothing changed.

    what should i do?

    cheers,

    hugues
    coop it easy

    by hugues - 11:51 - 22 Feb 2023

    3 replies 3 replies

    • Re: write access to repositories for oca-git-bot
      I'm afraid it's not anything about checking that field or not, but GitHub avoids the push to organization branches. We don't know the reason, but there's nothing in our hands that we can do about that.

      But the good news is that the `/ocabot merge ...` command performs a rebase on the merge branch.

      Regards.
      by Pedro M. Baeza - 08:20 - 23 Feb 2023
    • Re: write access to repositories for oca-git-bot
      Yes the access is denied because the option o allow or not maintainers to push to PRs branch. 

      Anyways, the allow maintainers to push to the branch option is enabled by default and a lot of people leave it enabled, so the rebase command continue being useful for those cases. 

      Maybe a solution for this is to create a new command on the push level, like: 

      /ocabot merge patch —rebase 

      So the bot can rebase the PR when creating the merge branch so it don’t need access to PR repository. What do you think? 

      El El mié, 22 de feb. de 2023 a la(s) 08:06, Stéphane Bidoul <notifications@odoo-community.org> escribió:
      Hi Hugues,

      Last time I checked it was not possible for organizations to allow maintainers to push to their PRs. It was only possible for individual contributors.

      So this effectively limits the usefulness of the /ocabot rebase command.

      Best regards,

      -sbi


      On Wed, Feb 22, 2023 at 11:57 AM hugues de keyzer <notifications@odoo-community.org> wrote:

      hello,

      maybe this is documented somewhere but i could not find the information.

      for the /ocabot rebase command to work, oca-git-bot needs write access to the repository that contains the branch. without it, it fails like this:

      The rebase process failed, because command git push --force coopiteasy tmp-pr-40:12.0-cooperator_website_add_validation_hook failed with output: 

      remote: Permission to coopiteasy/cooperative.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/cooperative/': The requested URL returned error: 403

      how is this supposed to be handled? should oca-git-bot be part of our github organization? i invited it, thinking that maybe it auto-accepts invites, but nothing changed.

      what should i do?

      cheers,

      hugues
      coop it easy

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Nicolas Rodriguez Sande - 01:36 - 23 Feb 2023
    • Re: write access to repositories for oca-git-bot
      Hi Hugues,

      Last time I checked it was not possible for organizations to allow maintainers to push to their PRs. It was only possible for individual contributors.

      So this effectively limits the usefulness of the /ocabot rebase command.

      Best regards,

      -sbi


      On Wed, Feb 22, 2023 at 11:57 AM hugues de keyzer <notifications@odoo-community.org> wrote:

      hello,

      maybe this is documented somewhere but i could not find the information.

      for the /ocabot rebase command to work, oca-git-bot needs write access to the repository that contains the branch. without it, it fails like this:

      The rebase process failed, because command git push --force coopiteasy tmp-pr-40:12.0-cooperator_website_add_validation_hook failed with output: 

      remote: Permission to coopiteasy/cooperative.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/coopiteasy/cooperative/': The requested URL returned error: 403

      how is this supposed to be handled? should oca-git-bot be part of our github organization? i invited it, thinking that maybe it auto-accepts invites, but nothing changed.

      what should i do?

      cheers,

      hugues
      coop it easy

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Stéphane Bidoul - 12:06 - 22 Feb 2023
  • As Odoo family, please donate for the disasters in Türkiye
    Dear Fabien, 

    Turkey has recently been struck by a devastating earthquake with a magnitude of 7.8. The impact has been widespread and many communities have been severely affected. In this difficult time, we are reaching out to ask for your support. Any donation, no matter how small, will help us provide much-needed aid to those affected by the earthquake. Your generosity will help provide shelter, food, and medical supplies to those in need. If you would like to make a donation, at the buttom we shared IBAN information for contribution. Your contribution will make a real difference in the lives of those affected by this disaster. 

    Thank you for your kindness and support.



    İsmail ESKİ
    Software Developer

    Projet Yazılım ve Danışmanlık A.Ş. 
    Tel: +90 850 520 00 18
    www.projetgrup.com

    by "İsmail Eski" <ismaile@projetgrup.com> - 06:06 - 10 Feb 2023

    2 replies 2 replies

  • OCA Contract Repository

    Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


    I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

    I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

    From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

    - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

    - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

    - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

    - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

    - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

    - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

    - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

    If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

    Regards and i want for your thoughts. 
    by Nicolas Rodriguez Sande - 05:55 - 10 Feb 2023

    6 replies 6 replies

    • Re: OCA Contract Repository
      Hi,

      We have nearly completed an extensive contract project integrating contract/project/accounting/sale/purchase/schedules/field service. All in it is about 30k lines replacing 100k lines of prior custom code for a janitorial organisation.

      Random assortment of Notes.
      Supplier Contracts - used in order to communicate back to back service agreements for certain services on customer contracts. Suspensions, modifications etc. But in truth, we did that because we could.
      Contract Name - maybe an onchange, but some concerns with computing. The case here is that the name is an internal reference/common name used widely in online and offline conversation.
      Contract States - added, computed based on modifications.
      Margins - added in style of sale_margin module.
      Sale Commissions Management.
      Point in time revenue - can view contract (or list of contracts) value based on state at given date in future or past (contract has auto pricing so value can differ, also modifications)

      Portal Views - we completely rewrote in the style of sale order and added signatures.
      Modifications - Underrated, undeveloped feature IMO. We added extensively to record approvals, signatures and manage line and contract state. Different types of modifications trigger different actions/activities/communications.

      Contract Lines - distinction between regular recurring items (e.g. Window Cleaning) and As Required items (toilet paper, fridge clean out).

      Grouping and defaults is kind of provided if you use contract templates.

      I personally don't see the link between an agreement and contract. I never worked out why they are in the same repo. A contract IS an agreement, and while I accept that an agreement is not always a contract, in practice, in business it is.

      When evaluating this project, we tried first with agreement, but didn't do as needed. With contract states, a draft state is not yet sent, pending is awaiting signature, open, suspended, rejected, terminated all self explanatory. Really all else we did was add terms text to contracts and it largely covered the agreement parts off that were needed.

      Bits we need to tidy up, contract has a kind of all or nothing approach to line based vs contract based billing. In practice we find it is the lines that drive what is billed, start dates, stop dates and contracts that drive when it is billed. Also, there is no nice proration in the invoicing function. But it seems very accessible so we should have that written next week.

      There is a lot of work we can extract and share, and lots of things I haven't added here.

      On Sat, Feb 25, 2023 at 11:56 AM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:
      I don't know any cases of "supplier"contracts either... The logic for me states that a supplier contract is managed by the supplier. I don't see benefit in making recurring supplier invoices since supplier invoices are loaded in the system in other workflows. At least from what I saw, I never saw "supplier contracts" in any system.

      On Fri, Feb 24, 2023 at 2:02 PM Raphaël Reverdy <notifications@odoo-community.org> wrote:
      Hi,

      Does anyone have a real use case with a supplier contract ?

      I have the feeling supporting this use case adds a lot of complexity on the contract module.


      Good idea to refactor / split this contract module.

      Regards,





      Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Raphaël Reverdy
      Mobile +33 6 38 02 03 93
      Fixe +33 4 82 53 84 60

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Graeme Gellatly - 08:11 - 25 Feb 2023
    • Re: OCA Contract Repository
      I don't know any cases of "supplier"contracts either... The logic for me states that a supplier contract is managed by the supplier. I don't see benefit in making recurring supplier invoices since supplier invoices are loaded in the system in other workflows. At least from what I saw, I never saw "supplier contracts" in any system.

      On Fri, Feb 24, 2023 at 2:02 PM Raphaël Reverdy <notifications@odoo-community.org> wrote:
      Hi,

      Does anyone have a real use case with a supplier contract ?

      I have the feeling supporting this use case adds a lot of complexity on the contract module.


      Good idea to refactor / split this contract module.

      Regards,





      Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Raphaël Reverdy
      Mobile +33 6 38 02 03 93
      Fixe +33 4 82 53 84 60

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Nicolas Rodriguez Sande - 11:56 - 24 Feb 2023
    • Re: OCA Contract Repository
      Hello Raphael, this is also used for Suppliers.

      You can use it for Suppliers  contracts that Bill you monthly, and help you know the expected expenses.

      But splitting complexity into a separate module sounds good ro me.

      A sexta, 24/02/2023, 17:02, Raphaël Reverdy <notifications@odoo-community.org> escreveu:
      Hi,

      Does anyone have a real use case with a supplier contract ?

      I have the feeling supporting this use case adds a lot of complexity on the contract module.


      Good idea to refactor / split this contract module.

      Regards,





      Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Raphaël Reverdy
      Mobile +33 6 38 02 03 93
      Fixe +33 4 82 53 84 60

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Daniel Reis - 09:35 - 24 Feb 2023
    • Re: OCA Contract Repository
      Hi,

      Does anyone have a real use case with a supplier contract ?

      I have the feeling supporting this use case adds a lot of complexity on the contract module.


      Good idea to refactor / split this contract module.

      Regards,





      Le jeu. 23 févr. 2023 à 01:53, Nicolas Rodriguez Sande <notifications@odoo-community.org> a écrit :
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Raphaël Reverdy
      Mobile +33 6 38 02 03 93
      Fixe +33 4 82 53 84 60
      by Raphaël Reverdy - 06:01 - 24 Feb 2023
    • Re: OCA Contract Repository
      Hello! Thanks for your response Denis. I Just go back from vacation so I think next week I will start working on contract module.

      > In fact, the state is managed on line level, see https://github.com/OCA/contract/blob/14.0/contract/models/contract_line.py#L94

      Okay so, if state is managed in line level, will it make sense to make a computed contract level state that is based on line state? Because I think that for the user, they will expect contract to have a state, even some lines have different states we can make some logic to compute a state based on all lines states. Something like: 

      States: “active”, “canceled”, “closed” can be computed based on lines. “Active” can be the contract state when at least one line is active, “Canceled” when all lines are canceled and “closed” when all lines closed. If we have mixed situations like some lines canceled and some active, we can still show active. 

      This will allow the user to easily filter contracts without having to enter each contract to see lines. Or maybe we have to make a contract lines view. 

      Next week I will be with this project and open some PRs to see what people think, also make the view improvements that will make sure life easier. 

      And yes, base_conteact was just an idea but the point is to have more smaller and maintainable modules that plug-in functionalities, that’s always the easiest way to have a user-specific implementation without having a lot of functionalities that won’t be user by all users. Will try to open the issue next week to discuss this and also review the link between agreements and contracts PR. 

      Please if another people have more ideas/problems/suggestions to contract module, feel free to reply this thread. 

      Regards and good week for all of you! 



      El El mié, 15 de feb. de 2023 a la(s) 06:17, Roussel, Denis <notifications@odoo-community.org> escribió:
      > - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.


      >  I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      Indeed, this can be improved.

      > - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      Maybe adding a 'contract.category' model could be great (in another module ?). But, for the time being, this can be done through contract tags. See: https://github.com/OCA/contract/blob/14.0/contract/models/contract.py#L110

      > - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      This is still tested in a draft PR: https://github.com/OCA/contract/pull/649 You can review it and make suggestions.

      > - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      This module has indeed a big history, refactored on 12.0 version I think. Since, some improvements have been done (refactoring on recurrency computations by Pedro see: https://github.com/OCA/contract/pull/533/commits/cd086ddbb4a9b85ccfcac288e53fb93e716d9446)

      Indeed, I think it has now a very complex implementation that makes user understanding (and debugging) difficult.

      We could make an issue on the github repository to help gathering ideas and focus discussion there than on this mailing list. But I agree that we could split some logic in separate modules (with meaningful names - if we could avoid base_contract).

      I hope this answered your questions.


      Regards,


      On Fri, Feb 10, 2023 at 5:57 PM Nicolas Rodriguez Sande <notifications@odoo-community.org> wrote:

      Hello, I’m writing to know your opinion about the contract repository. I started to use the modules in the repository and noted that the module versions of contract module differ a lot between odoo versions. 


      I have to do some implementations regarding that modules so I’m going to start making PRs to that repo and try to improve the modules starting in version 14.0 and then port it to the others. 

      I want to have your opinions on things you can tell me about what is missing in the modules and so I can organize my roadmap. Also, I don’t know if there are currently active PSC of the module, if not or you want me to join the team I will be interested, because I need to improve the modules and if that can help the development of the repo, count with me. 

      From what I saw, I see the following issues to solve, please if you know another issues or want to make an opinion of changes you would like to see in the module please comment me here: 

      - Contract objects don’t have states. It appears to me that in some versions states existed but is a functionality that was dropped and some point. I strongly think that a module like this must have states.

      - I think the name of the contract should be computed, or at least use a sequence. I don’t see the point of the name to be manually edited. Having a computed one will help with search and filtering. 

      - There is not grouping entity of contract objects. Meaning we don't have an easy way to group contracts by category or an hicherarchical structure. I think this is useful for usability and to set default parameters. 

      - There is not link between contracts and agreement modules. My common sense dict that a contract should be created from an agreement, meaning that an agreement is a legal contract and when approved and signed, it creates a contract record which defines invoicing schedule. If not, i really don't see any use for agreements if they are not linked. Maybe this can be solved with a new module. 

      - Contract views are awful and need to be improved to favor user usability and comprehension of the module mechanics and uses. This is one of the first changes i want to introduce. 

      - Contract reports and portal views need to be improved. Currently the contract report is not so much developed. Also could be a good idea to allow to see agreements from portal contracts. 

      - I think all codebase should be refactored and maybe split the contract module to have one base_contract with basic functionality for simple cases and then other modules to plug-in more functionality. 

      If you have more opinions and things you want to see in a roadmap, please tell me here and i can maybe add it to my next PRs. Also if you have opinions of how the module should work will be great for when we refactor it. 

      Regards and i want for your thoughts. 

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Zone industrielle 22 | L-8287 Kehlen | Luxembourg

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Nicolas Rodriguez Sande - 01:51 - 23 Feb 2023

  • Pricelist sale price on form
    Hello, 

    I would like to be able to show sales price in pricelist items form.

    Very similar task to this module (only available for odoo13 at the moment) https://odoo-community.org/shop/product-list-pricelist-price-6617#attr=12054, but this one does the job in the product template tree-view. 

    We would need the same one in the product pricelist item form. 
    I need it for odoo14 but I can consider modules for other version is there is one available but not available for 14 (could try to perform a migration in some cases).

    Thank you in advance. Regards,

    Francesco Ballerini

     


    by Francesco Ballerini - 10:20 - 8 Feb 2023

    11 replies 11 replies

  • module to publish on social networks
    Hi there,

    Do you know any OpenSource module effort on social areas that allows to schedule post on facebook/linkedin/... linked somehow with marketing campaigns?

    I would be pleased to help. If needs I could migrate such a module to version 14.0.

    Regards,
    --
    Pierre Verkest
    06 81 12 25 20
    Github: petrus-v - Twitter: petrusv84 - Linkedin: pierre-verkest
    by Pierre Verkest - 09:36 - 8 Feb 2023

    3 replies 3 replies

  • Website - download content
    Hi

    Have a prospect that wants website users to be able to download content in the form of PDF or PPT files, possibly grouped into categories or themes. Which module would be a good fit for that?

    Also is there like a module for a photo album/slideshow? They have quite a few historical photos they want to display.


    Torvald Baade Bringsvor
    Bringsvor Consulting AS - Developer, consultant, allrounder

    Tel (+47) 4548 2848
    by Torvald Bringsvor - 02:06 - 2 Feb 2023

    5 replies 5 replies

    • Re: Website - download content
      Thanks guys. Some interesting suggestions to follow up on.


      Torvald Baade Bringsvor
      Bringsvor Consulting AS - Developer, consultant, allrounder

      Tel (+47) 4548 2848


      On Thu, Feb 2, 2023 at 8:36 PM Pedro M. Baeza <notifications@odoo-community.org> wrote:
      On OCA/dms you can upload files and organize by folders, and then share what you want, or give access to portal users with a convenient portal view:

      Selección_043.png

      I think images are not seen, so I sent a link to  the shared image: https://postimg.cc/BX6GGH99


      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Torvald Bringsvor - 10:16 - 3 Feb 2023
    • Re: Website - download content
      On OCA/dms you can upload files and organize by folders, and then share what you want, or give access to portal users with a convenient portal view:

      Selección_043.png

      I think images are not seen, so I sent a link to  the shared image: https://postimg.cc/BX6GGH99


      Regards.
      by Pedro M. Baeza - 08:36 - 2 Feb 2023

      1 attachments 1 attachments

      Selección_043.png
    • Re: Website - download content

      Hi,

      Here at Coop IT Easy, we have developped a module named document_hosting that seams to do what you are looking for.

      https://github.com/coopiteasy/addons/tree/12.0/document_hosting

      It let you upload documents (any type) with the backend interface. You can group them by categories. You can set if the document is public or not.

      On the website there is an url which display the public documents for unconnected users and also the "private" document for connected users.

      It is used on production for BEES coop, Brussels, Belgium : https://gestion.bees-coop.be/documents

      This module needs documentation (readme is empty) and if you find it interesting, it would be nice to put it somewhere on an OCA repository (don't know which one is the best).
      Also, small screen design of the web page can be improved but it's fuctionnal.

      This module may also need to be migrated on newer odoo version (12.0 for the moment).

      The slide show option that you requested may be done by simply creating a new page with a new design by extending this module. Images can by uploaded like other documents via the admin interface.

      Best regards,

      Le 2 février 2023 14:07:40 GMT+01:00, Torvald Baade Bringsvor <notifications@odoo-community.org> a écrit :
      Hi

      Have a prospect that wants website users to be able to download content in the form of PDF or PPT files, possibly grouped into categories or themes. Which module would be a good fit for that?

      Also is there like a module for a photo album/slideshow? They have quite a few historical photos they want to display.


      Torvald Baade Bringsvor
      Bringsvor Consulting AS - Developer, consultant, allrounder

      Tel (+47) 4548 2848

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      --
      Rémy Taymans
      Coop IT Easy
      https://coopiteasy.be
      by Rémy Taymans - 08:26 - 2 Feb 2023
    • Re: Website - download content
      hello! 
      I would use E-Learning

      Daniel C.


      El jue, 2 feb 2023 a las 9:27, adyson10 (<notifications@odoo-community.org>) escribió:
      This is possible on enterprise is the documents module is installed


      Andy

      On 2 Feb 2023 13:07, Torvald Baade Bringsvor <notifications@odoo-community.org> wrote:
      Hi

      Have a prospect that wants website users to be able to download content in the form of PDF or PPT files, possibly grouped into categories or themes. Which module would be a good fit for that?

      Also is there like a module for a photo album/slideshow? They have quite a few historical photos they want to display.


      Torvald Baade Bringsvor
      Bringsvor Consulting AS - Developer, consultant, allrounder

      Tel (+47) 4548 2848

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe


      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by DANIEL CARRION - 05:06 - 2 Feb 2023
    • Re: Website - download content
      This is possible on enterprise is the documents module is installed


      Andy

      On 2 Feb 2023 13:07, Torvald Baade Bringsvor <notifications@odoo-community.org> wrote:
      Hi

      Have a prospect that wants website users to be able to download content in the form of PDF or PPT files, possibly grouped into categories or themes. Which module would be a good fit for that?

      Also is there like a module for a photo album/slideshow? They have quite a few historical photos they want to display.


      Torvald Baade Bringsvor
      Bringsvor Consulting AS - Developer, consultant, allrounder

      Tel (+47) 4548 2848

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe


      by Andy Dyson - 03:25 - 2 Feb 2023