Archives
Contributors
-
Re: Attachments via S3?
No stress @Miku.. just wanted to point out that if we want to make open source sustainable, it's always good to give back the improvements made on the work of others . I know it's not always easy and I don't question at all your commitment into the Opensource values. My comment is meant to be friendly ;-)lmignonOn Fri, Mar 13, 2020 at 9:02 AM Miku Laitinen <miku@avoin.systems> wrote:Found the PR: https://github.com/itpp-labs/misc-addons/pull/712I'd facepalm right now, but we're not supposed to touch our faces :) It's for a different repository and a different module. My bad. I will open a PR today.Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Fri, Mar 13, 2020 at 9:50 AM Miku Laitinen <miku@avoin.systems> wrote:Laurent, I could've sworn that I made a pull request but it wasn't accepted because "it was out of scope" of this module. But now I can't find that pull request. If you would accept these changes, I'd be happy to contribute.Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Fri, Mar 13, 2020 at 9:47 AM Mignon, Laurent <laurent.mignon@acsone.eu> wrote:Miku,Nice to see that you've extended the C2C addon to support Minio. It would be even better to propose these changes back to C2C ;-)Kind regardslmignonOn Thu, Mar 12, 2020 at 4:17 PM Miku Laitinen <miku@avoin.systems> wrote:Also, if you're interested in a self-hosted solution, we modified Camptocamp's attachment_s3 a bit to work with Minio: https://github.com/avoinsystems/odoo-cloud-platform/commit/4f4670f28917e482645c66b8c58e92126b4c48c8We've been running it in production for over a year now without any issues.Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:08 PM Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Laurent Mignon - 09:20 - 13 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Attachments via S3?
Found the PR: https://github.com/itpp-labs/misc-addons/pull/712I'd facepalm right now, but we're not supposed to touch our faces :) It's for a different repository and a different module. My bad. I will open a PR today.Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Fri, Mar 13, 2020 at 9:50 AM Miku Laitinen <miku@avoin.systems> wrote:Laurent, I could've sworn that I made a pull request but it wasn't accepted because "it was out of scope" of this module. But now I can't find that pull request. If you would accept these changes, I'd be happy to contribute.Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Fri, Mar 13, 2020 at 9:47 AM Mignon, Laurent <laurent.mignon@acsone.eu> wrote:Miku,Nice to see that you've extended the C2C addon to support Minio. It would be even better to propose these changes back to C2C ;-)Kind regardslmignonOn Thu, Mar 12, 2020 at 4:17 PM Miku Laitinen <miku@avoin.systems> wrote:Also, if you're interested in a self-hosted solution, we modified Camptocamp's attachment_s3 a bit to work with Minio: https://github.com/avoinsystems/odoo-cloud-platform/commit/4f4670f28917e482645c66b8c58e92126b4c48c8We've been running it in production for over a year now without any issues.Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:08 PM Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Miku Laitinen. - 08:56 - 13 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Attachments via S3?
Laurent, I could've sworn that I made a pull request but it wasn't accepted because "it was out of scope" of this module. But now I can't find that pull request. If you would accept these changes, I'd be happy to contribute.
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Fri, Mar 13, 2020 at 9:47 AM Mignon, Laurent <laurent.mignon@acsone.eu> wrote:Miku,Nice to see that you've extended the C2C addon to support Minio. It would be even better to propose these changes back to C2C ;-)Kind regardslmignonOn Thu, Mar 12, 2020 at 4:17 PM Miku Laitinen <miku@avoin.systems> wrote:Also, if you're interested in a self-hosted solution, we modified Camptocamp's attachment_s3 a bit to work with Minio: https://github.com/avoinsystems/odoo-cloud-platform/commit/4f4670f28917e482645c66b8c58e92126b4c48c8We've been running it in production for over a year now without any issues.Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:08 PM Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Miku Laitinen. - 08:51 - 13 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Attachments via S3?
My idea is that we should rebase our work on odoo-cloud-platform on the storage modules so that we could:
* support ir.attachment w/ the same machinery* support different S3 providers w/out having to hack our module (storage_s3 now supports providers != AWS)I totally agree with that idea.
by Laurent Mignon - 08:45 - 13 Mar 2020 -
Re: Attachments via S3?
Miku,Nice to see that you've extended the C2C addon to support Minio. It would be even better to propose these changes back to C2C ;-)Kind regardslmignonOn Thu, Mar 12, 2020 at 4:17 PM Miku Laitinen <miku@avoin.systems> wrote:Also, if you're interested in a self-hosted solution, we modified Camptocamp's attachment_s3 a bit to work with Minio: https://github.com/avoinsystems/odoo-cloud-platform/commit/4f4670f28917e482645c66b8c58e92126b4c48c8We've been running it in production for over a year now without any issues.
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:08 PM Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Laurent Mignon - 08:45 - 13 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Attachments via S3?
Ciao Alexey,one important point: bear in mind that `storage_file` and alike are not integrated w/ std odoo attachments.They use specific models (eg: storage.file, storage.image, etc).My idea is that we should rebase our work on odoo-cloud-platform on the storage modules so that we could:* support ir.attachment w/ the same machinery* support different S3 providers w/out having to hack our module (storage_s3 now supports providers != AWS)I've recently added support for server env in the storage machinery, hence there should be no blocker if we want to go down this path.If you want to do something about it, feel free to do so :)Just post an issue to discuss about implementation details if needed.Bests,S.On Fri, Mar 13, 2020 at 7:16 AM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Thanks everyone! I’ve even learned that we have a repository (storage one) I’ve never heard of :D We really need a repo map
On 12 Mar 2020, at 17:32, Jordi Riera <jordi.riera@numigi.com> wrote:Hello,For local storage you can also take a look at this module: https://github.com/hibou-io/hibou-odoo-suite/tree/11.0/attachment_minioBased on camptocamp work.We did some tests and worked great !Best,JordiLe jeu. 12 mars 2020 à 11:17, Alexey Pelykh <alexey.pelykh@gmail.com> a écrit :Thanks!
On 12 Mar 2020, at 16:12, Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku LaitinenTeknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMSOn Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
Jordi Riera - VP TechniqueNUMIGI SOLUTIONS INC.(514) 317-7944Longueuil, Québec, Canada
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Simone Orsi - 08:30 - 13 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Attachments via S3?
Thanks everyone! I’ve even learned that we have a repository (storage one) I’ve never heard of :D We really need a repo map
On 12 Mar 2020, at 17:32, Jordi Riera <jordi.riera@numigi.com> wrote:Hello,For local storage you can also take a look at this module: https://github.com/hibou-io/hibou-odoo-suite/tree/11.0/attachment_minioBased on camptocamp work.We did some tests and worked great !Best,JordiLe jeu. 12 mars 2020 à 11:17, Alexey Pelykh <alexey.pelykh@gmail.com> a écrit :Thanks!
On 12 Mar 2020, at 16:12, Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku LaitinenTeknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMSOn Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Jordi Riera - VP TechniqueNUMIGI SOLUTIONS INC.(514) 317-7944Longueuil, Québec, Canada
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Alexey Pelykh <alexey.pelykh@gmail.com> - 07:16 - 13 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Attachments via S3?
Hello,For local storage you can also take a look at this module: https://github.com/hibou-io/hibou-odoo-suite/tree/11.0/attachment_minioBased on camptocamp work.We did some tests and worked great !Best,JordiLe jeu. 12 mars 2020 à 11:17, Alexey Pelykh <alexey.pelykh@gmail.com> a écrit :Thanks!
On 12 Mar 2020, at 16:12, Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku LaitinenTeknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMSOn Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Jordi Riera - VP TechniqueNUMIGI SOLUTIONS INC.(514) 317-7944Longueuil, Québec, Canada
by Jordi Riera - 05:31 - 12 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Attachments via S3?
Maybe there ?Le jeu. 12 mars 2020 à 16:17, Alexey Pelykh <alexey.pelykh@gmail.com> a écrit :Thanks!
On 12 Mar 2020, at 16:12, Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku LaitinenTeknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMSOn Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by David BEAL - 05:31 - 12 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Attachments stored by real name
Hi all,do anyone knows a module that store attachments with real names? Or with some kinds of auto-generated folders like old ftp-accessible logic?ThanksSergio Corato
by Sergio Corato - 04:41 - 12 Mar 2020 -
Re: Attachments via S3?
Also, if you're interested in a self-hosted solution, we modified Camptocamp's attachment_s3 a bit to work with Minio: https://github.com/avoinsystems/odoo-cloud-platform/commit/4f4670f28917e482645c66b8c58e92126b4c48c8We've been running it in production for over a year now without any issues.
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:08 PM Miku Laitinen <miku@avoin.systems> wrote:The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Miku Laitinen. - 04:15 - 12 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Attachments via S3?
The attached files are stored on the disk by default. I believe they were stored in the database only in OpenERP 7 and before.Check out these modules:
- https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
- https://github.com/camptocamp/odoo-cloud-platform/tree/13.0/attachment_s3 (files move through Odoo)
Miku Laitinen
Teknologiajohtaja / Odoo-arkkitehti / AVOIN.SYSTEMS
Lue tuoreimmat kuulumiset blogistamme!
On Thu, Mar 12, 2020 at 5:02 PM Alexey Pelykh <alexey.pelykh@gmail.com> wrote:Dear community, Has anyone seen a module that allows attached files to be stored outside of database? Kind regards, Alexey
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Miku Laitinen. - 04:11 - 12 Mar 2020 - https://github.com/itpp-labs/misc-addons/tree/13.0/ir_attachment_s3 (direct links to s3)
-
Re: Github OCA do not have runbot and codecov in v13
Hi Kitti,I check the URL that you sent but it looks fine to me since that it is using runbot correctly and green status.For the codecov, there is an opened issue about:Regards!El mié., 11 mar. 2020 a las 21:27, Kitti Upariphutthiphong (<kittiu@ecosoft.co.th>) escribió:Hi again,Since there was no answer. May I ask again. Do I miss something?No codecov anymore?Thanks!On Mon, Feb 17, 2020 at 3:10 PM Kitti Upariphutthiphong <kittiu@ecosoft.co.th> wrote:Dear contributors,
Has been experiences this a while now. For example,Only Travis seem working.Thank you,_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Moisés López CalderónMobile: (+521) 477-752-22-30Twitter: @moylop260Twitter: @vauxoo
by Moisés López Calderón - 07:21 - 12 Mar 2020 -
Re: Github OCA do not have runbot and codecov in v13
Hi again,Since there was no answer. May I ask again. Do I miss something?No codecov anymore?Thanks!On Mon, Feb 17, 2020 at 3:10 PM Kitti Upariphutthiphong <kittiu@ecosoft.co.th> wrote:Dear contributors,
Has been experiences this a while now. For example,Only Travis seem working.Thank you,
by Kitti Upariphutthiphong - 04:25 - 12 Mar 2020 -
Re: Pre-commit updates
Thanks for your hard workOn Mon, 9 Mar 2020, 1:07 pm Jairo Llopis, <jairo.llopis@tecnativa.com> wrote:Thanks a lot!El sáb., 7 mar. 2020 a las 12:47, Stéphane Bidoul (<stephane.bidoul@acsone.eu>) escribió:Okay folks, after a few weeks of fine tuning we are ready to launch this update.Here is a typical example of what this will do: https://github.com/OCA/queue/commit/ca187a05bbdd4f00870fa13d678c3d9d2f40ea52I just wanted to insist on the fact that all XML files on the 13.0 branches are going to be reformatted.This is for the better, IMO, but if you have major refactorings in progress this may disturb your workflow.So if any PSC want to temporarily opt-out some repos of this update, let me know before Friday March 13th.Best regards,-sbi--On Fri, Jan 24, 2020 at 3:02 PM Jairo Llopis <jairo.llopis@tecnativa.com> wrote:tl;dr: pre-commit is getting updated, expect conflicts in your PRs. XML and JS autoformatting!Hi community.As you might know, for v13 we took a big step forward in our coding standards introducing pre-commit in our workflow, which rewrites all python code in a beautiful-enough fashion.After the work we've done in https://github.com/OCA/maintainer-quality-tools/pull/618, our dear Stéphane Bidoul will soon update the pre-commit configuration and it will enable even more code automatic standardization.In this case, the main change comes from the inclusion of Prettier and ESLint --fix in our pipeline. They will take the job of prettifying code of these files:- .scss/.css
- .js
- .xml (via prettier plugin)
- Others not so common in our codebase: .md, .html, .less, .yaml
- Before you ask, files created or modified by bots are excluded from the reformat.
- Only for v13+
The case for JS is a little bit special in the sense that style changes will be done by Prettier, and AST changes will be done by ESLit, but ESLint still have some linter rules that are not autofixable, and in such case your commit will fail until you satisfy them manually.Given this will produce a big diff commit (just like isort+black did), I took this chance to update some of the tools that we were already using, so there could be a little more diff in python maybe. It shouldn't be too much.We hope this saves you a lot of time and pain when writing these files. Just write ugly & quick code, and pre-commit will handle the rest 😁How does this affect you?Really not much; just:- Your open PRs could get conflicts. Rebase it and fix them as usual.
- Remember to do pre-commit install when you clone a repo.
- JS code might need an update to satisfy the linter.
- You are encouraged to enable eslint, black, prettier and editorconfig plugins in your favourite IDE, as you probably already did with flake8 and pylint. They should work out of the box, although pre-commit is the maximum authority regarding code reformatting because it works exactly the same in all envs.
The change is planned for february 15th, although Stéphane will tell more details in this thread if needed (please) and I'm advancing it for web and website where the change is most interesting.Have a nice day!--Jairo Llopis_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Jairo Llopis_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by alfadil - 11:26 - 9 Mar 2020 -
Re: Pre-commit updates
Amazing work, thanks everybody!On Sat, Mar 7, 2020 at 2:46 PM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:Thank you very much!
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Simone Orsi - 08:36 - 9 Mar 2020
