Skip to Content
  2. Mailing Lists
  3. Contributors

Archives

Contributors

  • Re: Question regarding the process for check deposit with POS V>=14.0
    Hello Florent,

    I know this problem on Odoo v14 ; I developed the module "pos_no_cash_bank_statement" specifically to address this problem :
    Once it is properly configured, the account_check_deposit module will work again with POS payment by check just like in v12.

    The problem is different on Odoo v16, but it's another story :)

    Alexis

    Le lun. 23 janv. 2023 à 17:01, Florent Thomas <notifications@odoo-community.org> a écrit :
    Hi everyone,

    Hope it's the proper place to share this question.
    In v12, all the payment mode for POS were journal so that it work perfectly with the check deposit module.
    Getting check in the POS could be used directly in the deposit.

    In v14, pos.payment.mode are not associated to a specific journal so that collected checks in pos ar not available for deposit.

    Is anyone has an advce for this?

    Maybe @legalsylvain @alexis-via ?

    Regards

    Vertical seprator

    Florent THOMAS

    ☎ +33 972 457 755
    ✉ florent.thomas@mind-and-go.com

    Mind & Go
    14, Rue Pierre Cartelet | 66000 PERPIGNAN

    Logo Mind And Go Facebook Mind And Go Twitter Mind And Go LinkedIn Mind And Go

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe



    --
    Alexis de Lattre
    Akretion France - 27 rue Henri Rolland - 69100 Villeurbanne - France
    Mail : alexis.delattre@akretion.com
    Mobile : +33 6 99 08 92 45
    by Alexis de Lattre - 05:36 - 23 Jan 2023
  • Question regarding the process for check deposit with POS V>=14.0
    Hi everyone,

    Hope it's the proper place to share this question.
    In v12, all the payment mode for POS were journal so that it work perfectly with the check deposit module.
    Getting check in the POS could be used directly in the deposit.

    In v14, pos.payment.mode are not associated to a specific journal so that collected checks in pos ar not available for deposit.

    Is anyone has an advce for this?

    Maybe @legalsylvain @alexis-via ?

    Regards

    Vertical seprator

    Florent THOMAS

    ☎ +33 972 457 755
    ✉ florent.thomas@mind-and-go.com

    Mind & Go
    14, Rue Pierre Cartelet | 66000 PERPIGNAN

    Logo Mind And Go Facebook Mind And Go Twitter Mind And Go LinkedIn Mind And Go

    by Florent THOMAS - 05:00 - 23 Jan 2023
  • Re: [FIX]:Weblate - use po file download/upload - revisions


    Il giorno dom 22 gen 2023 alle ore 11:27 Stéphane Bidoul <notifications@odoo-community.org> ha scritto:
    We discussed a translation review mechanism before, I think, but IIRC we concluded we need a process first.

    Yes, you are right. :-)

    Below, as italian community in addition to Stefano answers, you can find a proposal.

     

    Here are a few questions that come to mind. There might be more.

    - Clearly define the problem we are attempting to solve? For instance, Is it "vandalism" of existing translations (this could be solved by banning offenders)? Or is it incorrect/low quality new translations (which can be fixed easily after the fact, I suppose)? Or something else?

    The second one. Incorrect/low level translations, not only new, that don't follow current community guidelines and glossaries (language specific).

     
    - What would be the process to appoint/elect reviewers? Currently we accept anyone who asks.
    - How to make sure translation proposals are not stuck for too long waiting for review?

    I would replicate Transifex structure or similar, if possible. Here is a proposal:
    - Anyone can be accepted as translator, strings are pushed as soon as translated. (or on a periodic basis)
    - There is a reviewer role, reviewed strings are freezed and can't be changed by translators.
    -  The coordinator role has reviewer power and can appoint translators as reviewers.

    The coordinator could be nominated by each localization repository PSC. (l10n-*)
    He would be in charge of appointing reviewers evaluating the quality of their translations over time, based on guidelines/glossary compliance.

    - Should/can we enable the review process per language? This may be important as not all language communities have the resources to have dedicated reviewers.

    Sure, I add that not all communities have translation guidelines. [*]

    [*] e.g. italian guidelines (and glossaries) https://www.odoo-italia.org/documentazione/14.0/traduzioni.html


    S.

    by Sergio Zanchetta - 11:35 - 23 Jan 2023
  • Re: [FIX]:Weblate - use po file download/upload - revisions
    I give my reply for italian language/community:
     
    > Clearly define the problem we are attempting to solve? For instance, Is it "vandalism" of existing translations (this could be solved by banning offenders)? Or is it incorrect/low quality new translations (which can be fixed easily after the fact, I suppose)? Or something else?
    As far I know we don't have problems of a misuse of the tool. What we noticed is that the "need" and the "hurry" to have the translations, or a lack in the definition of a glossary for common terms, or the contributions of a new entry (like in part I am), goes to some incorrect  or not so pertinent translations.
     
    > What would be the process to appoint/elect reviewers? Currently we accept anyone who asks.
    Hm, here I don't know what to say, can't be done in the "same way" that PSC are nominated for repository in GitHub?
     
    > How to make sure translation proposals are not stuck for too long waiting for review?
    Yes, this is a weakness. I don't know if it can be done and how, but I'd like to have a system in which the reviewed terms can be changed only by reviewers and other terms can be changed (and then loaded) by anyone (view *).
     
    > Should/can we enable the review process per language? This may be important as not all language communities have the resources to have dedicated reviewers.
    Absolutely yes: the lack of resources is a problem and (*) I prefer that a thing is done now than perfect never. So the activation of the review process should be decided by each community.

    Thanks for expanding the discussion, I hope others will join.

    Stefano 
     

    Da: "Stéphane Bidoul" notifications@odoo-community.org
    A: "Contributors" contributors@odoo-community.org
    Cc:
    Data: Sun, 22 Jan 2023 10:27:40 -0000
    Oggetto: Re: [FIX]:Weblate - use po file download/upload - revisions

    We discussed a translation review mechanism before, I think, but IIRC we concluded we need a process first.

    Here are a few questions that come to mind. There might be more.

    - Clearly define the problem we are attempting to solve? For instance, Is it "vandalism" of existing translations (this could be solved by banning offenders)? Or is it incorrect/low quality new translations (which can be fixed easily after the fact, I suppose)? Or something else?
    - What would be the process to appoint/elect reviewers? Currently we accept anyone who asks.
    - How to make sure translation proposals are not stuck for too long waiting for review?
    - Should/can we enable the review process per language? This may be important as not all language communities have the resources to have dedicated reviewers.

    Best regards,

    -sbi


    On Fri, Jan 20, 2023 at 11:52 AM Sergio Zanchetta <notifications@odoo-community.org> wrote:


    Il giorno ven 20 gen 2023 alle ore 11:22 Stéphane Bidoul <notifications@odoo-community.org> ha scritto:
    Hello Stefano,

    I'm not familiar with that Transfer revision option.
    Have you found something equivalent in the weblate documentation?


    Hello Stéphane, here you can find how to enable it:

    I agree with Stefano that we should enable peer review (with a dedicated role) to improve translation quality.
    A sort of PSC, but for translations.

    S.


    by Stefano Consolaro - 08:40 - 23 Jan 2023
  • Re: [FIX]:Weblate - use po file download/upload - revisions
    We discussed a translation review mechanism before, I think, but IIRC we concluded we need a process first.

    Here are a few questions that come to mind. There might be more.

    - Clearly define the problem we are attempting to solve? For instance, Is it "vandalism" of existing translations (this could be solved by banning offenders)? Or is it incorrect/low quality new translations (which can be fixed easily after the fact, I suppose)? Or something else?
    - What would be the process to appoint/elect reviewers? Currently we accept anyone who asks.
    - How to make sure translation proposals are not stuck for too long waiting for review?
    - Should/can we enable the review process per language? This may be important as not all language communities have the resources to have dedicated reviewers.

    Best regards,

    -sbi


    On Fri, Jan 20, 2023 at 11:52 AM Sergio Zanchetta <notifications@odoo-community.org> wrote:


    Il giorno ven 20 gen 2023 alle ore 11:22 Stéphane Bidoul <notifications@odoo-community.org> ha scritto:
    Hello Stefano,

    I'm not familiar with that Transfer revision option.
    Have you found something equivalent in the weblate documentation?


    Hello Stéphane, here you can find how to enable it:

    I agree with Stefano that we should enable peer review (with a dedicated role) to improve translation quality.
    A sort of PSC, but for translations.

    S.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Stéphane Bidoul - 11:26 - 22 Jan 2023
  • Re: Multi-company > one default bank account
    Thank you so much for your welcoming  feedback Holger and Sylvain:)

    Indeed the French CAE accounting example (shared Journals, account, taxes ) seems to be exactly what we need - and we can use all the help we can get to port it from v12 to v16 as quickly as possible, with the goal of proposing and maintaining it as a 16 vertical cooperative fiscal host branch to the OCA/cooperative.

    We have some funds (nonprofit scale though) to start spearheading the verticalization we need and we want to invest it in helping sylvain porting  the 4 base modules to start with, or in any simpler solution with same accounting functions:
    We already have 3 other nonprofit hosts in pipeline and we’re convinced that the need for such structure is growing exponentially everywhere, not only in our cultural and activism domains but in all sorts of open source communities. Many of the most groundbreaking OS projects from allover the world are forced to use opencollective and such, and the OCA seems to be the most logical environment to offer a decentralized and mutualized alternative to them.

    Thanks in advance for any feedback and/or pointers on how to achieve that as swiftly and sustainable as possible,
    Lena && Tali

    > To our understanding using Multi-Company logic is the best fit for our

> purposes, including the need of inter-company billing, however as a fiscal

> host we must be able to set one default bank account (of the main/parent

> company) for all the children companies.

note that multicompany separates entities to some degree, but as soon as you 
allow any user of the child companies access to the configuration, they can 
undo all of this. The same if you install modules that allow users to run 
code.


> We tried to set it as a default attribute from inherited account.move model

> & form, & res.partner.bank, and also muted restriction in res.bank to allow

> different companies have the same bank account. This however doesn’t seem

> to work.

links to code are much more helpful than verbal descriptions
 

> We also tried to set a default bank account value in payment mode, but we

> couldn’t make the parent's mode be accessible for daughter companies.

did you change
https://github.com/OCA/bank-payment/blob/16.0/account_payment_mode/security/
account_payment_mode.xml#L7
?


-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com



    Moshchot Coop
    A DISTRIBUTED OPEN SOURCE COOPERATIVE



    by "Moshchot Coop" <tali@moshchot.org> - 11:10 - 20 Jan 2023

    3 attachments 3 attachments

    PastedGraphic-3.tiff
    signature.asc
    PastedGraphic-1.png
  • Fwd: ***SPAM*** Re: Multi-company > one default bank account
    Thank you so much for your welcoming  feedback Holger and Sylvain:)

    Indeed the French CAE accounting example (shared Journals, account, taxes ) seems to be exactly what we need - and we can use all the help we can get to port it from v12 to v16 as quickly as possible, with the goal of proposing and maintaining it as a 16 vertical cooperative fiscal host branch to the OCA/cooperative.

    We have some funds (nonprofit scale though) to start spearheading the verticalization we need and we want to invest it in helping sylvain porting  the 4 base modules to start with, or in any simpler solution with same accounting functions:
    We already have 3 other nonprofit hosts in pipeline and we’re convinced that the need for such structure is growing exponentially everywhere, not only in our cultural and activism domains but in all sorts of open source communities. Many of the most groundbreaking OS projects from allover the world are forced to use opencollective and such, and the OCA seems to be the most logical environment to offer a decentralized and mutualized alternative to them.

    Thanks in advance for any feedback and/or pointers on how to achieve that as swiftly and sustainable as possible,
    Lena && Tali

    > To our understanding using Multi-Company logic is the best fit for our

> purposes, including the need of inter-company billing, however as a fiscal

> host we must be able to set one default bank account (of the main/parent

> company) for all the children companies.

note that multicompany separates entities to some degree, but as soon as you 
allow any user of the child companies access to the configuration, they can 
undo all of this. The same if you install modules that allow users to run 
code.


> We tried to set it as a default attribute from inherited account.move model

> & form, & res.partner.bank, and also muted restriction in res.bank to allow

> different companies have the same bank account. This however doesn’t seem

> to work.

links to code are much more helpful than verbal descriptions
 

> We also tried to set a default bank account value in payment mode, but we

> couldn’t make the parent's mode be accessible for daughter companies.

did you change
https://github.com/OCA/bank-payment/blob/16.0/account_payment_mode/security/
account_payment_mode.xml#L7
?


-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com



    Moshchot Coop
    A DISTRIBUTED OPEN SOURCE COOPERATIVE



    by "Moshchot Coop" <tali@moshchot.org> - 10:55 - 20 Jan 2023

    3 attachments 3 attachments

    PastedGraphic-3.tiff
    signature.asc
    PastedGraphic-1.png
  • Re: Supplier invoice suspending
    Maybe this can help you

    https://github.com/OCA/account-invoicing/tree/14.0/account_invoice_blocking

    Marks the lines of the invoice as blocked 

    On 20 Jan 2023 15:22, Daniel Reis <notifications@odoo-community.org> wrote:
    I would do this preventing the Vendor Bill from being confirmed until some criteria is met.
    The Tier Validation module allows implementing this through configurable rules.
    https://odoo-community.org/shop/account-move-tier-validation-5253

    Thanks
    Daniel

    On 20/01/23 14:11, Radovan Skolnik wrote:
    Hello,

a customer asks for a functionality to somehow "suspense" supplier invoice 
(payment) until some additional criteria is met - like for example supplier 
providing required documents, etc.

New state would seem ot be a good way to do this but I am a bit hesitant 
adding new state into accounting.

Is there anything else available that would provide clear visibility to 
accountant that although this bill is posted we should not be paying it yet?

Thank you. Best regards

	Radovan Skolnik

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe


    --
    DANIEL REIS
    MANAGING DIRECTOR

    M: +351 919 991 307
    E: dreis@OpenSourceIntegrators.com
    A: Avenida da República 3000, Estoril Office B, #34

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe






    Tanto este mensaje como los documentos que, en su caso, lleve como anexos,
    pueden contener información reservada y/o confidencial, destinada exclusivamente
    para el uso del destinatario o la persona responsable de entregarlo al mismo,
    estando su uso no autorizado prohibido legalmente.
    Su contenido no constituye un compromiso para Creu Blanca (la empresa remitente)
    salvo ratificación escrita por ambas partes. En caso de su recepción por error,
    rogamos nos lo comunique por igual vía, se abstenga de realizar copias del mensaje
    o documentos adjuntos, remitirlo o facilitarlo a un tercero, y proceda en su defecto,
    a su eliminación.
    by Enric Tobella Alomar - 03:51 - 20 Jan 2023
  • Re: Supplier invoice suspending
    I would do this preventing the Vendor Bill from being confirmed until some criteria is met.
    The Tier Validation module allows implementing this through configurable rules.
    https://odoo-community.org/shop/account-move-tier-validation-5253

    Thanks
    Daniel

    On 20/01/23 14:11, Radovan Skolnik wrote:
    Hello,

a customer asks for a functionality to somehow "suspense" supplier invoice 
(payment) until some additional criteria is met - like for example supplier 
providing required documents, etc.

New state would seem ot be a good way to do this but I am a bit hesitant 
adding new state into accounting.

Is there anything else available that would provide clear visibility to 
accountant that although this bill is posted we should not be paying it yet?

Thank you. Best regards

	Radovan Skolnik

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe


    --
    DANIEL REIS
    MANAGING DIRECTOR

    M: +351 919 991 307
    E: dreis@OpenSourceIntegrators.com
    A: Avenida da República 3000, Estoril Office B, #34

    by Daniel Reis - 03:21 - 20 Jan 2023
  • Supplier invoice suspending 
    Hello,

a customer asks for a functionality to somehow "suspense" supplier invoice 
(payment) until some additional criteria is met - like for example supplier 
providing required documents, etc.

New state would seem ot be a good way to do this but I am a bit hesitant 
adding new state into accounting.

Is there anything else available that would provide clear visibility to 
accountant that although this bill is posted we should not be paying it yet?

Thank you. Best regards

	Radovan Skolnik
    by Radovan Skolnik - 03:10 - 20 Jan 2023
  • Re: [FIX]:Weblate - use po file download/upload - revisions


    Il giorno ven 20 gen 2023 alle ore 11:22 Stéphane Bidoul <notifications@odoo-community.org> ha scritto:
    Hello Stefano,

    I'm not familiar with that Transfer revision option.
    Have you found something equivalent in the weblate documentation?


    Hello Stéphane, here you can find how to enable it:

    I agree with Stefano that we should enable peer review (with a dedicated role) to improve translation quality.
    A sort of PSC, but for translations.

    S.

    by Sergio Zanchetta - 11:50 - 20 Jan 2023
  • Re: [FIX]:Weblate - use po file download/upload - revisions
    Hello Stefano,

    I'm not familiar with that Transfer revision option.
    Have you found something equivalent in the weblate documentation?

    Best regards,

    -Stéphane 


    Le ven. 20 janv. 2023 à 11:01, Stefano Consolaro <notifications@odoo-community.org> a écrit :
    Sorry,
    for the first question: I tested it on the repo, but it works for the module

    Second question still valid, I hope ;-) 
     

    Da: "Stefano Consolaro" stefano.consolaro@mymage.it
    Cc:
    Data: Fri, 20 Jan 2023 10:23:31 +0100
    Oggetto: Weblate - use po file download/upload - revisions

    Hi, 
    I did some translation on translation.odoo-community.org using the web interface.
    Now I desire to have an overall view of a repository translation and fix some imprecisions I did, expecially for common and repeated strings.
    I see that I can download the repo's POs file but the Weblate option to upload them isn't enabled.
    If isn't possible to enable the upload, there is a way to go around this (i.e. sending the fixed files to someone)? Or the only solution is the web interface?

    Second question, on Transifex for Odoo project there is the revision option enabled that grant a better quality of the translations.
    Do you think that it can be activate on OCA Weblate too?

    Thanks for attention.
     
    PS: I hope to had use the right mailing list for this questions. 


    Stefano Consolaro


    Stefano Consolaro

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Stéphane Bidoul - 11:21 - 20 Jan 2023
  • [FIX]:Weblate - use po file download/upload - revisions
    Sorry,
    for the first question: I tested it on the repo, but it works for the module

    Second question still valid, I hope ;-) 
     

    Da: "Stefano Consolaro" stefano.consolaro@mymage.it
    A: contributors@odoo-community.org
    Cc:
    Data: Fri, 20 Jan 2023 10:23:31 +0100
    Oggetto: Weblate - use po file download/upload - revisions

    Hi, 
    I did some translation on translation.odoo-community.org using the web interface.
    Now I desire to have an overall view of a repository translation and fix some imprecisions I did, expecially for common and repeated strings.
    I see that I can download the repo's POs file but the Weblate option to upload them isn't enabled.
    If isn't possible to enable the upload, there is a way to go around this (i.e. sending the fixed files to someone)? Or the only solution is the web interface?

    Second question, on Transifex for Odoo project there is the revision option enabled that grant a better quality of the translations.
    Do you think that it can be activate on OCA Weblate too?

    Thanks for attention.
     
    PS: I hope to had use the right mailing list for this questions. 


    Stefano Consolaro
    www.mymage.it


    Stefano Consolaro
    www.mymage.it
    by Stefano Consolaro - 11:01 - 20 Jan 2023
  • Weblate - use po file download/upload - revisions
    Hi, 
    I did some translation on translation.odoo-community.org using the web interface.
    Now I desire to have an overall view of a repository translation and fix some imprecisions I did, expecially for common and repeated strings.
    I see that I can download the repo's POs file but the Weblate option to upload them isn't enabled.
    If isn't possible to enable the upload, there is a way to go around this (i.e. sending the fixed files to someone)? Or the only solution is the web interface?

    Second question, on Transifex for Odoo project there is the revision option enabled that grant a better quality of the translations.
    Do you think that it can be activate on OCA Weblate too?

    Thanks for attention.
     
    PS: I hope to had use the right mailing list for this questions. 


    Stefano Consolaro
    www.mymage.it
    by Stefano Consolaro - 10:26 - 20 Jan 2023
  • Re: Sorry, i'm not familiar with git
    Thanks for the feedback Holger, is good to have some reliable indications on the right documentation to follow. For now i'll just save the link but this should go in my to-do list : )
    I just managed to solve the issue on the commit name, thanks everyone for the patience and advices.

    Il giorno gio 19 gen 2023 alle ore 23:47 Holger Brunn <notifications@odoo-community.org> ha scritto:
    > Hi Martin I made a small research and I'd like to make a try but at the same


> time I always doubt about the action I'm planning to do on git.  For


> example in this case I have read in this article

if you keep reading recipes about isolated issues you'll always doubt what 
you're doing. I recommend reading
https://git-scm.com/book/en/v2
(skip 4 and stop after 9)
and then you'll be confident on all git related actions



-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Francesco Ballerini - 12:20 - 20 Jan 2023
  • Re: Sorry, i'm not familiar with git 
    > Hi Martin I made a small research and I'd like to make a try but at the same

> time I always doubt about the action I'm planning to do on git.  For

> example in this case I have read in this article

if you keep reading recipes about isolated issues you'll always doubt what 
you're doing. I recommend reading
https://git-scm.com/book/en/v2
(skip 4 and stop after 9)
and then you'll be confident on all git related actions


-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com
    by Holger Brunn - 11:46 - 19 Jan 2023

    1 attachments 1 attachments

    signature.asc
  • Re: Sorry, i'm not familiar with git

    Hi Franscesco,

    In this case, you seams to force-push on a branch that you own, and no body else is working on it. So, nobody will get trouble with you force push and you don't risk to destroy works of other as you are the only one working on your branch.

    It seams to be a good practice to use '--force-with-lease' when a force push is needed. If it fails it means you have to look closer of what your doing and why the push did work by looking at the history of the local and the remote branch. Common failing cases are that you try to push on the wrong remote branch or your going to delete commits from others. For the last case you need to pull and rebase and then push again.

    As you said, you're not familiar with the basic concept of git. When using such a tool, its very recommended to understand some concept so that it reveals to you the magic behind and you will fly from your own. There are lots of tutorials on the web, choose the one that you prefer. It will saves you lots of time. :)

    See you on PR's one the OCA repository. :)

    Regards,

    Le 19 janvier 2023 18:57:25 GMT+01:00, Francesco Ballerini <notifications@odoo-community.org> a écrit :
    Hi Martin I made a small research and I'd like to make a try but at the same time I always doubt about the action I'm planning to do on git. 
    For example in this case I have read in this article https://www.educative.io/answers/how-to-change-a-git-commit-message-after-a-push that I could use:

    git commit --amend -m "New message" 
    git push --force-with-lease repository-name branch-name

    but I am not sure about the 'force' or --force-with-lease which seems a less intrusive option. What I don't understand is, if --force 'which will destroy any changes someone else has pushed to the branch' as I read in the article, and --force-with-lease will "abort if there was an upstream change to the repository", is for me enough to fetch the origin before the amend/push to make a safe amend (I am not even sure this sentence makes sense eheh) or maybe it is an alternative way that I don't know? 

    Thanks,
    Francesco 

     

    Il giorno gio 19 gen 2023 alle ore 09:27 Francesco Ballerini <francescobl.lavoro@gmail.com> ha scritto:
    Thanks, I would appreciate that a lot, if it's easy to solve for you. I was a little bit tired yesterday and don't wanna make even more trouble eheh ... : )

    Thank you,
    Francesco

    Il giorno gio 19 gen 2023 alle ore 08:32 Martin Trigaux (mat) <notifications@odoo-community.org> ha scritto:
    On 19/01/2023 00:57, Francesco Ballerini wrote:
    Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'

    Hello,

    This one is because you have a space in the beginning of the commit message, " [FIX]" instead of "[FIX]" ;-)
    But don't worry about it if you are not sure how to amend your commit, we can handle it for you if needed.

    Martin

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    --
    Rémy Taymans
    Coop IT Easy
    https://coopiteasy.be
    by Rémy Taymans - 09:01 - 19 Jan 2023
  • Re: Sorry, i'm not familiar with git
    Hi Martin I made a small research and I'd like to make a try but at the same time I always doubt about the action I'm planning to do on git. 
    For example in this case I have read in this article https://www.educative.io/answers/how-to-change-a-git-commit-message-after-a-push that I could use:

    git commit --amend -m "New message" 
    git push --force-with-lease repository-name branch-name

    but I am not sure about the 'force' or --force-with-lease which seems a less intrusive option. What I don't understand is, if --force 'which will destroy any changes someone else has pushed to the branch' as I read in the article, and --force-with-lease will "abort if there was an upstream change to the repository", is for me enough to fetch the origin before the amend/push to make a safe amend (I am not even sure this sentence makes sense eheh) or maybe it is an alternative way that I don't know? 

    Thanks,
    Francesco 

     

    Il giorno gio 19 gen 2023 alle ore 09:27 Francesco Ballerini <francescobl.lavoro@gmail.com> ha scritto:
    Thanks, I would appreciate that a lot, if it's easy to solve for you. I was a little bit tired yesterday and don't wanna make even more trouble eheh ... : )

    Thank you,
    Francesco

    Il giorno gio 19 gen 2023 alle ore 08:32 Martin Trigaux (mat) <notifications@odoo-community.org> ha scritto:
    On 19/01/2023 00:57, Francesco Ballerini wrote:
    Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'

    Hello,

    This one is because you have a space in the beginning of the commit message, " [FIX]" instead of "[FIX]" ;-)
    But don't worry about it if you are not sure how to amend your commit, we can handle it for you if needed.

    Martin

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Francesco Ballerini - 06:56 - 19 Jan 2023
  • Re: booking of resources
    Hi Hughes!

    El mar, 17 de ene de 2023 a las 19:56:59 PM, hugues de keyzer <notifications@odoo-community.org> escribiĆ³:
    if there are 4 rooms, 3 video projectors and 5 people that can be combined freely, 96 combinations (including the ā€œno video projectorā€ and ā€œno waiterā€ choice) must be created (and each of them must be added to at least one resource.booking.type to be selectable). moreover, the client would need to search through all of these to find the desired one. and what if there could be multiple waiters? this feels awkward

    Although you might feel like the combinations design is weird, the use case you're proposing here is actually a good reason why it exists.

    Are customers able to do a single booking of 2 projectors? That's unlikely. Or 1 projector and 2 rooms? Also very unlikely. 1 projector, 1 room and 2 waiters? That could be. 1 projector and no waiters or rooms? Depends on the case. Are all projectors available in all rooms? Or some rooms have a projector installed statically that can't be booked for another room? Are all rooms in the same building, or are they in different buildings? Are all buildings in the same country? Are there big rooms that cannot be handled by just 1 waiter?

    The amount of possible combinations (and more important: the impossible combinations) justifies the existence of resource.booking.combination.

    So IMHO the best approach would be to simplify the usage of resource.booking.combination, instead of replacing it. Some ideas:

    1. Add a button "Generate combinations". The button opens a wizard that will help you create combinations massively.
    2. When the user is selecting the combination, improve the UX making them available to pick resources individually. The engine would then select the appropriate combination under the hood.
    3. Add an option to the type: "Allow all possible combinations". Then, when customer selects the combination, resource by resource (idea 2), if it doesn't exist, it will be created on demand.
    Other than that, it seems to me like the use case you described fits perfectly in the resource_booking collection, so you'll probably be better improving them than reinventing them.
    by Jairo Llopis - 09:46 - 19 Jan 2023
  • Re: Sorry, i'm not familiar with git
    Thanks, I would appreciate that a lot, if it's easy to solve for you. I was a little bit tired yesterday and don't wanna make even more trouble eheh ... : )

    Thank you,
    Francesco

    Il giorno gio 19 gen 2023 alle ore 08:32 Martin Trigaux (mat) <notifications@odoo-community.org> ha scritto:
    On 19/01/2023 00:57, Francesco Ballerini wrote:
    Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'

    Hello,

    This one is because you have a space in the beginning of the commit message, " [FIX]" instead of "[FIX]" ;-)
    But don't worry about it if you are not sure how to amend your commit, we can handle it for you if needed.

    Martin

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Francesco Ballerini - 09:30 - 19 Jan 2023