Message Threads | The Odoo Community Association

Re: Confirm unsubscription to Contributors

Hi, it is issue?, i did not ask unsubscribe

El vie, 15 sept 2023 a las 8:27, BOUDMIR IBRAHIM (<notifications@odoo-community.org>) escribió:

Hi,

As far as i know, i did not ask to unsubscribe from the mailing list of OCA.

Regards.
ᐧ

On Fri, Sep 15, 2023 at 3:07 PM <info@odoo-community.org> wrote:

Your Channel
Contributors

Hello,

You have requested to be unsubscribed to the mailing list Contributors.

To confirm, please visit the following link: https://odoo-community.org/groups/unsubscribe/15/25929/62a4e531b032a4a5754ff590ea1b3b1e.

If this was a mistake or you did not requested this action, please ignore this message.

Odoo Community Association (OCA)

info@odoo-community.org | http://odoo-community.org

Powered by Odoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Saludos Cordiales.

by Carlos Lopez - 10:21 - 15 Sep 2023

Re: Auto unsubscribe

Hi Roussel,
Yes I confirm, I received it as well.
Thanks,

Le ven. 15 sept. 2023 à 15:17, Roussel, Denis <notifications@odoo-community.org> a écrit :

Hi,

Is there something done on OCA side that has triggered an unsubscribe action to this mailing list as I've just received a 'Confirm unsubscription to Contributors' email?

Thanks to the Board for the answer (as some colleagues received it too).

--

Denis Roussel
Software Engineer
T : +32 2 888 31 49
M : +32 472 22 00 57

Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium
Zone industrielle 22 | L-8287 Kehlen | Luxembourg

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

---

[ Youness @ MAAFI ]

Tel: +49.176.368.378.62
Email: youness.maafi@gmail.com

by Youness Maafi - 03:26 - 15 Sep 2023

Re: Confirm unsubscription to Contributors

Hi,

As far as i know, i did not ask to unsubscribe from the mailing list of OCA.

Regards.

ᐧ

On Fri, Sep 15, 2023 at 3:07 PM <info@odoo-community.org> wrote:

Your Channel
Contributors

Hello,

You have requested to be unsubscribed to the mailing list Contributors.

To confirm, please visit the following link: https://odoo-community.org/groups/unsubscribe/15/25929/62a4e531b032a4a5754ff590ea1b3b1e.

If this was a mistake or you did not requested this action, please ignore this message.

Odoo Community Association (OCA)

info@odoo-community.org | http://odoo-community.org

Powered by Odoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by bdmibra - 03:26 - 15 Sep 2023

Auto unsubscribe

Hi,

Is there something done on OCA side that has triggered an unsubscribe action to this mailing list as I've just received a 'Confirm unsubscription to Contributors' email?

Thanks to the Board for the answer (as some colleagues received it too).

--

Denis Roussel
Software Engineer
T : +32 2 888 31 49
M : +32 472 22 00 57

Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium

Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

Zone industrielle 22 | L-8287 Kehlen | Luxembourg

by Denis Roussel - 03:17 - 15 Sep 2023

Confirm unsubscription to Contributors

Your Channel Contributors

Hello,

You have requested to be unsubscribed to the mailing list Contributors.

To confirm, please visit the following link: https://odoo-community.org/groups/unsubscribe/15/25929/62a4e531b032a4a5754ff590ea1b3b1e.

If this was a mistake or you did not requested this action, please ignore this message.

Odoo Community Association (OCA)

info@odoo-community.org | http://odoo-community.org

Powered by Odoo

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by info@odoo-community.org - 03:06 - 15 Sep 2023

1 attachments 1 attachments

OCA Days Talk Proposals - submissions close Friday 15th September

Hi everyone,

As you know OCA Days 2023 is coming up on the 6 + 7 November.
We are very much looking forward to seeing those who can make it in Liège.

You can still register here.

I wanted to remind people that the last day for talk submissions is today - Friday 15th September. Share your ideas here.

We will accept a broad range of proposals:

presentations on different modules/ module updates
community project
trainings/tutorials
case studies
implementations
great discussion topics

As long as the presentation is interesting and potentially useful to the audience, it will be considered for inclusion in the programme.

When submitting a talk please put at the end of the talk title if it is a functional or technical talk.

New for 2023 - Functional track.

This year, we'll also host a functional track as well as our standard track. We would like to promote some topics and encourage experts to propose their talks to help functional participants feel more integrated into the OCA.

In the functional room we would like to give the opportunity for good discussions too - one person proposes a topic, gives his understanding and then it's more of a practice and ideas exchange moment.

When submitting your functional talk please as mentioned above, let us know it is functional and also whether it is to be a presentation, training or discussion.

Here are some examples of topics that will certainly interest functional profiles:

How to contribute to the OCA as a functional?
How to navigate Github as a functional?
How to use Weblate and why it is useful?
How to use the runboat and test every OCA module easily?
Presentation of must-have OCA modules from a functional perspective
Any other topic that you think could help functional get more engaged into the OCA community

If you feel up to it, whether you have a technical or functional profile, please help us make the OCA Days interesting for functional roles! We'll have 30min, 45 min and 60min slots available.

We can't wait to see what our community has to share for 2023!

Have a great weekend everyone.

Rebecca

--

Rebecca Gellatly

General Secretary

Odoo Community Association

by Rebecca Gellatly - 06:40 - 15 Sep 2023

Re: Best practice add optional="show" when adding fields in tree views

I also agree with the request from a functional standpoint: especially in big repos like sale-workflow, there should be a specific attention on:

- preserving ux of runboat

allowing to hide non-required fields in list views is particularly useful in this regard, eg. sale order lines

- avoiding publishing modules disrupting base functional testing (eg: confirming an order, creating an invoice...)

This can be achieved by adding settings enabling the "intrusive" behavior, by not using standard records such as "Azure interior" for testing but creating a specifically named record, and in general by trying to leave runboat as it was found on a functional level :)

My 2 cents!

Francesco

Il giorno mar 29 ago 2023 alle ore 11:01 Ronald Portier <notifications@odoo-community.org> ha scritto:

Thanks Pedro, we are in complete agreement then.


Regards, Ronald


Op 29-08-2023 om 10:42 schreef Pedro M. Baeza:


> Sorry, my bad. I don't know why, I read optional="hide". It's OK to 


> put optional="show", but I would leave out of the equation mandatory 


> fields without default, or those protected with a group, as the group 


> is already the filtering method for not showing them.


>


> Regards.


>


> _______________________________________________


> Mailing-List: https://odoo-community.org/groups/contributors-15 


> <https://odoo-community.org/groups/contributors-15>


> Post to: mailto:contributors@odoo-community.org


> Unsubscribe: https://odoo-community.org/groups?unsubscribe 


> <https://odoo-community.org/groups?unsubscribe>


>

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Francesco Foresti

Sicurpharma Srl

francesco.foresti@ooops404.com

+39 333 8123 790

by Francesco Foresti - 06:21 - 14 Sep 2023

Re: A (hope not stupid) question about wire transfer payment transactions

Holy moly!

How could I miss this? I was specifically searching for that _set_done() call and missed this obvious one.

Still I'd expect some kind of integration between bank statements and this. Maybe an idea to write one.

Thanks a lot!

Best regards,

Radovan

On Sep 13, 2023 19:37, Enric Tobella Alomar <notifications@odoo-community.org> wrote:

You are probably looking for this

https://github.com/odoo/odoo/blob/2d5b4998e2b1c9111e7997b6174abf41dc2af02d/addons/sale/models/sale_order.py#L873-L879

Kind regards,
El mié, 13 sept 2023 a las 19:22, Radovan Skolnik (<notifications@odoo-community.org>) escribió:
I'm using mostly Community but have searched through Enterprise sources as well. AFAIK there is no difference in this area between the two. Checked versions 16 and 15 but the older ones are the same AFAICT.

Best regards,

Radovan
On Sep 13, 2023 19:06, Youness Maafi <notifications@odoo-community.org> wrote:
Hi Skolnik,
Your question is not a stupid one at all, all questions are smart.
I for example, or maybe anyone whose mind is not fresh about the subject, would need to know first the Odoo version you are using, and in which edition ( EE or CE ) ? Can you share this with me ?
I hope I can help afterwards, ( it will be much easier )

Thanks,
Le mer. 13 sept. 2023 à 17:27, David Vidal <notifications@odoo-community.org> a écrit :
As far as I know it serves just informative purposes (i.e. portal views of the documents show that they're pending unless confirmed/payed. But yes, I'd also expect it to have at least a way to confirm those transactions manually
El mié, 13 sept 2023 a las 9:47, Radovan Skolnik (<notifications@odoo-community.org>) escribió:
Hello,

hope this will not be a stupid question - I searched through all the Odoo sources, all OCA modules but couldn't find any answer. The scenario is really simple: Wire Transfer (payment_custom in 16.0, payment_transfer in previous versions) is selected as payment provider in e-shop (website_sale). Payment transcation (payment.transaction) object is created in Pending state. The question is: is there anything anywhere that would change its state to Confirmed (done)? I would assume imported bank statements could but I cannot see that anywhere (was mainly looking for _set_done() method calls but tried other means of search as well). Would be greateful if somebody shed some light on this for me.

Thank you very much. Best regards

	Radovan Skolnik
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
---
[ Youness @ MAAFI ]

Tel: +49.176.368.378.62
Email: youness.maafi@gmail.com

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
Enric Tobella Alomar
CEO & Founder

www.dixmit.com

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Radovan Skolnik - 07:55 - 13 Sep 2023

Re: A (hope not stupid) question about wire transfer payment transactions

You are probably looking for this

https://github.com/odoo/odoo/blob/2d5b4998e2b1c9111e7997b6174abf41dc2af02d/addons/sale/models/sale_order.py#L873-L879

Kind regards,

El mié, 13 sept 2023 a las 19:22, Radovan Skolnik (<notifications@odoo-community.org>) escribió:

I'm using mostly Community but have searched through Enterprise sources as well. AFAIK there is no difference in this area between the two. Checked versions 16 and 15 but the older ones are the same AFAICT.

Best regards,

Radovan
On Sep 13, 2023 19:06, Youness Maafi <notifications@odoo-community.org> wrote:
Hi Skolnik,
Your question is not a stupid one at all, all questions are smart.
I for example, or maybe anyone whose mind is not fresh about the subject, would need to know first the Odoo version you are using, and in which edition ( EE or CE ) ? Can you share this with me ?
I hope I can help afterwards, ( it will be much easier )

Thanks,
Le mer. 13 sept. 2023 à 17:27, David Vidal <notifications@odoo-community.org> a écrit :
As far as I know it serves just informative purposes (i.e. portal views of the documents show that they're pending unless confirmed/payed. But yes, I'd also expect it to have at least a way to confirm those transactions manually
El mié, 13 sept 2023 a las 9:47, Radovan Skolnik (<notifications@odoo-community.org>) escribió:
Hello,

hope this will not be a stupid question - I searched through all the Odoo sources, all OCA modules but couldn't find any answer. The scenario is really simple: Wire Transfer (payment_custom in 16.0, payment_transfer in previous versions) is selected as payment provider in e-shop (website_sale). Payment transcation (payment.transaction) object is created in Pending state. The question is: is there anything anywhere that would change its state to Confirmed (done)? I would assume imported bank statements could but I cannot see that anywhere (was mainly looking for _set_done() method calls but tried other means of search as well). Would be greateful if somebody shed some light on this for me.

Thank you very much. Best regards

	Radovan Skolnik
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
---
[ Youness @ MAAFI ]

Tel: +49.176.368.378.62
Email: youness.maafi@gmail.com

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Enric Tobella Alomar

CEO & Founder

www.dixmit.com

by Enric Tobella Alomar - 07:36 - 13 Sep 2023

Re: A (hope not stupid) question about wire transfer payment transactions

I'm using mostly Community but have searched through Enterprise sources as well. AFAIK there is no difference in this area between the two. Checked versions 16 and 15 but the older ones are the same AFAICT.

Best regards,

Radovan

On Sep 13, 2023 19:06, Youness Maafi <notifications@odoo-community.org> wrote:

Hi Skolnik,
Your question is not a stupid one at all, all questions are smart.
I for example, or maybe anyone whose mind is not fresh about the subject, would need to know first the Odoo version you are using, and in which edition ( EE or CE ) ? Can you share this with me ?
I hope I can help afterwards, ( it will be much easier )

Thanks,
Le mer. 13 sept. 2023 à 17:27, David Vidal <notifications@odoo-community.org> a écrit :
As far as I know it serves just informative purposes (i.e. portal views of the documents show that they're pending unless confirmed/payed. But yes, I'd also expect it to have at least a way to confirm those transactions manually
El mié, 13 sept 2023 a las 9:47, Radovan Skolnik (<notifications@odoo-community.org>) escribió:
Hello,

hope this will not be a stupid question - I searched through all the Odoo sources, all OCA modules but couldn't find any answer. The scenario is really simple: Wire Transfer (payment_custom in 16.0, payment_transfer in previous versions) is selected as payment provider in e-shop (website_sale). Payment transcation (payment.transaction) object is created in Pending state. The question is: is there anything anywhere that would change its state to Confirmed (done)? I would assume imported bank statements could but I cannot see that anywhere (was mainly looking for _set_done() method calls but tried other means of search as well). Would be greateful if somebody shed some light on this for me.

Thank you very much. Best regards

	Radovan Skolnik
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
---
[ Youness @ MAAFI ]

Tel: +49.176.368.378.62
Email: youness.maafi@gmail.com

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Radovan Skolnik - 07:21 - 13 Sep 2023

Re: A (hope not stupid) question about wire transfer payment transactions

Hi Skolnik,
Your question is not a stupid one at all, all questions are smart.
I for example, or maybe anyone whose mind is not fresh about the subject, would need to know first the Odoo version you are using, and in which edition ( EE or CE ) ? Can you share this with me ?
I hope I can help afterwards, ( it will be much easier )

Thanks,

Le mer. 13 sept. 2023 à 17:27, David Vidal <notifications@odoo-community.org> a écrit :

As far as I know it serves just informative purposes (i.e. portal views of the documents show that they're pending unless confirmed/payed. But yes, I'd also expect it to have at least a way to confirm those transactions manually
El mié, 13 sept 2023 a las 9:47, Radovan Skolnik (<notifications@odoo-community.org>) escribió:
Hello,

hope this will not be a stupid question - I searched through all the Odoo sources, all OCA modules but couldn't find any answer. The scenario is really simple: Wire Transfer (payment_custom in 16.0, payment_transfer in previous versions) is selected as payment provider in e-shop (website_sale). Payment transcation (payment.transaction) object is created in Pending state. The question is: is there anything anywhere that would change its state to Confirmed (done)? I would assume imported bank statements could but I cannot see that anywhere (was mainly looking for _set_done() method calls but tried other means of search as well). Would be greateful if somebody shed some light on this for me.

Thank you very much. Best regards

	Radovan Skolnik
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

---

[ Youness @ MAAFI ]

Tel: +49.176.368.378.62
Email: youness.maafi@gmail.com

by Youness Maafi - 07:06 - 13 Sep 2023

tool: Odoo Modules Migration

Hi!
I wrote a simple tool which helps me keeping an overview of module 
upgrades during ongoing upgrade projects, especially for a large amount 
of modules. I hope someone finds it useful.

https://github.com/Nitrokey/odoo-modules-migration

Best regards
Jan

by Jan Suhr - 06:05 - 13 Sep 2023

Re: A (hope not stupid) question about wire transfer payment transactions

As far as I know it serves just informative purposes (i.e. portal views of the documents show that they're pending unless confirmed/payed. But yes, I'd also expect it to have at least a way to confirm those transactions manually

El mié, 13 sept 2023 a las 9:47, Radovan Skolnik (<notifications@odoo-community.org>) escribió:

Hello,

hope this will not be a stupid question - I searched through all the Odoo sources, all OCA modules but couldn't find any answer. The scenario is really simple: Wire Transfer (payment_custom in 16.0, payment_transfer in previous versions) is selected as payment provider in e-shop (website_sale). Payment transcation (payment.transaction) object is created in Pending state. The question is: is there anything anywhere that would change its state to Confirmed (done)? I would assume imported bank statements could but I cannot see that anywhere (was mainly looking for _set_done() method calls but tried other means of search as well). Would be greateful if somebody shed some light on this for me.

Thank you very much. Best regards

	Radovan Skolnik

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by David Vidal - 05:26 - 13 Sep 2023

A (hope not stupid) question about wire transfer payment transactions

Hello,

hope this will not be a stupid question - I searched through all the Odoo sources, all OCA modules but couldn't find any answer. The scenario is really simple: Wire Transfer (payment_custom in 16.0, payment_transfer in previous versions) is selected as payment provider in e-shop (website_sale). Payment transcation (payment.transaction) object is created in Pending state. The question is: is there anything anywhere that would change its state to Confirmed (done)? I would assume imported bank statements could but I cannot see that anywhere (was mainly looking for _set_done() method calls but tried other means of search as well). Would be greateful if somebody shed some light on this for me.

Thank you very much. Best regards

	Radovan Skolnik

by Radovan Skolnik - 09:46 - 13 Sep 2023

Re: 100 % coverage not enough?

El lun, 11-09-2023 a las 08:41 +0000, Ronald Portier escribió:

The decrease must be an artifact of comparing a branch based on an older version of the main branch, that had less coverage overall, with the current version of the main branch

Maybe coverage can be compared to the latest parent commit of the oldest PR commit? That way, we could be sure if it's really increasing.

by Jairo Llopis - 08:40 - 13 Sep 2023

Re: 100 % coverage not enough?

Hi,

Rebasing the branch, as suggegested by Jairo solved the problem. So let us keep that in mind with future occurences of this issue.

Denis, I understand why you do not want to remove the check, but I do not see how a PR that only concerns one module, could influence other modules. The decrease must be an artifact of comparing a branch based on an older version of the main branch, that had less coverage overall, with the current version of the main branch. However merging such a PR will not undo the changes that have occurred in the main branch since creating the PR/feature branch. So the proper measure on whether a PR increases or decreases overall coverage would be to compare the coverage percentage in only the patch (the changed code) with the overall coverage of the project (the main branch).

Kind regards, Ronald

Op 11-09-2023 om 10:22 schreef Roussel, Denis:

The answer is in the details link.

@jairo I don't agree about removing that check.

The 'patch' coverage report concerns exclusively the code you introduce with your PR.

The 'project' coverage report concerns the already existing code outside your PR. So, a decrease there means that your PR influences other modules (not executing a super in an inherited method, ...)

Even if coverage is not mandatory in OCA, it gives indicators on technical tests quality.

My two cents
On Mon, Sep 11, 2023 at 10:11 AM jairo <notifications@odoo-community.org> wrote:
El vie, 08-09-2023 a las 18:57 +0000, Ronald Portier escribió:
Supposedly the PR would decrease the overall coverage percentage. How??
The 1st thing you need to know is that hose checks are not required.

Now, this is how your PR looks:

That ✅ is telling the reviewer that the PR has a 100% of coverage. That's the important part.

The ❌ however is the weirdo. Sometimes it happens, so I systematically ignore that check. IMHO it could be removed. My guess is that the base branch evolved and got more coverage, and that if you rebased it would always increase. But maybe it's just a bug somewhere.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--

Denis Roussel
Software Engineer
T : +32 2 888 31 49
M : +32 472 22 00 57

Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium

Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

Zone industrielle 22 | L-8287 Kehlen | Luxembourg

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by "Ronald Portier" <rportier@therp.nl> - 10:40 - 11 Sep 2023

Re: 100 % coverage not enough?

The answer is in the details link.

@jairo I don't agree about removing that check.

The 'patch' coverage report concerns exclusively the code you introduce with your PR.

The 'project' coverage report concerns the already existing code outside your PR. So, a decrease there means that your PR influences other modules (not executing a super in an inherited method, ...)

Even if coverage is not mandatory in OCA, it gives indicators on technical tests quality.

My two cents

On Mon, Sep 11, 2023 at 10:11 AM jairo <notifications@odoo-community.org> wrote:

El vie, 08-09-2023 a las 18:57 +0000, Ronald Portier escribió:
Supposedly the PR would decrease the overall coverage percentage. How??
The 1st thing you need to know is that hose checks are not required.

Now, this is how your PR looks:

That ✅ is telling the reviewer that the PR has a 100% of coverage. That's the important part.

The ❌ however is the weirdo. Sometimes it happens, so I systematically ignore that check. IMHO it could be removed. My guess is that the base branch evolved and got more coverage, and that if you rebased it would always increase. But maybe it's just a bug somewhere.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

--

Denis Roussel
Software Engineer
T : +32 2 888 31 49
M : +32 472 22 00 57

Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium

Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

Zone industrielle 22 | L-8287 Kehlen | Luxembourg

by Denis Roussel - 10:21 - 11 Sep 2023

Re: 100 % coverage not enough?

El vie, 08-09-2023 a las 18:57 +0000, Ronald Portier escribió:

Supposedly the PR would decrease the overall coverage percentage. How??

The 1st thing you need to know is that hose checks are not required.

Now, this is how your PR looks:

That ✅ is telling the reviewer that the PR has a 100% of coverage. That's the important part.

The ❌ however is the weirdo. Sometimes it happens, so I systematically ignore that check. IMHO it could be removed. My guess is that the base branch evolved and got more coverage, and that if you rebased it would always increase. But maybe it's just a bug somewhere.

by Jairo Llopis - 10:11 - 11 Sep 2023

1 attachments 1 attachments

Archives

Contributors

Re: Confirm unsubscription to Contributors

Re: Auto unsubscribe

Re: Auto unsubscribe

Re: Auto unsubscribe

Re: Confirm unsubscription to Contributors

Auto unsubscribe

Confirm unsubscription to Contributors

OCA Days Talk Proposals - submissions close Friday 15th September

Re: Best practice add optional="show" when adding fields in tree views

Re: A (hope not stupid) question about wire transfer payment transactions

Re: A (hope not stupid) question about wire transfer payment transactions

Re: A (hope not stupid) question about wire transfer payment transactions

Re: A (hope not stupid) question about wire transfer payment transactions

tool: Odoo Modules Migration

Re: A (hope not stupid) question about wire transfer payment transactions

A (hope not stupid) question about wire transfer payment transactions

Re: 100 % coverage not enough?

Re: 100 % coverage not enough?

Re: 100 % coverage not enough?

Re: 100 % coverage not enough?

Follow us