Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Re: apologies for mass PR creation

Archives

Contributors

Re: apologies for mass PR creation

Re: apologies for mass PR creation

Thanks for the apologies. I think this kind of massive changes that has nothing to do with the community and that involves a lot of repositories, should be planned with the community (like now you are doing with this message).

Following that, anything done massively should have a pilot test to check that everything is OK instead of blindly performing 100 PRs. The commit message was not following the conventions, and that meant to double the number of pipelines to execute. I know this is not something that costs us directly (apart from a delay in all the real contributions checks), but we should also see for the environment not wasting CPU resources.

Well, I don't want to dig more into something that has no remedy. Just for future actions. Now, a less impacting way to do this is as some proposals:

- To be changed only for newer branches or when an update is done, like ForgeFlow did to pass from Eficent.
- Do it progressively.
- Do it directly for not having 3 checks: the PR one + the ocabot one + the merge one.

And I add another one: you can put `[ci skip]` at the end of the commit message for avoiding the check at all, but this only serves if you do directly the write or merge the PR without ocabot.

Regards.
by Pedro M. Baeza - 01:51 - 14 Jun 2024

Reference

  • apologies for mass PR creation 
    Hello everyone,

I asked yesterday Vincent to fix the name of Camptocamp in the manifest 
of the OCA addons, without realizing the impact this would have on the CI.

We are sorry for the disruption caused, and I should have checked before 
acting about the proper way to do this. Please accept our humble apologies.

Now if you have a recommendation on how to deal with the update in the 
proper way, we will be happy to get your feedback.

Kind regards,


-- 
Alexandre Fayolle
    by Alexandre Fayolle - 12:21 - 14 Jun 2024

    6 replies 6 replies

    • Re: apologies for mass PR creation
      Thanks for the apologies. I think this kind of massive changes that has nothing to do with the community and that involves a lot of repositories, should be planned with the community (like now you are doing with this message).

      Following that, anything done massively should have a pilot test to check that everything is OK instead of blindly performing 100 PRs. The commit message was not following the conventions, and that meant to double the number of pipelines to execute. I know this is not something that costs us directly (apart from a delay in all the real contributions checks), but we should also see for the environment not wasting CPU resources.

      Well, I don't want to dig more into something that has no remedy. Just for future actions. Now, a less impacting way to do this is as some proposals:

      - To be changed only for newer branches or when an update is done, like ForgeFlow did to pass from Eficent.
      - Do it progressively.
      - Do it directly for not having 3 checks: the PR one + the ocabot one + the merge one.

      And I add another one: you can put `[ci skip]` at the end of the commit message for avoiding the check at all, but this only serves if you do directly the write or merge the PR without ocabot.

      Regards.
      by Pedro M. Baeza - 01:51 - 14 Jun 2024
    • Re: apologies for mass PR creation 
      We can possibly find someone. Still, it would be nice to avoid 
triggering a full CI chain of all the affected branches. I'm not sure if 
there is a way to tell the gihub actions to skip all or parts of the checks?

Alexandre

On 14/06/2024 13:07, Alexey Pelykh wrote:

> IMHO, there's no other way to do that unless someone with write access 

> to the repos will exceptionally commit/merge those changes from local repo

> 

> Thus maybe just balancing a-repo-a-day?
      by Alexandre Fayolle - 01:25 - 14 Jun 2024
    • Re: apologies for mass PR creation 
      We can possibly find someone. Still, it would be nice to avoid 
triggering a full CI chain of all the affected branches. I'm not sure if 
there is a way to tell the gihub actions to skip all or parts of the checks?

Alexandre

On 14/06/2024 13:07, Alexey Pelykh wrote:

> IMHO, there's no other way to do that unless someone with write access 

> to the repos will exceptionally commit/merge those changes from local repo

> 

> Thus maybe just balancing a-repo-a-day?

> 

>> On 14 Jun 2024, at 12:47, Vincent Van Rossem 

>> <notifications@odoo-community.org> wrote:

>>

>> Hello dear Community and Contributors,

>>

>> My apologies for mass creating PRs and for wasting resources.

>>

>> Kind regards,

>>

>> Vincent

>>

>> On Fri, Jun 14, 2024 at 12:22 PM Alexandre Fayolle 

>> <notifications@odoo-community.org 

>> <mailto:notifications@odoo-community.org>> wrote:

>>

>>     Hello everyone,

>>

>>     I asked yesterday Vincent to fix the name of Camptocamp in the manifest

>>     of the OCA addons, without realizing the impact this would have on the CI.

>>

>>     We are sorry for the disruption caused, and I should have checked before

>>     acting about the proper way to do this. Please accept our humble apologies.

>>

>>     Now if you have a recommendation on how to deal with the update in the

>>     proper way, we will be happy to get your feedback.

>>

>>     Kind regards,

>>

>>     -- Alexandre Fayolle

>>

>>     _______________________________________________

>>     Mailing-List: https://odoo-community.org/groups/contributors-15

>>     <https://odoo-community.org/groups/contributors-15>

>>     Post to: mailto:contributors@odoo-community.org

>>     <mailto:contributors@odoo-community.org>

>>     Unsubscribe: https://odoo-community.org/groups?unsubscribe

>>     <https://odoo-community.org/groups?unsubscribe>

>>

>> _______________________________________________

>> Mailing-List: https://odoo-community.org/groups/contributors-15 

>> <https://odoo-community.org/groups/contributors-15>

>> Post to: mailto:contributors@odoo-community.org

>> Unsubscribe: https://odoo-community.org/groups?unsubscribe 

>> <https://odoo-community.org/groups?unsubscribe>

>>

> 

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 

> <https://odoo-community.org/groups/contributors-15>

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe 

> <https://odoo-community.org/groups?unsubscribe>

> 


-- 
Alexandre Fayolle
Senior Software Engineer
Tel : +33 4 58 48 20 30

Camptocamp France SAS
18 rue du Lac Saint André
73 370 Le Bourget-du-Lac
France

http://www.camptocamp.com
      by Alexandre Fayolle - 01:25 - 14 Jun 2024
    • Re: apologies for mass PR creation
      Hi,

      That reflects the amount of work you did 'til now :-)

      I would say, at that time, code was done by 'Camptocamp SA'. So, it should not be changed before a new module update. I think the approach used by Forgeflow. You can have a talk with Jordi or Lois.

      My two cents

      Le ven. 14 juin 2024, 13:07, Alexey Pelykh <notifications@odoo-community.org> a écrit :

      IMHO, there's no other way to do that unless someone with write access to the repos will exceptionally commit/merge those changes from local repo

      Thus maybe just balancing a-repo-a-day?

      On 14 Jun 2024, at 12:47, Vincent Van Rossem <notifications@odoo-community.org> wrote:

      Hello dear Community and Contributors,

      My apologies for mass creating PRs and for wasting resources.

      Kind regards,

      Vincent

      On Fri, Jun 14, 2024 at 12:22 PM Alexandre Fayolle <notifications@odoo-community.org> wrote:
      Hello everyone,

I asked yesterday Vincent to fix the name of Camptocamp in the manifest 
of the OCA addons, without realizing the impact this would have on the CI.

We are sorry for the disruption caused, and I should have checked before 
acting about the proper way to do this. Please accept our humble apologies.

Now if you have a recommendation on how to deal with the update in the 
proper way, we will be happy to get your feedback.

Kind regards,




-- 
Alexandre Fayolle

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe


      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Denis Roussel - 01:25 - 14 Jun 2024
    • Re: apologies for mass PR creation

      IMHO, there's no other way to do that unless someone with write access to the repos will exceptionally commit/merge those changes from local repo

      Thus maybe just balancing a-repo-a-day?

      On 14 Jun 2024, at 12:47, Vincent Van Rossem <notifications@odoo-community.org> wrote:

      Hello dear Community and Contributors,

      My apologies for mass creating PRs and for wasting resources.

      Kind regards,

      Vincent

      On Fri, Jun 14, 2024 at 12:22 PM Alexandre Fayolle <notifications@odoo-community.org> wrote:
      Hello everyone,

I asked yesterday Vincent to fix the name of Camptocamp in the manifest 
of the OCA addons, without realizing the impact this would have on the CI.

We are sorry for the disruption caused, and I should have checked before 
acting about the proper way to do this. Please accept our humble apologies.

Now if you have a recommendation on how to deal with the update in the 
proper way, we will be happy to get your feedback.

Kind regards,



-- 
Alexandre Fayolle

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe


      by Alexey Pelykh - 01:06 - 14 Jun 2024