Archives
Contributors
Module loading priority and inheritance
Hi,
I just installed the auth_totp module to add MFA support to our odoo 12.0 instance and its behaviour is totally broken after a server restart when the auth_ldap module is also installed.
Because _check_credentials logic is just made to accept at least one Valid authentication and not globally refuse any authentication, the current implementation of the auth_totp will always fail if a module validate
_check_credentials
after that the MfaLoginNeeded exception is raised.
To me it's more a framework issue and the manifest should allow a new priority value to sort modules without inter-dependencies (because actually, it seems to use an alphabetic sorting based on module name).
But without this, how do you handle such situations ?
--
Yann PAPOUIN, Ingénieur R&D | DEC
Yann PAPOUIN, Ingénieur R&D | DEC
by Yann Papouin - 03:31 - 15 Jun 2022
Follow-Ups
-
Re: Module loading priority and inheritance
Richard, I understand your concern about the priority number, but having it in our toolbox could still be extremely useful.As a first step, I made a PR that implements both:Contrary to my original proposal, I don't alter the SQL query, the sorting is done in python like the dependency loading by using the manifest attributes (not stored in the DB)
by Yann Papouin - 03:21 - 17 Jun 2022 -
Re: Module loading priority and inheritance
Yann,
Yes, we too have occasionally encountered such issues. Bridging modules are sometimes required to ensure correct execution, but then, that is still for modules all within our control.
We often find the issue worst when using a third-party app, where there is a complete method overwrite (and maybe justifiably so).
Under your proposal, though, one would need to know about the modules causing the issue - which generally, I guess, is feasable.
I do wonder, though, if implementing a "soft_depends" as opposed to a loading priority, is better.
If randomly, in a manifest, there is a loading priority, then you sort of need to know and set all the other loading priorities, even in the third party modules, which may have their own issues.
A soft depends, at least, it is clear that "this module has a conflict with that module which is now resolved by this dependency", as a priority number just gets lost (like sequences on views when you have many modules extending views)
I would love to see something in this area...
Richard
Kind Regards
T: (03) 9135 1900 | M: 0403 76 76 76 | A: Bld 10/435 Williamstown Road, Port Melbourne, 3207
MAKING GROWTH THROUGH TECHNOLOGY EASY
Notice: This email and any files transmitted with it are confidential and are intended solely for the use of the individual or entity to which they are addressed. If you are not the intended recipient, you may not disclose or use the information in this email in any way. If you have received this email in error please notify the sender. Although reasonable precautions have been taken to ensure no viruses are present in this email, no responsibility is accepted by WilldooIT Pty Ltd or its related entities for any loss or damage arising from the use of this email or attachments. Any views expressed in this email or file attachments are those of the individual sender only, unless expressly stated to be those of WilldooIT Pty Ltd ABN 85 006 073 052 or any of its related entities.
From: Yann Papouin <ypa@decgroupe.com>
Sent: Friday, 17 June 2022 7:02 PM
To: Contributors <contributors@odoo-community.org>
Subject: Re: Module loading priority and inheritanceAfter investigation, the sequence field is only used for the kanban view to display applications in a specific order.
Module list is fetched from database in odoo/odoo/modules/loading.py::load_marked_modules with this query
cr.execute("SELECT name from ir_module_module WHERE state IN %s" ,(tuple(states),))
So, the module loading order actually depends on 4 params:- PostgreSQL database collation
- Module name
- Datetime of the creation of the ir_module_module row (since no ORDER BY is defined in the query)
- The dependencies
That's a terrible loading implementation as the parameter 3 is based on an internal postgreSQL data, it also depends on the list order of your addons_path and also depends on when odoo/addons/base/models/ir_module.py::update_list is called.Example for this last assertion:
- On the development database:
- You add the module account_extra, that depends on account and override method update_something, in your main addons path
- update_list()
- Two weeks later, you add the module account_best , that also depends on account and also override the method update_something, in your main addons path
- update_list()
- Module account_extra will be loaded before account_best
- Three weeks later, on the production database:
- You add modules account_extra and account_best in your main addons path
- update_list()
- Module account_best will be loaded before account_extra
And there I'm not talking about other cases like:- Multiple addons_path
- Manual module deletion from odoo module list followed by a module list update
- Manual module installation from UI whereas the server is already started with loaded modules
So, I agree that most cases would be solved by the depends attribute but a fix could still be:- Add a loading_priority manifest key:
- default value is 0 if not set, could be positive (load before) or negative (load after)
- add an ORDER BY loading_priority, name
in all SQL query of the loading.py
- Add a soft_depends manifest key:
- a list of modules that we depends on, only if they exists and are installed
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by "Richard deMeester" <richard.demeester@willdooit.com> - 02:46 - 17 Jun 2022 -
Re: Module loading priority and inheritance
Thanks for the investigation. Your proposals seems good, but not sure if Odoo will add such mechanisms in the framework. You can try.Regards.
by Pedro M. Baeza - 12:26 - 17 Jun 2022 -
Re: Module loading priority and inheritance
After investigation, the sequence field is only used for the kanban view to display applications in a specific order.Module list is fetched from database in odoo/odoo/modules/loading.py::load_marked_modules with this querycr.execute("SELECT name from ir_module_module WHERE state IN %s" ,(tuple(states),))So, the module loading order actually depends on 4 params:
- PostgreSQL database collation
- Module name
- Datetime of the creation of the ir_module_module row (since no ORDER BY is defined in the query)
- The dependencies
That's a terrible loading implementation as the parameter 3 is based on an internal postgreSQL data, it also depends on the list order of your addons_path and also depends on when odoo/addons/base/models/ir_module.py::update_list is called.Example for this last assertion:- On the development database:
- You add the module account_extra, that depends on account and override method update_something, in your main addons path
- update_list()
- Two weeks later, you add the module account_best , that also depends on account and also override the method update_something, in your main addons path
- update_list()
- Module account_extra will be loaded before account_best
- Three weeks later, on the production database:
- You add modules account_extra and account_best in your main addons path
- update_list()
- Module account_best will be loaded before account_extra
And there I'm not talking about other cases like:- Multiple addons_path
- Manual module deletion from odoo module list followed by a module list update
- Manual module installation from UI whereas the server is already started with loaded modules
So, I agree that most cases would be solved by the depends attribute but a fix could still be:- Add a loading_priority manifest key:
- default value is 0 if not set, could be positive (load before) or negative (load after)
- add an ORDER BY
loading_priority, name
in all SQL query of the loading.py
- Add a soft_depends manifest key:
- a list of modules that we depends on, only if they exists and are installed
by Yann Papouin - 11:00 - 17 Jun 2022 -
Re: Module loading priority and inheritance
AFAIK, there's a `sequence` manifest key for such loading order.Regards.
by Pedro M. Baeza - 05:26 - 15 Jun 2022
