Contributors

Review PR, that fixes web_view_searchpanel for 12.0

Stock valuation and property propagation on Odoo 12

Accelerated approval of pull requests

Dear OCA-Maintainers,

i am reaching out to you to request accelerated approval of two pull requests i recently created:

https://github.com/OCA/web/pull/1805

Affected modules: web_ir_actions_close_wizard_refresh_view
Purpose: Migration to 13.0

https://github.com/OCA/operating-unit/pull/356/

Affected modules: sale_stock_operating_unit, stock_account_operating_unit
Purpose: Migration to 13.0

Both pull requests only contain simple migrations, no features were added, which need to be reviewed.
I am contacting you since it is critical for my organsation to have the resulting Wheels in Wheelhouse soon.

Many thanks in advance, you are doing a great job!

Best regards,

Bastian Guenther | BI ERP Developer | AMETRAS intelligence GmbH

by "Bastian Guenther" <Bastian.Guenther@ametras.com> - 11:55 - 5 Feb 2021

Follow-Ups

Re: Accelerated approval of pull requests
I'd say that rule is inspired from science, where you get three blind reviews for any research paper that you submit for publication. Here we get two transparent reviews, so the rule should be adjusted then: review 2 PRs, expect 1 PR reviewed.

camptocamp
INNOVATIVE SOLUTIONS
BY OPEN SOURCE EXPERTS

Carlos Serra-Toro
Senior Software Engineer
Business Solutions

www.camptocamp.com

On Fri, 5 Feb 2021 at 14:37, Rafael Blasco <rblasco@rbnpro.com> wrote:
+1

Review 3 PR and expect get reviewed 1 PR (Fayolle rules!). OCA’s traffic jump come from everyone expect reviews but don’t review.

Give fist receive later.

J

De: Holger Brunn
Enviado el: viernes, 5 de febrero de 2021 13:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Accelerated approval of pull requests

Hi Bastian,

> i am reaching out to you to request accelerated approval of two pull

> requests i recently created:

thank you for your efforts. As contributing as a collaborative effort, I suggest
you review some other PRs, and then politely point those PRs' authors to your
own PRs. Reviewing is work we need to share.

Best regards,
Holger

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Carlos Serra-Toro - 08:51 - 8 Feb 2021
Re: Accelerated approval of pull requests
+1

I will happy to give fist

Op 2/5/21 om 2:37 PM schreef Rafael Blasco:

+1

Review 3 PR and expect get reviewed 1 PR (Fayolle rules!). OCA’s traffic jump come from everyone expect reviews but don’t review.

Give fist receive later.

J

De: Holger Brunn
Enviado el: viernes, 5 de febrero de 2021 13:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Accelerated approval of pull requests

Hi Bastian,

> i am reaching out to you to request accelerated approval of two pull

> requests i recently created:

thank you for your efforts. As contributing as a collaborative effort, I suggest

you review some other PRs, and then politely point those PRs' authors to your

own PRs. Reviewing is work we need to share.

Best regards,

Holger

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Tom Blauwendraat - 04:46 - 5 Feb 2021
RE: Accelerated approval of pull requests
+1

Review 3 PR and expect get reviewed 1 PR (Fayolle rules!). OCA’s traffic jump come from everyone expect reviews but don’t review.

Give fist receive later.

J

De: Holger Brunn
Enviado el: viernes, 5 de febrero de 2021 13:57
Para: Contributors <contributors@odoo-community.org>
Asunto: Re: Accelerated approval of pull requests

Hi Bastian,

> i am reaching out to you to request accelerated approval of two pull

> requests i recently created:

thank you for your efforts. As contributing as a collaborative effort, I suggest
you review some other PRs, and then politely point those PRs' authors to your
own PRs. Reviewing is work we need to share.

Best regards,
Holger
by Rafael Blasco (Moduon) - 02:31 - 5 Feb 2021

Re: Accelerated approval of pull requests

Hi Bastian,


> i am reaching out to you to request accelerated approval of two pull

> requests i recently created:

thank you for your efforts. As contributing as a collaborative effort, I suggest 
you review some other PRs, and then politely point those PRs' authors to your 
own PRs. Reviewing is work we need to share.

Best regards,
Holger


-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com

by Holger Brunn - 01:56 - 5 Feb 2021

1 attachments 1 attachments

Re: Accelerated approval of pull requests

Yes, this is the right direction.

I deploy from Git, but don't rely on OCA merges.
I run project specific branches where my OCA PRs are early merged, and deploy from there.

/Daniel

On 05/02/2021 12:07, Sergio Corato wrote: